All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Garcia Blanco <juanrgar@gmail.com>
To: buildroot@buildroot.org
Cc: Juan Garcia Blanco <juanrgar@gmail.com>
Subject: [Buildroot] [PATCH] support/dependencies/dependencies.sh: fix check for CWD in env vars
Date: Sat, 19 Mar 2022 22:45:35 +0100	[thread overview]
Message-ID: <20220319214536.2417-1-juanrgar@gmail.com> (raw)

The previous pattern incorrectly matches against path lists that don't
contain CWD, but end with ':', e.g., exported like VAR=<...>:$VAR where
$VAR is empty.

Now the pattern explicitly checks for $PWD in the path list.

Signed-off-by: Juan Garcia Blanco <juanrgar@gmail.com>
---
 support/dependencies/dependencies.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index c604a9efcc..d1fe94c9b9 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -16,7 +16,7 @@ fi
 
 # Sanity check for CWD in LD_LIBRARY_PATH
 case ":${LD_LIBRARY_PATH:-unset}:" in
-(*::*|*:.:*)
+(*:$PWD:*|*:.:*)
 	echo
 	echo "You seem to have the current working directory in your"
 	echo "LD_LIBRARY_PATH environment variable. This doesn't work."
@@ -32,7 +32,7 @@ esac
 # An empty PATH is technically possible, but in practice we would not
 # even arrive here if that was the case.
 case ":${PATH:-unset}:" in
-(*::*|*:.:*)
+(*:$PWD:*|*:.:*)
 	echo
 	echo "You seem to have the current working directory in your"
 	echo "PATH environment variable. This doesn't work."
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2022-03-19 21:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-19 21:45 Juan Garcia Blanco [this message]
2022-03-20  8:46 ` [Buildroot] [PATCH] support/dependencies/dependencies.sh: fix check for CWD in env vars Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220319214536.2417-1-juanrgar@gmail.com \
    --to=juanrgar@gmail.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.