From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDF6DC433F5 for ; Mon, 21 Mar 2022 14:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A6r98LTBYpOThINFRAN641jBTqjpLncTdZM0nd86kq8=; b=MiKXWFggY4gRIz ZC9XFpI8Zuwv5gN4/ybXISt41iTGCf3UX3w6i07dwsMK8nX0EU3Crbp49+80dEZez9ra68IKvkVnX HaYD1bM1hRppKJjiJEokpKy9Sg+mmDWQ69fkgBu3PDZh5m639akTjgV3dMkZj6x6YlJgSLgI87ANn /HFcz48JHOzQWaR5JYFVL2Ku07O01D83f8GfZZcpopjHbTP7sWHafDj3l6fnCQqqNtJW8A/MsBWo4 KA5bTUSXnFmEQ9iOcQZwo5wqDCrvd79RC01XqDaafZcVMgLysPT5P5Zlg2Y1sEYuRJanmsuoSHBpI TFdBGtRgT2qyUckHHwbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJSO-0085de-6O; Mon, 21 Mar 2022 14:56:28 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJSK-0085cv-G1 for linux-mtd@lists.infradead.org; Mon, 21 Mar 2022 14:56:26 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 2473560003; Mon, 21 Mar 2022 14:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1647874581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JAo/x8R7rAbW3xDbvvHX3hFb31xZ9EbfQa3/rwY/KzY=; b=jj45yubSTsmuEFkrh/iP5XbVEA2Mew4nLlY7ITc4EtuLPueXWnPfsxWdRc9kOlUxTMGwZP EVusUHou97LymkpOCPmm3U3TpkETAlUJlbJ8RmzaQv4UeeaS8ooVvsN828zW0eKrUywWH/ K09lVSgwAwibsxETjOWAKoCrt4TCdUXJUKq5dUszlvgu9eu2jLANgfIsA4sfdvwceuT99X 1KIUyezsRPRdbBIAlqMfH1hWVnmDIjLkZaD3gYEIFoLRpuUh459gDs1/fzqbua52wFBt55 la/bejwmebBdYa+KReyCtrpacPRxMVtCqjNtwU2MlLtFopemRxaAOAudq1b0YA== Date: Mon, 21 Mar 2022 15:56:18 +0100 From: Miquel Raynal To: Thorsten Leemhuis Cc: Tokunori Ikegami , linux-mtd@lists.infradead.org, Ahmad Fatoum , stable@vger.kernel.org Subject: Re: [PATCH v4 2/3] mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N Message-ID: <20220321155618.7bfa214e@xps13> In-Reply-To: <3ed10e7e-1c73-6464-b1df-6c6e086fa162@leemhuis.info> References: <20220316155455.162362-1-ikegami.t@gmail.com> <20220316155455.162362-3-ikegami.t@gmail.com> <20220321133529.2d3addaf@xps13> <20220321144134.3076a2ba@xps13> <3ed10e7e-1c73-6464-b1df-6c6e086fa162@leemhuis.info> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220321_075625_068664_968E5375 X-CRM114-Status: GOOD ( 37.55 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgVGhvcnN0ZW4sCgpyZWdyZXNzaW9uc0BsZWVtaHVpcy5pbmZvIHdyb3RlIG9uIE1vbiwgMjEg TWFyIDIwMjIgMTU6MTc6NTAgKzAxMDA6Cgo+IE9uIDIxLjAzLjIyIDE0OjQxLCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+ID4gcmVncmVzc2lvbnNAbGVlbWh1aXMuaW5mbyB3cm90ZSBvbiBNb24sIDIx IE1hciAyMDIyIDEzOjUxOjEwICswMTAwOiAgCj4gPj4gT24gMjEuMDMuMjIgMTM6MzUsIE1pcXVl bCBSYXluYWwgd3JvdGU6ICAKPiA+Pj4gcmVncmVzc2lvbnNAbGVlbWh1aXMuaW5mbyB3cm90ZSBv biBNb24sIDIxIE1hciAyMDIyIDEyOjQ4OjExICswMTAwOgo+ID4+PiAgCj4gPj4+PiBPbiAxNi4w My4yMiAxNjo1NCwgVG9rdW5vcmkgSWtlZ2FtaSB3cm90ZTogIAo+ID4+Pj4+IEFzIHBvaW50ZWQg b3V0IGJ5IHRoaXMgYnVnIHJlcG9ydCBbMV0sIGJ1ZmZlcmVkIHdyaXRlcyBhcmUgbm93IGJyb2tl biBvbgo+ID4+Pj4+IFMyOUdMMDY0Ti4gVGhpcyBpc3N1ZSBjb21lcyBmcm9tIGEgcmV3b3JrIHdo aWNoIHN3aXRjaGVkIGZyb20gdXNpbmcgY2hpcF9nb29kKCkKPiA+Pj4+PiB0byBjaGlwX3JlYWR5 KCksIGJlY2F1c2UgRFEgdHJ1ZSBkYXRhIDB4RkYgaXMgcmVhZCBvbiBTMjlHTDA2NE4gYW5kIGFu IGVycm9yCj4gPj4+Pj4gcmV0dXJuZWQgYnkgY2hpcF9nb29kKCkuIE9uZSB3YXkgdG8gc29sdmUg dGhlIGlzc3VlIGlzIHRvIHJldmVydCB0aGUgY2hhbmdlCj4gPj4+Pj4gcGFydGlhbGx5IHRvIHVz ZSBjaGlwX3JlYWR5IGZvciBTMjlHTDA2NE4uCj4gPj4+Pj4KPiA+Pj4+PiBbMV0gaHR0cHM6Ly9s b3JlLmtlcm5lbC5vcmcvci9iNjg3YzI1OS02NDEzLTI2YzktZDRjOS1iM2FmYTY5ZWExMjRAcGVu Z3V0cm9uaXguZGUvICAgIAo+ID4+Pj4KPiA+Pj4+IFdoeSBkaWQgeW91IHN3aXRjaCBmcm9tIHRo ZSBkb2N1bWVudGVkIGZvcm1hdCBmb3IgbGlua3MgeW91IGFkZGVkIG9uIG15Cj4gPj4+PiByZXF1 ZXN0IChzZWUKPiA+Pj4+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3N0YWJsZS9mMWI0NGU4Ny1l NDU3LTc3ODMtZDQ2ZS0wZDU3N2NlYTNiNzJAbGVlbWh1aXMuaW5mby8KPiA+Pj4+Cj4gPj4+PiAp IHRvIHYyIHRvIHNvbWV0aGluZyBlbHNlIHRoYXQgaXMgbm90IHJlY29nbml6ZWQgYnkgdG9vbHMg YW5kIHNjcmlwdHMKPiA+Pj4+IHRoYXQgcmVseSBvbiBwcm9wZXIgbGluayB0YWdzPyBZb3UgYXJl IG1ha2luZyBteSBhbmQgbWF5YmUgb3RoZXIgcGVvcGxlcwo+ID4+Pj4gbGlmZSB1bm5lY2Vzc2Fy eSBoYXJkLiA6LSgoCj4gPj4+Pgo+ID4+Pj4gRldJVywgdGhlIHByb3BlciBzdHlsZSBzaG91bGQg c3VwcG9ydCBmb290bm90ZSBzdHlsZSBsaWtlIHRoaXM6Cj4gPj4+Pgo+ID4+Pj4gTGluazoKPiA+ Pj4+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvYjY4N2MyNTktNjQxMy0yNmM5LWQ0YzktYjNh ZmE2OWVhMTI0QHBlbmd1dHJvbml4LmRlLwo+ID4+Pj4gIFsxXQo+ID4+Pj4KPiA+Pj4+IENpYW8s IFRob3JzdGVuCj4gPj4+Pgo+ID4+Pj4gI3JlZ3pib3QgXmJhY2ttb25pdG9yOgo+ID4+Pj4gaHR0 cHM6Ly9sb3JlLmtlcm5lbC5vcmcvci9iNjg3YzI1OS02NDEzLTI2YzktZDRjOS1iM2FmYTY5ZWEx MjRAcGVuZ3V0cm9uaXguZGUvCj4gPj4+PiAgCj4gPj4+Cj4gPj4+IEJlY2F1c2UgdG9kYXkncyBy ZXF1aXJlbWVudCBmcm9tIG1haW50YWluZXJzIGlzIHRvIHByb3ZpZGUgYSBMaW5rCj4gPj4+IHRh ZyB0aGF0IHBvaW50cyB0byB0aGUgbWFpbCBkaXNjdXNzaW9uIG9mIHRoZSBwYXRjaCBiZWluZyBh cHBsaWVkLiAgCj4gPj4KPiA+PiBUaGF0IGNhbiBiZSBhbiBhZGRpdGlvbmFsIExpbmsgdGFnLCB0 aGF0IGlzIGRvbmUgYWxsIHRoZSB0aW1lLgo+ID4+ICAKPiA+Pj4gSQo+ID4+PiB0aGVuIGFza2Vk IHRvIHVzZSB0aGUgYWJvdmUgZm9ybSBpbnN0ZWFkIHRvIHBvaW50IHRvIHRoZSBidWcgcmVwb3J0 Cj4gPj4+IGJlY2F1c2UgSSBkb24ndCBzZWUgdGhlIHBvaW50IG9mIGhhdmluZyBhICJMaW5rIiB0 YWcgZm9yIGl0PyAgCj4gPiAKPiA+IFBlcmhhcHMgSSBzaG91bGQgZW1waGFzaXplIHRoYXQgSSBk b24ndCByZW1lbWJlciB5b3VyIGluaXRpYWwgcmVxdWVzdAo+ID4gcmVnYXJkaW5nIHRoZSB1c2Ug b2YgYSBMaW5rIHRhZyAgCj4gCj4gSGFwcGVuLCBubyB3b3JyaWVzLgo+IAo+ID4gYW5kIG15IG9y aWdpbmFsIGlkZWEgd2FzIHRvIGhlbHAgdGhpcwo+ID4gY29udHJpYnV0b3IsIG5vdCBraWxsIHlv dXIgdG9vbHMgd2hpY2ggSSBhY3R1YWxseSBrbm93IHZlcnkgbGl0dGxlCj4gPiBhYm91dC4gIAo+ ID4+PiBCdXQgaXQncyBub3QgeW91ciBvd24gcHJvamVjdCwgd2UgYXJlIGFsbCB3b3JraW5nIHdp dGggdGhvdXNhbmRzIG9mICAKPiA+PiBwZW9wbGUgdG9nZXRoZXIgb24gdGhpcyBwcm9qZWN0IG9u IHZhcmlvdXMgZGlmZmVyZW50IGZyb250cy4gVGhhdCBuZWVkcwo+ID4+IGNvb3JkaW5hdGlvbiwg YXMgc29tZSB0aGluZ3Mgb3RoZXJ3aXNlIGJlY29tZSBoYXJkIG9yIGltcG9zc2libGUuIFRoYXQn cwo+ID4+IHdoeSB3ZSBoYXZlIGRvY3VtZW50YXRpb24gdGhhdCBleHBsYWlucyBob3cgdG8gZG8g c29tZSB0aGluZ3MuIE5vdAo+ID4+IGZvbGxvd2luZyBpdCBqdXN0IGJlY2F1c2UgeW91IGRvbid0 IGxpa2UgaXQgaXMgbm90IGhlbHBmdWwgYW5kIGluIHRoaXMKPiA+PiBjYXNlIG1ha2VzIG15IGxp ZmUgYXMgYSB2b2x1bnRlZXIgYSBsb3QgaGFyZGVyLiAgCj4gPiAKPiA+IExldCdzIGJlIGhvbmVz dCwgeW91IGFyZSByZWZlcnJpbmcgdG8gYSBEb2N1bWVudGF0aW9uIHBhdGNoIHRoYXQgKnlvdSoK PiA+IHdyb3RlICAKPiAKPiBDb3JyZWN0LCBidXQgaW4gY2FzZSBvZiBzdWJtaXR0aW5nLXBhdGNo ZXMgaXQgd2FzIGp1c3QgYSBjbGFyaWZpY2F0aW9uCj4gaG93IHRvIHBsYWNlIGxpbmtzOyB3aHkg dGhlIHdob2xlIGFzcGVjdCB3YXMgbWlzc2luZyBpbiB0aGUgb3RoZXIgaXMKPiBraW5kYSBvZGQg YW5kIGxpa2VseSBsb3N0IGluIGhpc3RvcnkuLi4KPiAKPiA+IGFuZCB3YXMgbWVyZ2VkIGludG8g TGludXMnIHRyZWUgbWlkIEphbnVhcnkuIEhvdyBvZnRlbiBkbyB5b3UKPiA+IHRoaW5rIHBlb3Bs ZSB1c2VkIHRvIHRoZSBjb250cmlidXRpb24gd29ya2Zsb3cgbW9uaXRvciB0aGVzZSBmaWxlcz8g IAo+IAo+IE5vdCBvZnRlbiwgdGhhdCdzIHdoeSBJIGhhdmUgbm8gcHJvYmxlbSBwb2ludGluZyBp dCBvdXQsIGV2ZW4gaWYgdGhhdCdzCj4gc2xpZ2h0bHkgYW5ub3lpbmcuIEJ1dCB5b3UgY2FuIGlt YWdpbmUgdGhhdCBpdCBmZWx0IGtpbmRhIG9kZCBvbiBteSBzaWRlCj4gd2hlbiBhc2tpbmcgc29t ZW9uZSB0byBzZXQgdGhlIGxpbmtzICh3aXRoIHJlZmVyZW5jZXMgdG8gdGhlIGRvY3MKPiBleHBs YWluaW5nIGhvdyB0byBzZXQgdGhlbSkgYW5kIHNlZWluZyB0aGVtIGFkZGVkIHRoZW4gaW4gdjIs IGp1c3Qgc28KPiBzZWUgdGhleSB2YW5pc2hlZCBhZ2FpbiBpbiB2MyBvZiB0aGUgc2FtZSBwYXRj aC4gOi0vCgpJIGZ1bGx5IHVuZGVyc3RhbmQuIEkgYWN0dWFsbHkgbGVhcm5lZCB0aGF0IHRoZXNl IHRhZ3MgaGFkIHRvIGJlIHVzZWQKZm9yIHRoaXMgcHVycG9zZSwgc28gSSB3aWxsIGFjdHVhbGx5 IGVuZm9yY2UgdGhlaXIgdXNlIGluIG15IG5leHQKcmV2aWV3cy4KCkp1c3QgYSBzaWRlIHF1ZXN0 aW9uLCBzaG91bGQgdGhlIERvY3VtZW50YXRpb24gYWxzbyBtZW50aW9uIGhvdwp0byByZWZlciB0 byBsaW5rcyBmb3IgcGVvcGxlIG5vdCB1c2VkIHRvIGl0PyBTb21ldGhpbmcgbGlrZQpbNS5Qb3N0 aW5nLnJzdF06CgoJIkxpbms6IDxsaW5rPiBbMV0KCSBMaW5rOiA8bGluaz4gWzJdIgoKTXkgb3Jp Z2luYWwgcG9pbnQgd2FzIHRoYXQgbWFpbnRhaW5lcnMgd291bGQgYWxtb3N0IGFsd2F5cyBhZGQK YSBMaW5rIHRhZyBhdCB0aGUgZW5kLCBjb250YWluaW5nIHRoZSBtYWlsaW5nLWxpc3QgdGhyZWFk IGFib3V0IHRoZQpwYXRjaCBiZWluZyBhcHBsaWVkLiBKdXN0IHNheWluZyBpbiB0aGUgY29tbWl0 IGxvZyAic2VlIHRoZSBsaW5rIGJlbG93Igp0aGVuIGJlY29tZXMgbWlzbGVhZGluZy4KCj4gPiBJ IGFtIHRvdGFsbHkgZmluZSBlbmZvcmNpbmcgdGhlIHVzZSBvZiBMaW5rOiB0YWdzIGlmIHRoaXMg aXMgd2hhdCBoYXMKPiA+IGJlZW4gZGVjaWRlZCwganVzdCBkb24ndCBleHBlY3QgZXZlcnlib2R5 IHRvIHN3aXRjaCB0byBhIHN0eWxlIHJhdGhlcgo+ID4gdGhhbiBhbm90aGVyIG92ZXIgYSBuaWdo dC4gIAo+IAo+IEkgZG9uJ3QuCj4gCj4gPj4gSWYgeW91IGRvbid0IGxpa2UgdGhlIGFwcHJvYWNo IGV4cGxhaW5lZCBieSB0aGUgZG9jdW1lbnRhdGlvbiwgc3VibWl0IGEKPiA+PiBwYXRjaCBhZGp1 c3RpbmcgdGhlIGRvY3VtZW50YXRpb24gYW5kIHRoZW4gd2UgY2FuIHRhbGsgYWJvdXQgdGhpcy4g QnV0Cj4gPj4gdW50aWwgdGhhdCBpcyBhcHBsaWVkIHBsZWFzZSBzdGljayB0byB0aGUgZm9ybWF0 IGV4cGxhaW5lZCBieSB0aGUKPiA+PiBkb2N1bWVudGF0aW9uLiAgCj4gPiBUaGlzIGlzIHVzZWxl c3NseSBjb25kZXNjZW5kaW5nLiAgCj4gCj4gSSBhcG9sb2dpemUsIGl0IHdhc24ndCBtZWFudCB0 aGF0IHdheS4KCk5vIHdvcnJpZXMsIHRoYW5rcyA6LSkKCj4gSSBoYWQgdG8gbWFueSBkaXNjdXNz aW9ucyBhbHJlYWR5Cj4gd2hlcmUgcGVvcGxlIHdlcmUgbm90IHNldHRpbmcgYW55IGxpbmtzIGFu ZCBpdCBzZWVtcyB0aGUgdG9waWMgaXMgc2xvd2x5Cj4gaGl0dGluZyBhIG5lcnZlIGhlcmUuIFNv cnJ5LgoKSSBhbHNvIGZlZWwgbGlrZSBJIGFtIHJlcGVhdGluZyBteXNlbGYgc29tZXRpbWVzLiBB bmQgdGhlbiBJIHJlbWVtYmVyClJvYiBhbmQgdGhlIHRvbiBvZiBlLW1haWxzIHdoZXJlIGhlIGhh cyB0byByZXBlYXQgaGltc2VsZiBodW5kcmVkcyBvZgp0aW1lcyBhIGRheSBhbmQgSSBmZWVsIHNs aWdodGx5IGJldHRlciA6LXAKCkNoZWVycywgTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1h aWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDBEC433F5 for ; Mon, 21 Mar 2022 14:56:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349766AbiCUO6A (ORCPT ); Mon, 21 Mar 2022 10:58:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349686AbiCUO5x (ORCPT ); Mon, 21 Mar 2022 10:57:53 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC6E7340EA for ; Mon, 21 Mar 2022 07:56:23 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 2473560003; Mon, 21 Mar 2022 14:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1647874581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JAo/x8R7rAbW3xDbvvHX3hFb31xZ9EbfQa3/rwY/KzY=; b=jj45yubSTsmuEFkrh/iP5XbVEA2Mew4nLlY7ITc4EtuLPueXWnPfsxWdRc9kOlUxTMGwZP EVusUHou97LymkpOCPmm3U3TpkETAlUJlbJ8RmzaQv4UeeaS8ooVvsN828zW0eKrUywWH/ K09lVSgwAwibsxETjOWAKoCrt4TCdUXJUKq5dUszlvgu9eu2jLANgfIsA4sfdvwceuT99X 1KIUyezsRPRdbBIAlqMfH1hWVnmDIjLkZaD3gYEIFoLRpuUh459gDs1/fzqbua52wFBt55 la/bejwmebBdYa+KReyCtrpacPRxMVtCqjNtwU2MlLtFopemRxaAOAudq1b0YA== Date: Mon, 21 Mar 2022 15:56:18 +0100 From: Miquel Raynal To: Thorsten Leemhuis Cc: Tokunori Ikegami , linux-mtd@lists.infradead.org, Ahmad Fatoum , stable@vger.kernel.org Subject: Re: [PATCH v4 2/3] mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N Message-ID: <20220321155618.7bfa214e@xps13> In-Reply-To: <3ed10e7e-1c73-6464-b1df-6c6e086fa162@leemhuis.info> References: <20220316155455.162362-1-ikegami.t@gmail.com> <20220316155455.162362-3-ikegami.t@gmail.com> <20220321133529.2d3addaf@xps13> <20220321144134.3076a2ba@xps13> <3ed10e7e-1c73-6464-b1df-6c6e086fa162@leemhuis.info> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Thorsten, regressions@leemhuis.info wrote on Mon, 21 Mar 2022 15:17:50 +0100: > On 21.03.22 14:41, Miquel Raynal wrote: > > regressions@leemhuis.info wrote on Mon, 21 Mar 2022 13:51:10 +0100: =20 > >> On 21.03.22 13:35, Miquel Raynal wrote: =20 > >>> regressions@leemhuis.info wrote on Mon, 21 Mar 2022 12:48:11 +0100: > >>> =20 > >>>> On 16.03.22 16:54, Tokunori Ikegami wrote: =20 > >>>>> As pointed out by this bug report [1], buffered writes are now brok= en on > >>>>> S29GL064N. This issue comes from a rework which switched from using= chip_good() > >>>>> to chip_ready(), because DQ true data 0xFF is read on S29GL064N and= an error > >>>>> returned by chip_good(). One way to solve the issue is to revert th= e change > >>>>> partially to use chip_ready for S29GL064N. > >>>>> > >>>>> [1] https://lore.kernel.org/r/b687c259-6413-26c9-d4c9-b3afa69ea124@= pengutronix.de/ =20 > >>>> > >>>> Why did you switch from the documented format for links you added on= my > >>>> request (see > >>>> https://lore.kernel.org/stable/f1b44e87-e457-7783-d46e-0d577cea3b72@= leemhuis.info/ > >>>> > >>>> ) to v2 to something else that is not recognized by tools and scripts > >>>> that rely on proper link tags? You are making my and maybe other peo= ples > >>>> life unnecessary hard. :-(( > >>>> > >>>> FWIW, the proper style should support footnote style like this: > >>>> > >>>> Link: > >>>> https://lore.kernel.org/r/b687c259-6413-26c9-d4c9-b3afa69ea124@pengu= tronix.de/ > >>>> [1] > >>>> > >>>> Ciao, Thorsten > >>>> > >>>> #regzbot ^backmonitor: > >>>> https://lore.kernel.org/r/b687c259-6413-26c9-d4c9-b3afa69ea124@pengu= tronix.de/ > >>>> =20 > >>> > >>> Because today's requirement from maintainers is to provide a Link > >>> tag that points to the mail discussion of the patch being applied. =20 > >> > >> That can be an additional Link tag, that is done all the time. > >> =20 > >>> I > >>> then asked to use the above form instead to point to the bug report > >>> because I don't see the point of having a "Link" tag for it? =20 > >=20 > > Perhaps I should emphasize that I don't remember your initial request > > regarding the use of a Link tag =20 >=20 > Happen, no worries. >=20 > > and my original idea was to help this > > contributor, not kill your tools which I actually know very little > > about. =20 > >>> But it's not your own project, we are all working with thousands of = =20 > >> people together on this project on various different fronts. That needs > >> coordination, as some things otherwise become hard or impossible. That= 's > >> why we have documentation that explains how to do some things. Not > >> following it just because you don't like it is not helpful and in this > >> case makes my life as a volunteer a lot harder. =20 > >=20 > > Let's be honest, you are referring to a Documentation patch that *you* > > wrote =20 >=20 > Correct, but in case of submitting-patches it was just a clarification > how to place links; why the whole aspect was missing in the other is > kinda odd and likely lost in history... >=20 > > and was merged into Linus' tree mid January. How often do you > > think people used to the contribution workflow monitor these files? =20 >=20 > Not often, that's why I have no problem pointing it out, even if that's > slightly annoying. But you can imagine that it felt kinda odd on my side > when asking someone to set the links (with references to the docs > explaining how to set them) and seeing them added then in v2, just so > see they vanished again in v3 of the same patch. :-/ I fully understand. I actually learned that these tags had to be used for this purpose, so I will actually enforce their use in my next reviews. Just a side question, should the Documentation also mention how to refer to links for people not used to it? Something like [5.Posting.rst]: "Link: [1] Link: [2]" My original point was that maintainers would almost always add a Link tag at the end, containing the mailing-list thread about the patch being applied. Just saying in the commit log "see the link below" then becomes misleading. > > I am totally fine enforcing the use of Link: tags if this is what has > > been decided, just don't expect everybody to switch to a style rather > > than another over a night. =20 >=20 > I don't. >=20 > >> If you don't like the approach explained by the documentation, submit a > >> patch adjusting the documentation and then we can talk about this. But > >> until that is applied please stick to the format explained by the > >> documentation. =20 > > This is uselessly condescending. =20 >=20 > I apologize, it wasn't meant that way. No worries, thanks :-) > I had to many discussions already > where people were not setting any links and it seems the topic is slowly > hitting a nerve here. Sorry. I also feel like I am repeating myself sometimes. And then I remember Rob and the ton of e-mails where he has to repeat himself hundreds of times a day and I feel slightly better :-p Cheers, Miqu=C3=A8l