Re: [PATCH 2/2] fstests: test dirty pipe vulnerability issue of CVE-2022-0847

[Dave Chinner <david@fromorbit.com>]

On Mon, Mar 21, 2022 at 07:03:41PM +0800, Zorro Lang wrote:
> diff --git a/tests/generic/999 b/tests/generic/999
> new file mode 100755
> index 00000000..2488e455
> --- /dev/null
> +++ b/tests/generic/999
> @@ -0,0 +1,54 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2022 Red Hat, Inc.  All Rights Reserved.
> +#
> +# FS QA Test No. 999
> +#
> +# Test for the Dirty Pipe vulnerability (CVE-2022-0847) caused by an
> +# uninitialized  "pipe_buffer.flags" variable, which fixed by:
> +#   9d2231c5d74e ("lib/iov_iter: initialize "flags" in new pipe_buffer")
> +#
> +. ./common/preamble
> +_begin_fstest auto quick
> +
> +_cleanup()
> +{
> +	cd /
> +	rm -f $tmp.*
> +	rm -f $TEST_DIR/testfile.$seq
> +}

Just leave the test file lying around so this can use the default
cleanup method. The test device is supposed to gather random
cruft as tests run....

> +
> +# real QA test starts here
> +_supported_fs generic
> +_require_test
> +_require_user
> +_require_chmod
> +_require_test_program "splice2pipe"
> +
> +localfile=$TEST_DIR/testfile.$seq

.... and remove the file here as part of test setup with:

rm -f $localfile

Otherwise looks fine.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com