From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAEC2C433EF for ; Tue, 22 Mar 2022 12:26:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E5964839C7; Tue, 22 Mar 2022 13:25:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="W8MLQUwq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2538E839C7; Tue, 22 Mar 2022 13:25:55 +0100 (CET) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0D1C78395F for ; Tue, 22 Mar 2022 13:25:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id a11so10320248qtb.12 for ; Tue, 22 Mar 2022 05:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h3YwEj+umDPbN9HZi3A1aRDLNUQwHyX1PvhipneFJw0=; b=W8MLQUwqD+8tfi7e4BD64lc/O2e8LuJDqgchjaYD9a9r8qeTGvLRcmaadj6gvOiXd6 aXwznCjiIVkhMSuhwWukvLKvbAA7Sj/yjGPTLIzNbsoPcLDYcbnFRfY0pGF9JyEgJisw 3h1sNqmNBZaviARHqsdP3teks+THjwp0ya410= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h3YwEj+umDPbN9HZi3A1aRDLNUQwHyX1PvhipneFJw0=; b=1dvmnXby922piK+FFAloQwXOyOw/YMZpX9p8D2FSk9jH8dLpLHvvxD/ilK+Oia9biA V3iTVmMkrWIQe70bCTbZ9A1mnqqR7JNXEiJNgVfQ/Rgxb7wS40IZNCAgSWkOw5ZcIKeh oIAV6yWviyaz6ohLraWcGDzwW7wvCShcT2RiBzL1GxQ/pnJtEfQiKwj+2RQeRAaATodI rwGqsuMfTnnGTvpOfXo2rvzr4dyM+2/6BzRdfGYp9Ps7BS5JtZDmYA+QmPEclY0LXIMv opfBQkrh8u/x2hRE5lBDTmyz84WNizJmrIgrYMquuGctReDn3Ho7PV08Id8f5tX4cyap 01kQ== X-Gm-Message-State: AOAM532SQqEHqr2DGZVx9scU9Pmfw22jRjLi0wHKBx5+5W+y23KJzF+l ZsLaU45CDxvzeBV7RIMiuj8thw== X-Google-Smtp-Source: ABdhPJwcLVkeBdZc4b/RAVsezpVxEn7IFgAk6r4z2/i6MW9EQVB6gyMPbwCPFIG2SwxOWH8dlHqt1g== X-Received: by 2002:ac8:7d50:0:b0:2e1:c3a2:74da with SMTP id h16-20020ac87d50000000b002e1c3a274damr19410156qtb.318.1647951949696; Tue, 22 Mar 2022 05:25:49 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id bm21-20020a05620a199500b0067d5e6c7bd8sm8870921qkb.56.2022.03.22.05.25.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 05:25:48 -0700 (PDT) Date: Tue, 22 Mar 2022 08:25:46 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Heiko Thiery , Simon Glass , Stefano Babic , Fabio Estevam , Peng Fan , u-boot@lists.denx.de Subject: Re: [PATCH v2] board: kontron: increase the CONFIG_SYS_MALLOC_F_LEN Message-ID: <20220322122546.GW2226424@bill-the-cat> References: <20220321142631.63704-1-heiko.thiery@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AyMxp50UHmBw7FcH" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --AyMxp50UHmBw7FcH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 22, 2022 at 10:25:12AM +0100, Heinrich Schuchardt wrote: > On 3/21/22 15:26, Heiko Thiery wrote: > > It was observed that enabling additional DM modules the configured > > malloc value is not sufficient. So lets increase the value. > >=20 > > Signed-off-by: Heiko Thiery > > --- > > v2: > > - add a more proper commit message to explan why the value was increa= sed > >=20 > > configs/kontron_pitx_imx8m_defconfig | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/configs/kontron_pitx_imx8m_defconfig b/configs/kontron_pit= x_imx8m_defconfig > > index 76430213e3..30c3586937 100644 > > --- a/configs/kontron_pitx_imx8m_defconfig > > +++ b/configs/kontron_pitx_imx8m_defconfig > > @@ -2,6 +2,7 @@ CONFIG_ARM=3Dy > > CONFIG_ARCH_IMX8M=3Dy > > CONFIG_SYS_TEXT_BASE=3D0x40200000 > > CONFIG_SYS_MALLOC_LEN=3D0x600000 > > +CONFIG_SYS_MALLOC_F_LEN=3D0x10000 >=20 > @Heiko > Should we really adjust this on board level? Won't we have the same > problem on all imx8m boards? >=20 > Why don't you change the default for all i.mx8 boards in /Kconfig? >=20 > @Tom, @Simon > Shouldn't we replace the default of 0x400 by 0x2000 generally? That's well more than the default for imx8 of 0x2000 and even for the default for sandbox of 0x4000, does it need to be that huge? Or was that the "I'm sick of this problem" value? --=20 Tom --AyMxp50UHmBw7FcH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmI5wEAACgkQFHw5/5Y0 tyzebAv/ZIIPQSYTZhBZB6Eo1+hRseXQ1elpFMiah+qVRY2rDmRokVj3gOZZB9XQ OByO953o1zP9CnAYEBroyQyDqsoJ3BVZZGIs1cBBo2wQqIampfjBPzTtIaCyzDu0 rbU74T3AVbVzsOTUqIaWJGDKSq7lnS828NQrqZ8ZyxetyqKksrEvOMKD4e7QffMR QSxn2q60g1HuF5rW0d43F7oEQ1Svdm55650WgUVk4wuXQDh+3WsKdgBUXo4W+zCQ OVTarzleHxdH++REWxMVwlYGpUOx66Bfxfczv2otFk8jx8llVKcDrcRMfTlmKpi7 XtjlB1prfWmpt6LyObhvHBaS+jPxA10k2Vu2EAEgTMU3V6w7f82/Ex21WJQX3V8R s2FHD9khf0GTTkY9FpItKsqNSOcVp9wKfcyYzGo8FuqeNR8rI0+vQm5f+Ab54f7L RbgvpI9OWm+jiIMYmu++qP06YDu9Qu1uZ1//WUNyEFWTtWEFxJ0U5+IijVVxH1If psrmbF+m =VypD -----END PGP SIGNATURE----- --AyMxp50UHmBw7FcH--