Re: [meta-ti][dunfell][PATCH 06/11] recipes-bsp: lpm-demo: Introduce low power mode demo package

[Denys Dmytriyenko <denis@denix.org>]

On Tue, Mar 22, 2022 at 11:25:23AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> From: Nikhil Devshatwar <nikhil.nd@ti.com>
> 
> On am62xx-evm, for low power validation, the system boot using
> an initramfs.
> 
> Package the tisdk-tiny-image.cpio file in the /boot of the
> default filesystem to enable the demo.
> 
> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> ---
>  recipes-bsp/lpm-demo/files/GPL-2     | 340 +++++++++++++++++++++++++++
>  recipes-bsp/lpm-demo/lpm-demo_1.0.bb |  28 +++
>  2 files changed, 368 insertions(+)
>  create mode 100644 recipes-bsp/lpm-demo/files/GPL-2
>  create mode 100644 recipes-bsp/lpm-demo/lpm-demo_1.0.bb
> 
> diff --git a/recipes-bsp/lpm-demo/files/GPL-2 b/recipes-bsp/lpm-demo/files/GPL-2
> new file mode 100644
> index 00000000..d60c31a9
> --- /dev/null
> +++ b/recipes-bsp/lpm-demo/files/GPL-2

<snip>

> diff --git a/recipes-bsp/lpm-demo/lpm-demo_1.0.bb b/recipes-bsp/lpm-demo/lpm-demo_1.0.bb
> new file mode 100644
> index 00000000..56b04d56
> --- /dev/null
> +++ b/recipes-bsp/lpm-demo/lpm-demo_1.0.bb
> @@ -0,0 +1,28 @@
> +SUMMARY = "Low power mode demo"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://GPL-2;md5=94d55d512a9ba36caa9b7df079bae19f"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +COMPATIBLE_MACHINE = "am62xx-evm"
> +
> +FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
> +S = "${WORKDIR}"
> +
> +# We need to have the license file from some source. In this case, there
> +# is no source. Hence pointing to the license file only
> +SRC_URI = "file://GPL-2"

That's an incorrect way of doing it.
https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/busybox/busybox-inittab_1.35.0.bb#n3

Also, default license for OpenEmbedded metadata is MIT, not GPLv2. Any 
specific reason for the change?
https://git.yoctoproject.org/meta-arago/tree/meta-arago-distro/recipes-tisdk/tisdk-readme/tisdk-readme.bb#n3


> +LPM_RAMFS_IMAGE ?= "tisdk-tiny-image"
> +
> +do_install() {
> +	install -d ${D}/boot
> +	if [ -f ${DEPLOY_DIR_IMAGE}/${LPM_RAMFS_IMAGE}-${MACHINE}.cpio ]; then
> +		install -m 0644 ${DEPLOY_DIR_IMAGE}/${LPM_RAMFS_IMAGE}-${MACHINE}.cpio ${D}/boot
> +	else
> +		bberror "Could not find LPM ramfs image (${LPM_RAMFS_IMAGE}-${MACHINE}.cpio) in deploy dir!"
> +	fi
> +}
> +
> +do_install[depends] = "${LPM_RAMFS_IMAGE}:do_image_complete"
> +
> +FILES_${PN} = "/boot"
> -- 
> 2.17.1
> 

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964