From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 242DEC433F5 for ; Tue, 22 Mar 2022 18:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D510fwss09HJV6/yFD+cMg6dQWO56GIMG6QLzCQfYSs=; b=oPckI0sxa1YkLC eSOX90mn8BTxrbangT/aQ8+d3u17pu1ljrYQJLfKfVtDt0/yzWc0mT25miTEp0PgHULEGjfgi+nCP 4o7JA6FtqUp9TtglExqdvyyy48ogR7oK1rkm+Ne6AsF8JxaoTT2jG1JMcugO8A0V7wysiJeao+NcU lBQ/ORYbvHQ+nRBnTQjPQ221xXS3tNLqYmJn0pNqzHLH0c9rUeoyA0iJG1zJS//k0CryKVkO4tYa5 mQVMMT3tXr1fqFwwOgxgN8FxHOFSL/tsGepzdRj+n4Dq+tJOPNZIE1Kt9kBwGeIjFbW6r+QlZj89z Gf3sk8YtTJRDK07dG1rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWjXv-00BvNk-Av; Tue, 22 Mar 2022 18:47:55 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWjXr-00BvNA-Rm for linux-arm-kernel@lists.infradead.org; Tue, 22 Mar 2022 18:47:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 509DEB81D4D; Tue, 22 Mar 2022 18:47:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6132C340F2; Tue, 22 Mar 2022 18:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647974868; bh=AcegB2MSlk0Godl3h3BGMTVyZS57blUmDblLAtl/clg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LlaF4DNAzwPr0LgXTNCSLJOEE0JPp1SozzqeK4vUuXOJOg5uqje3Lc+PlIzS173is bTp+UV9jOj3Tnarge3xhS2TGGXLBJJ3upx2YWsIeUwAYc28y+8SkU3KxdD+cwleqRi QLAo/tmP4gyNJHDljUSYzn+Xr5aEZAfLbisxVf4F8ClZTQ1mZVbmgfi/wu2cpYYnCn 6DlHV3dwBd4mLvSA9d3XM1pH1caj1/1+Q8gKdJqvZ1fom5jpUshJuJSYbjSwvJIO05 2vE/Tjya1rp/Hw5g0GesY5kDdeccU4SuIXTj1YvzJJbGw5fq91uAPY8aquetlqpSsJ T+6LTDq1vS5/g== Received: by pali.im (Postfix) id 56C07843; Tue, 22 Mar 2022 19:47:44 +0100 (CET) Date: Tue, 22 Mar 2022 19:47:44 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Robert Marko Cc: andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marek.behun@nic.cz Subject: Re: [PATCH v2 1/2] arm64: dts: uDPU: update partition table Message-ID: <20220322184744.pbiv3puccs2wb3lu@pali> References: <20220322105857.1107016-1-robert.marko@sartura.hr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220322105857.1107016-1-robert.marko@sartura.hr> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220322_114752_089602_B027733E X-CRM114-Status: GOOD ( 25.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlc2RheSAyMiBNYXJjaCAyMDIyIDExOjU4OjU2IFJvYmVydCBNYXJrbyB3cm90ZToKPiBQ YXJ0aXRpb24gY3VycmVudGx5IGNhbGxlZCAidWJvb3QiIGRvZXMgbm90IG9ubHkgY29udGFpbiBV LWJvb3QsIGJ1dAo+IHJhdGhlciBpdCBjb250YWlucyBURi1BLCBVLWJvb3QgYW5kIFUtYm9vdCBl bnZpcm9ubWVudC4KPiAKPiBTbywgdG8gYXZvaWQgYWNjaWRlbnRhbGx5IGRlbGV0aW5nIHRoZSBV LWJvb3QgZW52aXJvbm1lbnQgd2hpY2ggaXMKPiBsb2NhdGVkIGF0IDB4MTgwMDAwIHNwbGl0IHRo ZSBwYXJ0aXRpb24uCj4gCj4gInVib290IiBpcyBub3QgdGhlIGNvcnJlY3QgbmFtZSBhcyB5b3Ug Y2FuJ3QgYm9vdCB0aGVzZSBib2FyZHMgd2l0aCBVLWJvb3QKPiBvbmx5LCBURi1BIG11c3QgYmUg cHJlc2VudCBhcyB3ZWxsLCBzbyByZW5hbWUgdGhlICJ1Ym9vdCIgcGFydGl0aW9uIHRvCj4gImZp cm13YXJlIi4KPiAKPiBXaGlsZSB3ZSBhcmUgaGVyZSwgZGVzY3JpYmUgdGhlIE5PUiBub2RlIGFz ICJzcGktZmxhc2hAMCIgaW5zdGVhZCBvZgo+ICJtMjVwODBAMCIgd2hpY2ggaXMgdGhlIG9sZCBT UEktTk9SIGRyaXZlciBuYW1lLgo+IAo+IFRoaXMgd29uJ3QgYnJlYWsgYm9vdGluZyBmb3IgZXhp c3RpbmcgZGV2aWNlcyBhcyB0aGUgU29DLXMgQm9vdFJPTSBpcyBub3QKPiBwYXJ0aXRpb24gYXdh cmUgYXQgYWxsLCBpdCB3aWxsIHNpbXBseSB0cnkgYm9vdGluZyBmcm9tIDB4MCBvZiB0aGUKPiBi b290IGRldmljZSB0aGF0IGlzIHNldCBieSBib290c3RyYXAgcGlucy4KPiAKPiBUaGlzIHdpbGwg aG93ZXZlciBwcmV2ZW50IGFjY2lkZW50YWwgb3IgYXV0b21hdGVkIGZsYXNoaW5nIG9mIGp1c3Qg VS1ib290Cj4gdG8gdGhlIHBhcnRpdGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBSb2JlcnQgTWFy a28gPHJvYmVydC5tYXJrb0BzYXJ0dXJhLmhyPgoKUmV2aWV3ZWQtYnk6IFBhbGkgUm9ow6FyIDxw YWxpQGtlcm5lbC5vcmc+Cgo+IC0tLQo+IENoYW5nZXMgaW4gdjI6Cj4gKiBVcGRhdGUgdGhlIGNv bW1pdCBkZXNjcmlwdGlvbiBieSBhZHJlc3NpbmcgQUJJIGJyZWFraW5nIGNvbmNlcm5zCj4gLS0t Cj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvbWFydmVsbC9hcm1hZGEtMzcyMC11RFBVLmR0cyB8IDEz ICsrKysrKysrKy0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNCBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2Fy bWFkYS0zNzIwLXVEUFUuZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0z NzIwLXVEUFUuZHRzCj4gaW5kZXggOTVkNDZlOGQwODFjLi5hYzY0OTQ5YmI1M2UgMTAwNjQ0Cj4g LS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXVEUFUuZHRzCj4g KysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS0zNzIwLXVEUFUuZHRzCj4g QEAgLTk5LDcgKzk5LDcgQEAgJnNwaTAgewo+ICAJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsK PiAgCXBpbmN0cmwtMCA9IDwmc3BpX3F1YWRfcGlucz47Cj4gIAo+IC0JbTI1cDgwQDAgewo+ICsJ c3BpLWZsYXNoQDAgewo+ICAJCWNvbXBhdGlibGUgPSAiamVkZWMsc3BpLW5vciI7Cj4gIAkJcmVn ID0gPDA+Owo+ICAJCXNwaS1tYXgtZnJlcXVlbmN5ID0gPDU0MDAwMDAwPjsKPiBAQCAtMTA4LDEw ICsxMDgsMTUgQEAgcGFydGl0aW9ucyB7Cj4gIAkJCWNvbXBhdGlibGUgPSAiZml4ZWQtcGFydGl0 aW9ucyI7Cj4gIAkJCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ICAJCQkjc2l6ZS1jZWxscyA9IDwx PjsKPiAtCQkJLyogb25seSBib290bG9hZGVyIGlzIGxvY2F0ZWQgb24gdGhlIFNQSSAqLwo+ICsK PiAgCQkJcGFydGl0aW9uQDAgewo+IC0JCQkJbGFiZWwgPSAidWJvb3QiOwo+IC0JCQkJcmVnID0g PDAgMHg0MDAwMDA+Owo+ICsJCQkJbGFiZWwgPSAiZmlybXdhcmUiOwo+ICsJCQkJcmVnID0gPDB4 MCAweDE4MDAwMD47Cj4gKwkJCX07Cj4gKwo+ICsJCQlwYXJ0aXRpb25AMTgwMDAwIHsKPiArCQkJ CWxhYmVsID0gInUtYm9vdC1lbnYiOwo+ICsJCQkJcmVnID0gPDB4MTgwMDAwIDB4MTAwMDA+Owo+ ICAJCQl9Owo+ICAJCX07Cj4gIAl9Owo+IC0tIAo+IDIuMzUuMQo+IAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5656C433F5 for ; Tue, 22 Mar 2022 18:47:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbiCVStT (ORCPT ); Tue, 22 Mar 2022 14:49:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbiCVStS (ORCPT ); Tue, 22 Mar 2022 14:49:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8C4B8F997; Tue, 22 Mar 2022 11:47:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 765E7B81D56; Tue, 22 Mar 2022 18:47:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6132C340F2; Tue, 22 Mar 2022 18:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647974868; bh=AcegB2MSlk0Godl3h3BGMTVyZS57blUmDblLAtl/clg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LlaF4DNAzwPr0LgXTNCSLJOEE0JPp1SozzqeK4vUuXOJOg5uqje3Lc+PlIzS173is bTp+UV9jOj3Tnarge3xhS2TGGXLBJJ3upx2YWsIeUwAYc28y+8SkU3KxdD+cwleqRi QLAo/tmP4gyNJHDljUSYzn+Xr5aEZAfLbisxVf4F8ClZTQ1mZVbmgfi/wu2cpYYnCn 6DlHV3dwBd4mLvSA9d3XM1pH1caj1/1+Q8gKdJqvZ1fom5jpUshJuJSYbjSwvJIO05 2vE/Tjya1rp/Hw5g0GesY5kDdeccU4SuIXTj1YvzJJbGw5fq91uAPY8aquetlqpSsJ T+6LTDq1vS5/g== Received: by pali.im (Postfix) id 56C07843; Tue, 22 Mar 2022 19:47:44 +0100 (CET) Date: Tue, 22 Mar 2022 19:47:44 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Robert Marko Cc: andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marek.behun@nic.cz Subject: Re: [PATCH v2 1/2] arm64: dts: uDPU: update partition table Message-ID: <20220322184744.pbiv3puccs2wb3lu@pali> References: <20220322105857.1107016-1-robert.marko@sartura.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220322105857.1107016-1-robert.marko@sartura.hr> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tuesday 22 March 2022 11:58:56 Robert Marko wrote: > Partition currently called "uboot" does not only contain U-boot, but > rather it contains TF-A, U-boot and U-boot environment. > > So, to avoid accidentally deleting the U-boot environment which is > located at 0x180000 split the partition. > > "uboot" is not the correct name as you can't boot these boards with U-boot > only, TF-A must be present as well, so rename the "uboot" partition to > "firmware". > > While we are here, describe the NOR node as "spi-flash@0" instead of > "m25p80@0" which is the old SPI-NOR driver name. > > This won't break booting for existing devices as the SoC-s BootROM is not > partition aware at all, it will simply try booting from 0x0 of the > boot device that is set by bootstrap pins. > > This will however prevent accidental or automated flashing of just U-boot > to the partition. > > Signed-off-by: Robert Marko Reviewed-by: Pali Rohár > --- > Changes in v2: > * Update the commit description by adressing ABI breaking concerns > --- > arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts > index 95d46e8d081c..ac64949bb53e 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts > @@ -99,7 +99,7 @@ &spi0 { > pinctrl-names = "default"; > pinctrl-0 = <&spi_quad_pins>; > > - m25p80@0 { > + spi-flash@0 { > compatible = "jedec,spi-nor"; > reg = <0>; > spi-max-frequency = <54000000>; > @@ -108,10 +108,15 @@ partitions { > compatible = "fixed-partitions"; > #address-cells = <1>; > #size-cells = <1>; > - /* only bootloader is located on the SPI */ > + > partition@0 { > - label = "uboot"; > - reg = <0 0x400000>; > + label = "firmware"; > + reg = <0x0 0x180000>; > + }; > + > + partition@180000 { > + label = "u-boot-env"; > + reg = <0x180000 0x10000>; > }; > }; > }; > -- > 2.35.1 >