Re: [PATCH mptcp-next] mptcp: add pm_nl_get_pernet helper

[Florian Westphal <fw@strlen.de>]

Geliang Tang <geliang.tang@suse.com> wrote:
> This patch added a new helper pm_nl_get_pernet(). Ues it instead of
> using pm_nl_pernet_id directly.

If you're already touching this, then ...

> +static struct pm_nl_pernet *pm_nl_get_pernet(const struct net *net)
> +{
> +	return net_generic(net, pm_nl_pernet_id);
> +}
> +

It would make sense to add a second helper that returns pm_nl_pernet
struct given 'struct mptcp_sock *'.

>  static bool addresses_equal(const struct mptcp_addr_info *a,
>  			    const struct mptcp_addr_info *b, bool use_port)
>  {
> @@ -208,7 +213,7 @@ unsigned int mptcp_pm_get_add_addr_signal_max(const struct mptcp_sock *msk)
>  {
>  	const struct pm_nl_pernet *pernet;
>  
> -	pernet = net_generic(sock_net((const struct sock *)msk), pm_nl_pernet_id);
> +	pernet = pm_nl_get_pernet(sock_net((const struct sock *)msk));

This would avoid all these cast.

Something like

> +	pernet = pm_nl_get_pernet_from_msk(msk);

... or similar.