From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07EBAC433F5 for ; Wed, 23 Mar 2022 13:14:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4179B83B29; Wed, 23 Mar 2022 14:14:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qnaMpSB4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 14EA082133; Wed, 23 Mar 2022 14:14:48 +0100 (CET) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7568B82133 for ; Wed, 23 Mar 2022 14:14:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2e.google.com with SMTP id hu11so1135808qvb.7 for ; Wed, 23 Mar 2022 06:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=58b/gRdekJmgS8pkxzmTbiKug4cyb+VS9Bb8c4AHRhM=; b=qnaMpSB4TNP/zTDOxLWKxfOs/2Nk8lLU5JHt5UyhXJ2BpQZJvcMQctyZGlZlo3SxZe mjCyKs+QzRgVjAbVzgCNu/X33OwlVl7QHCy4Y9SzxCknfgu24iOICN2wQ3jVgTjCPUWb vBEzPA/oYMSstO1Ww8vLAFUccmar7uGrT7xQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=58b/gRdekJmgS8pkxzmTbiKug4cyb+VS9Bb8c4AHRhM=; b=nN5YCPBA+XErXOU/3YSx4gl2x9NZUVGqEwqcVxebV86FYr/rWjDHE6cli/6/gVRpEL uKCW5f/u9Mbt+FU2l1VXLBMODCZjYbPjyZYdq+kjs/XYWqMsaGzk48zhAjuyvj8gHrSS E63arIcAqSco9hyLLr/PrEZUpmv12MO96Tuyycq7ssRqwplE1JVfwquUlKXKu8fBjlAU SKyst3IzAREEaCrR8SBZv+6y6WmpYsZoPcIxSHk8ABPioV+t8Wki8Vnc3NrOuuNErtEd 0IIhjDbTN7xWOTsa42yY2qPp341h55/+ZRhoBN2n2XfGg0ZHaBikq6vzV3Ccyb2sawoz C+XQ== X-Gm-Message-State: AOAM531LgcgqIxMmc+qpuQH0F0LyeeyM/b0RLNK4MRP3VXiWsSO7qZAZ XuM5yv9smYcP1WpwB3M9iztPHw== X-Google-Smtp-Source: ABdhPJzFR4iuS3ZY9k9FqaTy4Njt81+wKCD1KR5DXd1fOba53fJJjNbXgmqI/DGVgFc//OoLsrrJbA== X-Received: by 2002:a05:6214:4112:b0:441:720:8434 with SMTP id kc18-20020a056214411200b0044107208434mr17283566qvb.23.1648041282093; Wed, 23 Mar 2022 06:14:42 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id d82-20020a376855000000b0067dacb03b6esm10735725qkc.130.2022.03.23.06.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 06:14:41 -0700 (PDT) Date: Wed, 23 Mar 2022 09:14:39 -0400 From: Tom Rini To: Heiko Thiery Cc: Heinrich Schuchardt , Simon Glass , Stefano Babic , Fabio Estevam , Peng Fan , u-boot@lists.denx.de Subject: Re: [PATCH v2] board: kontron: increase the CONFIG_SYS_MALLOC_F_LEN Message-ID: <20220323131439.GA2226424@bill-the-cat> References: <20220321142631.63704-1-heiko.thiery@gmail.com> <20220322122546.GW2226424@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="a8kRBn33jkh2Wtq5" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --a8kRBn33jkh2Wtq5 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 22, 2022 at 01:34:34PM +0100, Heiko Thiery wrote: > Hi Tom, >=20 >=20 > Am Di., 22. M=E4rz 2022 um 13:25 Uhr schrieb Tom Rini : > > > > On Tue, Mar 22, 2022 at 10:25:12AM +0100, Heinrich Schuchardt wrote: > > > On 3/21/22 15:26, Heiko Thiery wrote: > > > > It was observed that enabling additional DM modules the configured > > > > malloc value is not sufficient. So lets increase the value. > > > > > > > > Signed-off-by: Heiko Thiery > > > > --- > > > > v2: > > > > - add a more proper commit message to explan why the value was in= creased > > > > > > > > configs/kontron_pitx_imx8m_defconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/configs/kontron_pitx_imx8m_defconfig b/configs/kontron= _pitx_imx8m_defconfig > > > > index 76430213e3..30c3586937 100644 > > > > --- a/configs/kontron_pitx_imx8m_defconfig > > > > +++ b/configs/kontron_pitx_imx8m_defconfig > > > > @@ -2,6 +2,7 @@ CONFIG_ARM=3Dy > > > > CONFIG_ARCH_IMX8M=3Dy > > > > CONFIG_SYS_TEXT_BASE=3D0x40200000 > > > > CONFIG_SYS_MALLOC_LEN=3D0x600000 > > > > +CONFIG_SYS_MALLOC_F_LEN=3D0x10000 > > > > > > @Heiko > > > Should we really adjust this on board level? Won't we have the same > > > problem on all imx8m boards? > > > > > > Why don't you change the default for all i.mx8 boards in /Kconfig? > > > > > > @Tom, @Simon > > > Shouldn't we replace the default of 0x400 by 0x2000 generally? > > > > That's well more than the default for imx8 of 0x2000 and even for the > > default for sandbox of 0x4000, does it need to be that huge? Or was > > that the "I'm sick of this problem" value? > > >=20 > I did test a pending patch that enables a DM clock driver for the > imx8mq. With that patch a huge amount of memory seems to be needed for > all that clock infrastructure. OK, then we should adjust upwards the default for imx8 in the toplevel Kconfig. --=20 Tom --a8kRBn33jkh2Wtq5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmI7HT8ACgkQFHw5/5Y0 tyxh7gwAhqUanz9RybG73eJ42U2/Pt1m79CXJe9qefcET9RMJUiMhRyCXcL8aRin CHujPgGwbC/a2gNQ2NB8S+/RkyEPwOi7sTk3IWBA0zdJqJ8T98o34jm8KZb7doQ0 /t8HKw+L/dA4BOvMKF5SEQTcNmzlWjpOsZ8KMIcN0UMsLlbbDFkDaKfTB+Dcgij1 HVMgMmG7P43MC8k+VibHbT0qbinvyzQJm9TlSL6x7HRviLpExqM8vMBLqZ+oQwBs KSBJEZRbTi+c+sJu6F6c5Dqmy3E26hXq0AVzoTSFH6iFGmHQibYGPU1fBZBtTPGK ehS30LwMDAC8qq8wn75XSgV6z+R6E+is3RPUPyEOaDz4CvcN08zccJfFb1yh2Fmu FWVymnvLVyXmwbZX8eCZN5GTYyBFM77pPP+ZgPqQgPjnpHO+1IEY4aF8DNbi9gEa CtyaCoilrVYaFTwMmfKLIMotz5aCpeIojqhfMkIthETPPJ82MzolDmweGxFp05// BVZhcX8Q =ub5E -----END PGP SIGNATURE----- --a8kRBn33jkh2Wtq5--