From: Florian Westphal <fw@strlen.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Florian Westphal <fw@strlen.de>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next 4/4] mptcp: let mptcp listen dump show listen backlog size
Date: Thu, 24 Mar 2022 18:35:40 +0100 [thread overview]
Message-ID: <20220324173540.GB30280@breakpoint.cc> (raw)
In-Reply-To: <69492012a2c7630ff3b5c036992fbc497de2906a.camel@redhat.com>
Paolo Abeni <pabeni@redhat.com> wrote:
> > - r->idiag_rqueue = sk_rmem_alloc_get(sk);
> > - r->idiag_wqueue = sk_wmem_alloc_get(sk);
> > + if (inet_sk_state_load(sk) == TCP_LISTEN) {
> > + r->idiag_rqueue = READ_ONCE(sk->sk_ack_backlog);
> > + r->idiag_wqueue = READ_ONCE(sk->sk_max_ack_backlog);
>
> What about accessing msk->first->sk*ack_backlog instead ? Are there any
> possible subtle races? Otherwise sk_ack_backlog will always be 0,
> right?
Yes, msk->first would be better here, will drop this patch
and merge the msk->first bit into preceeding one.
prev parent reply other threads:[~2022-03-24 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 13:57 [PATCH mptcp-next 0/4] mptcp: listen dump support Florian Westphal
2022-03-24 13:57 ` [PATCH mptcp-next 1/4] mptcp: diag: switch to context structure Florian Westphal
2022-03-24 13:57 ` [PATCH mptcp-next 2/4] mptcp: remove locking in mptcp_diag_fill_info Florian Westphal
2022-03-24 13:57 ` [PATCH mptcp-next 3/4] mptcp: listen diag dump support Florian Westphal
2022-03-24 16:52 ` Paolo Abeni
2022-03-24 17:07 ` Florian Westphal
2022-03-24 13:57 ` [PATCH mptcp-next 4/4] mptcp: let mptcp listen dump show listen backlog size Florian Westphal
2022-03-24 16:45 ` Paolo Abeni
2022-03-24 17:35 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324173540.GB30280@breakpoint.cc \
--to=fw@strlen.de \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.