From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E13F2C433EF for ; Fri, 25 Mar 2022 05:35:45 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-604-8r-o1WVWOiCkZvZ9mpWH1w-1; Fri, 25 Mar 2022 01:35:41 -0400 X-MC-Unique: 8r-o1WVWOiCkZvZ9mpWH1w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E640295470E; Fri, 25 Mar 2022 05:35:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 62680401E91; Fri, 25 Mar 2022 05:35:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 62525194034B; Fri, 25 Mar 2022 05:35:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 04F521940341 for ; Fri, 25 Mar 2022 05:35:25 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id C03424010E5D; Fri, 25 Mar 2022 05:35:24 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC7D1400F8FD for ; Fri, 25 Mar 2022 05:35:24 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 06D02803D65 for ; Fri, 25 Mar 2022 05:35:19 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-458-YqENVRTZN9CvaFMmigLJpg-1; Fri, 25 Mar 2022 01:35:14 -0400 X-MC-Unique: YqENVRTZN9CvaFMmigLJpg-1 Received: by verein.lst.de (Postfix, from userid 2407) id 6795168B05; Fri, 25 Mar 2022 06:35:10 +0100 (CET) Date: Fri, 25 Mar 2022 06:35:10 +0100 From: Christoph Hellwig To: Mike Snitzer Message-ID: <20220325053510.GA5327@lst.de> References: <20220324203526.62306-1-snitzer@kernel.org> <20220324203526.62306-3-snitzer@kernel.org> MIME-Version: 1.0 In-Reply-To: <20220324203526.62306-3-snitzer@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Subject: Re: [dm-devel] [PATCH v3 2/3] block: allow use of per-cpu bio alloc cache by block drivers X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-block@vger.kernel.org, dm-devel@redhat.com, hch@lst.de, ming.lei@redhat.com Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Mar 24, 2022 at 04:35:25PM -0400, Mike Snitzer wrote: > Refine per-cpu bio alloc cache interfaces so that DM and other block > drivers can properly create and use the cache: > > DM uses bioset_init_from_src() to do its final bioset initialization, > so must update bioset_init_from_src() to set BIOSET_PERCPU_CACHE if > %src bioset has a cache. > > Also move bio_clear_polled() to include/linux/bio.h to allow users > outside of block core. > > Signed-off-by: Mike Snitzer Looks good: Reviewed-by: Christoph Hellwig -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE06C433EF for ; Fri, 25 Mar 2022 05:35:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242657AbiCYFgs (ORCPT ); Fri, 25 Mar 2022 01:36:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238750AbiCYFgr (ORCPT ); Fri, 25 Mar 2022 01:36:47 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBF06C55AF for ; Thu, 24 Mar 2022 22:35:13 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 6795168B05; Fri, 25 Mar 2022 06:35:10 +0100 (CET) Date: Fri, 25 Mar 2022 06:35:10 +0100 From: Christoph Hellwig To: Mike Snitzer Cc: axboe@kernel.dk, ming.lei@redhat.com, hch@lst.de, dm-devel@redhat.com, linux-block@vger.kernel.org Subject: Re: [PATCH v3 2/3] block: allow use of per-cpu bio alloc cache by block drivers Message-ID: <20220325053510.GA5327@lst.de> References: <20220324203526.62306-1-snitzer@kernel.org> <20220324203526.62306-3-snitzer@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324203526.62306-3-snitzer@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Mar 24, 2022 at 04:35:25PM -0400, Mike Snitzer wrote: > Refine per-cpu bio alloc cache interfaces so that DM and other block > drivers can properly create and use the cache: > > DM uses bioset_init_from_src() to do its final bioset initialization, > so must update bioset_init_from_src() to set BIOSET_PERCPU_CACHE if > %src bioset has a cache. > > Also move bio_clear_polled() to include/linux/bio.h to allow users > outside of block core. > > Signed-off-by: Mike Snitzer Looks good: Reviewed-by: Christoph Hellwig