All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, Roman Gushchin <guro@fb.com>,
	Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: mm/slub.c:2142:15: warning: variable 'partial_slabs' set but not used
Date: Fri, 25 Mar 2022 05:19:04 +0800	[thread overview]
Message-ID: <202203250552.DbRtnNEv-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ed4643521e6af8ab8ed1e467630a85884d2696cf
commit: bb192ed9aa7191a5d65548f82c42b6750d65f569 mm/slub: Convert most struct page to struct slab by spatch
date:   3 months ago
config: mips-buildonly-randconfig-r004-20220324 (https://download.01.org/0day-ci/archive/20220325/202203250552.DbRtnNEv-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0f6d9501cf49ce02937099350d08f20c4af86f3d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bb192ed9aa7191a5d65548f82c42b6750d65f569
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout bb192ed9aa7191a5d65548f82c42b6750d65f569
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> mm/slub.c:2142:15: warning: variable 'partial_slabs' set but not used [-Wunused-but-set-variable]
           unsigned int partial_slabs = 0;
                        ^
   mm/slub.c:1663:29: warning: unused function 'node_nr_slabs' [-Wunused-function]
   static inline unsigned long node_nr_slabs(struct kmem_cache_node *n)
                               ^
   mm/slub.c:1681:21: warning: unused function 'kmalloc_large_node_hook' [-Wunused-function]
   static inline void *kmalloc_large_node_hook(void *ptr, size_t size, gfp_t flags)
                       ^
   3 warnings generated.


vim +/partial_slabs +2142 mm/slub.c

  2132	
  2133	/*
  2134	 * Try to allocate a partial slab from a specific node.
  2135	 */
  2136	static void *get_partial_node(struct kmem_cache *s, struct kmem_cache_node *n,
  2137				      struct slab **ret_slab, gfp_t gfpflags)
  2138	{
  2139		struct slab *slab, *slab2;
  2140		void *object = NULL;
  2141		unsigned long flags;
> 2142		unsigned int partial_slabs = 0;
  2143	
  2144		/*
  2145		 * Racy check. If we mistakenly see no partial slabs then we
  2146		 * just allocate an empty slab. If we mistakenly try to get a
  2147		 * partial slab and there is none available then get_partial()
  2148		 * will return NULL.
  2149		 */
  2150		if (!n || !n->nr_partial)
  2151			return NULL;
  2152	
  2153		spin_lock_irqsave(&n->list_lock, flags);
  2154		list_for_each_entry_safe(slab, slab2, &n->partial, slab_list) {
  2155			void *t;
  2156	
  2157			if (!pfmemalloc_match(slab, gfpflags))
  2158				continue;
  2159	
  2160			t = acquire_slab(s, n, slab, object == NULL);
  2161			if (!t)
  2162				break;
  2163	
  2164			if (!object) {
  2165				*ret_slab = slab;
  2166				stat(s, ALLOC_FROM_PARTIAL);
  2167				object = t;
  2168			} else {
  2169				put_cpu_partial(s, slab, 0);
  2170				stat(s, CPU_PARTIAL_NODE);
  2171				partial_slabs++;
  2172			}
  2173	#ifdef CONFIG_SLUB_CPU_PARTIAL
  2174			if (!kmem_cache_has_cpu_partial(s)
  2175				|| partial_slabs > s->cpu_partial_slabs / 2)
  2176				break;
  2177	#else
  2178			break;
  2179	#endif
  2180	
  2181		}
  2182		spin_unlock_irqrestore(&n->list_lock, flags);
  2183		return object;
  2184	}
  2185	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

             reply	other threads:[~2022-03-24 21:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24 21:19 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-09-05 11:10 mm/slub.c:2142:15: warning: variable 'partial_slabs' set but not used kernel test robot
2023-09-05 12:18 kernel test robot
2024-01-06  7:53 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202203250552.DbRtnNEv-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=42.hyeyoo@gmail.com \
    --cc=guro@fb.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.