From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4462827457134403934==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] mtd: spi-nor: fix minmax.cocci warnings Date: Sat, 26 Mar 2022 08:18:35 +0800 Message-ID: <20220326001834.GA68387@db465210e1cb> In-Reply-To: <202203260808.cODP9Z29-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============4462827457134403934== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org BCC: lkp(a)intel.com CC: linux-arm-kernel(a)lists.infradead.org TO: Amit Kumar Mahapatra CC: Michal Simek CC: Tudor Ambarus CC: Michael Walle CC: Pratyush Yadav CC: Miquel Raynal CC: Richard Weinberger CC: Vignesh Raghavendra CC: linux-mtd(a)lists.infradead.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/mtd/spi-nor/core.c:2037:10-11: WARNING opportunity for min() Check for opencoded min(), max() implementations. Generated patches sometimes require adding a cast to fix compile warning. Warnings/patches scope intentionally limited to a function body. Generated by: scripts/coccinelle/misc/minmax.cocci Fixes: 2747bc2106aa ("mtd: spi-nor: Add dual parallel and stacked mode supp= ort") CC: Amit Kumar Mahapatra Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS head: 1870e0fa79a9d58c6748c34550f3ccea0b515933 commit: 2747bc2106aa429773d9a932c799aa6229595148 [840/1029] mtd: spi-nor: A= dd dual parallel and stacked mode support :::::: branch date: 34 hours ago :::::: commit date: 8 weeks ago Please take the patch only if it's a positive warning. Thanks! drivers/mtd/spi-nor/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -2034,10 +2034,7 @@ static int spi_nor_read(struct mtd_info (offset << nor->shift); } } - if (len < rem_bank_len) - read_len =3D len; - else - read_len =3D rem_bank_len; + read_len =3D min(len, rem_bank_len); = /* Wait till previous write/erase is done. */ ret =3D spi_nor_wait_till_ready(nor); --===============4462827457134403934==--