From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34DB5C433F5 for ; Mon, 28 Mar 2022 05:59:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 93C4C40186; Mon, 28 Mar 2022 05:59:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f0c1u-x6pzwL; Mon, 28 Mar 2022 05:59:21 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 22AB0400F8; Mon, 28 Mar 2022 05:59:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id EA586C002C; Mon, 28 Mar 2022 05:59:20 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 02DD7C0012 for ; Mon, 28 Mar 2022 05:59:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D599B60B6E for ; Mon, 28 Mar 2022 05:59:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zULvwNXLRMaq for ; Mon, 28 Mar 2022 05:59:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id A00406068D for ; Mon, 28 Mar 2022 05:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648447155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FoH2TxNvMBERPcymekYDG3tnAiKwdZ/6n9Yxb48a3UI=; b=gaVU7wEEp0XFn9bbY4qDIkXvOpDkeVXt9ytgtPtGJASKLtAQXqgtkoaqcSMvzC+XHYZa0J 0d5QkcoWx3AL+G/hmNmPc57Y14w+6Szo5Rvjt6adhzP31LivJuGEezUM2gwyF/oP5JLqhg TJzPEhTio75D2byRsRY73z+VpTYdxvM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-104-7RpF8CvYOaCtiP7ZX-jfpg-1; Mon, 28 Mar 2022 01:59:14 -0400 X-MC-Unique: 7RpF8CvYOaCtiP7ZX-jfpg-1 Received: by mail-wm1-f69.google.com with SMTP id 84-20020a1c0257000000b0038124c99ebcso4962982wmc.9 for ; Sun, 27 Mar 2022 22:59:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FoH2TxNvMBERPcymekYDG3tnAiKwdZ/6n9Yxb48a3UI=; b=PQQ5AuSm10QSMhG7bZv07DU+e27K+XRvQkHa+9mNxuTzMEvD8yGB1eZzs/r1jyGOsR Nq2mqaoqQudoWJ3puNm61dBoZ6voWUqOZLnOiY/7Vc+2+Aw81cElHISSPiUSgbMPQ/y3 OeuqfjB4yvs9wJbxAoUavrLgvzb8pCbVBfdLujKx6PJLNx8wZdiIdgkl5bbaSxy5qq2g M2Q0nOxdWjZ8H/H1AnyaITAujvVEgjU8+9ciidb/3iEXBvZfBMjlegWYSE+KSGKZbgKe 3lDpVFNsO/cizFVfjYfgPWRqDx4HJmaMwkPjadvauNqfSWuq55oPTjeAj5L17vvzAyDe KNVg== X-Gm-Message-State: AOAM532F7nJJ37xbqydj08F2kLP5NLitE2+McWlZd+GDOzMXGTVD5mpf 6eJnCoMrpShnVRYSqRecUsApfIq4xnMFRgG0msm2MqXU5aekw5puMbPbDhg8mPXzy+oo+F5Yz0k UEB57bp2ew4BwBuZihj2yEVn0a2Ai2vzrMuHQO3eSmw== X-Received: by 2002:a5d:4804:0:b0:203:d59b:e83 with SMTP id l4-20020a5d4804000000b00203d59b0e83mr21622135wrq.696.1648447152377; Sun, 27 Mar 2022 22:59:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylIOn6hAS0Hrn2rM3DATefEAYnB0ddwSQcNCwnzsZIRwqhNfxJOurYduAh2P+uvsSbnSR7Ww== X-Received: by 2002:a5d:4804:0:b0:203:d59b:e83 with SMTP id l4-20020a5d4804000000b00203d59b0e83mr21622102wrq.696.1648447151985; Sun, 27 Mar 2022 22:59:11 -0700 (PDT) Received: from redhat.com ([2.52.9.207]) by smtp.gmail.com with ESMTPSA id v5-20020adfe4c5000000b001edc1e5053esm10991393wrm.82.2022.03.27.22.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Mar 2022 22:59:11 -0700 (PDT) Date: Mon, 28 Mar 2022 01:59:07 -0400 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: Message-ID: <20220328015757-mutt-send-email-mst@kernel.org> References: <20220325050947-mutt-send-email-mst@kernel.org> <20220325060659-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: "Paul E. McKenney" , Peter Zijlstra , Marc Zyngier , Keir Fraser , linux-kernel , virtualization , Thomas Gleixner X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gTW9uLCBNYXIgMjgsIDIwMjIgYXQgMTI6NTY6NDFQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiBPbiBGcmksIE1hciAyNSwgMjAyMiBhdCA2OjEwIFBNIE1pY2hhZWwgUy4gVHNpcmtpbiA8 bXN0QHJlZGhhdC5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIEZyaSwgTWFyIDI1LCAyMDIyIGF0IDA1 OjIwOjE5UE0gKzA4MDAsIEphc29uIFdhbmcgd3JvdGU6Cj4gPiA+IE9uIEZyaSwgTWFyIDI1LCAy MDIyIGF0IDU6MTAgUE0gTWljaGFlbCBTLiBUc2lya2luIDxtc3RAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gPiA+ID4KPiA+ID4gPiBPbiBGcmksIE1hciAyNSwgMjAyMiBhdCAwMzo1MjowMFBNICswODAw LCBKYXNvbiBXYW5nIHdyb3RlOgo+ID4gPiA+ID4gT24gRnJpLCBNYXIgMjUsIDIwMjIgYXQgMjoz MSBQTSBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPiB3cm90ZToKPiA+ID4gPiA+ ID4KPiA+ID4gPiA+ID4gQmNjOgo+ID4gPiA+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIIDMvM10g dmlydGlvOiBoYXJkZW4gdnJpbmcgSVJRCj4gPiA+ID4gPiA+IE1lc3NhZ2UtSUQ6IDwyMDIyMDMy NTAyMTQyMi1tdXR0LXNlbmQtZW1haWwtbXN0QGtlcm5lbC5vcmc+Cj4gPiA+ID4gPiA+IFJlcGx5 LVRvOgo+ID4gPiA+ID4gPiBJbi1SZXBseS1UbzogPGY3MDQ2MzAzLTdkN2QtZTM5Zi0zYzcxLTM2 ODgxMjZjYzgxMkByZWRoYXQuY29tPgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBPbiBGcmksIE1h ciAyNSwgMjAyMiBhdCAxMTowNDowOEFNICswODAwLCBKYXNvbiBXYW5nIHdyb3RlOgo+ID4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+ID4g5ZyoIDIwMjIvMy8yNCDkuIvljYg3OjAzLCBNaWNoYWVsIFMu IFRzaXJraW4g5YaZ6YGTOgo+ID4gPiA+ID4gPiA+ID4gT24gVGh1LCBNYXIgMjQsIDIwMjIgYXQg MDQ6NDA6MDRQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90ZToKPiA+ID4gPiA+ID4gPiA+ID4gVGhp cyBpcyBhIHJld29yayBvbiB0aGUgcHJldmlvdXMgSVJRIGhhcmRlbmluZyB0aGF0IGlzIGRvbmUg Zm9yCj4gPiA+ID4gPiA+ID4gPiA+IHZpcnRpby1wY2kgd2hlcmUgc2V2ZXJhbCBkcmF3YmFja3Mg d2VyZSBmb3VuZCBhbmQgd2VyZSByZXZlcnRlZDoKPiA+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ ID4gPiA+ID4gMSkgdHJ5IHRvIHVzZSBJUlFGX05PX0FVVE9FTiB3aGljaCBpcyBub3QgZnJpZW5k bHkgdG8gYWZmaW5pdHkgbWFuYWdlZCBJUlEKPiA+ID4gPiA+ID4gPiA+ID4gICAgIHRoYXQgaXMg dXNlZCBieSBzb21lIGRldmljZSBzdWNoIGFzIHZpcnRpby1ibGsKPiA+ID4gPiA+ID4gPiA+ID4g MikgZG9uZSBvbmx5IGZvciBQQ0kgdHJhbnNwb3J0Cj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4g PiA+ID4gPiA+IEluIHRoaXMgcGF0Y2gsIHdlIHRyaWVzIHRvIGJvcnJvdyB0aGUgaWRlYSBmcm9t IHRoZSBJTlRYIElSUSBoYXJkZW5pbmcKPiA+ID4gPiA+ID4gPiA+ID4gaW4gdGhlIHJldmVydGVk IGNvbW1pdCAwODBjZDdjM2FjODcgKCJ2aXJ0aW8tcGNpOiBoYXJkZW4gSU5UWCBpbnRlcnJ1cHRz IikKPiA+ID4gPiA+ID4gPiA+ID4gYnkgaW50cm9kdWNpbmcgYSBnbG9iYWwgaXJxX3NvZnRfZW5h YmxlZCB2YXJpYWJsZSBmb3IgZWFjaAo+ID4gPiA+ID4gPiA+ID4gPiB2aXJ0aW9fZGV2aWNlLiBU aGVuIHdlIGNhbiB0byB0b2dnbGUgaXQgZHVyaW5nCj4gPiA+ID4gPiA+ID4gPiA+IHZpcnRpb19y ZXNldF9kZXZpY2UoKS92aXJ0aW9fZGV2aWNlX3JlYWR5KCkuIEEgc3luY2hvcm5pemVfcmN1KCkg aXMKPiA+ID4gPiA+ID4gPiA+ID4gdXNlZCBpbiB2aXJ0aW9fcmVzZXRfZGV2aWNlKCkgdG8gc3lu Y2hyb25pemUgd2l0aCB0aGUgSVJRIGhhbmRsZXJzLiBJbgo+ID4gPiA+ID4gPiA+ID4gPiB0aGUg ZnV0dXJlLCB3ZSBtYXkgcHJvdmlkZSBjb25maWdfb3BzIGZvciB0aGUgdHJhbnNwb3J0IHRoYXQg ZG9lc24ndAo+ID4gPiA+ID4gPiA+ID4gPiB1c2UgSVJRLiBXaXRoIHRoaXMsIHZyaW5nX2ludGVy cnVwdCgpIGNhbiByZXR1cm4gY2hlY2sgYW5kIGVhcmx5IGlmCj4gPiA+ID4gPiA+ID4gPiA+IGly cV9zb2Z0X2VuYWJsZWQgaXMgZmFsc2UuIFRoaXMgbGVhZCB0byBzbXBfbG9hZF9hY3F1aXJlKCkg dG8gYmUgdXNlZAo+ID4gPiA+ID4gPiA+ID4gPiBidXQgdGhlIGNvc3Qgc2hvdWxkIGJlIGFjY2Vw dGFibGUuCj4gPiA+ID4gPiA+ID4gPiBNYXliZSBpdCBzaG91bGQgYmUgYnV0IGlzIGl0PyBDYW4n dCB3ZSB1c2Ugc3luY2hyb25pemVfaXJxIGluc3RlYWQ/Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ ID4gPgo+ID4gPiA+ID4gPiA+IEV2ZW4gaWYgd2UgYWxsb3cgdGhlIHRyYW5zcG9ydCBkcml2ZXIg dG8gc3luY2hvcm5pemUgdGhyb3VnaAo+ID4gPiA+ID4gPiA+IHN5bmNocm9uaXplX2lycSgpIHdl IHN0aWxsIG5lZWQgYSBjaGVjayBpbiB0aGUgdnJpbmdfaW50ZXJydXB0KCkuCj4gPiA+ID4gPiA+ ID4KPiA+ID4gPiA+ID4gPiBXZSBkbyBzb21ldGhpbmcgbGlrZSB0aGUgZm9sbG93aW5nIHByZXZp b3VzbHk6Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiAgICAgICAgIGlmICghUkVBRF9PTkNF KHZwX2Rldi0+aW50eF9zb2Z0X2VuYWJsZWQpKQo+ID4gPiA+ID4gPiA+ICAgICAgICAgICAgICAg ICByZXR1cm4gSVJRX05PTkU7Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBCdXQgaXQgbG9v a3MgbGlrZSBhIGJ1ZyBzaW5jZSBzcGVjdWxhdGl2ZSByZWFkIGNhbiBiZSBkb25lIGJlZm9yZSB0 aGUgY2hlY2sKPiA+ID4gPiA+ID4gPiB3aGVyZSB0aGUgaW50ZXJydXB0IGhhbmRsZXIgY2FuJ3Qg c2VlIHRoZSB1bmNvbW1pdHRlZCBzZXR1cCB3aGljaCBpcyBkb25lIGJ5Cj4gPiA+ID4gPiA+ID4g dGhlIGRyaXZlci4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gSSBkb24ndCB0aGluayBzbyAtIGlm IHlvdSBzeW5jIGFmdGVyIHNldHRpbmcgdGhlIHZhbHVlIHRoZW4KPiA+ID4gPiA+ID4geW91IGFy ZSBndWFyYW50ZWVkIHRoYXQgYW55IGhhbmRsZXIgcnVubmluZyBhZnRlcndhcmRzCj4gPiA+ID4g PiA+IHdpbGwgc2VlIHRoZSBuZXcgdmFsdWUuCj4gPiA+ID4gPgo+ID4gPiA+ID4gVGhlIHByb2Js ZW0gaXMgbm90IGRpc2FibGVkIGJ1dCB0aGUgZW5hYmxlLgo+ID4gPiA+Cj4gPiA+ID4gU28gYSBt aXNiZWhhdmluZyBkZXZpY2UgY2FuIGxvc2UgaW50ZXJydXB0cz8gVGhhdCdzIG5vdCBhIHByb2Js ZW0gYXQgYWxsCj4gPiA+ID4gaW1vLgo+ID4gPgo+ID4gPiBJdCdzIHRoZSBpbnRlcnJ1cHQgcmFp c2VkIGJlZm9yZSBzZXR0aW5nIGlycV9zb2Z0X2VuYWJsZWQgdG8gdHJ1ZToKPiA+ID4KPiA+ID4g Q1BVIDAgcHJvYmUpIGRyaXZlciBzcGVjaWZpYyBzZXR1cCAobm90IGNvbW1pdGVkKQo+ID4gPiBD UFUgMSBJUlEgaGFuZGxlcikgcmVhZCB0aGUgdW5pbml0aWFsaXplZCB2YXJpYWJsZQo+ID4gPiBD UFUgMCBwcm9iZSkgc2V0IGlycV9zb2Z0X2VuYWJsZWQgdG8gdHJ1ZQo+ID4gPiBDUFUgMSBJUlEg aGFuZGxlcikgcmVhZCBpcnFfc29mdF9lbmFibGUgYXMgdHJ1ZQo+ID4gPiBDUFUgMSBJUlEgaGFu ZGxlcikgdXNlIHRoZSB1bmluaXRpYWxpemVkIHZhcmlhYmxlCj4gPiA+Cj4gPiA+IFRoYW5rcwo+ ID4KPiA+IFllYSwgaXQgaHVydHMgaWYgeW91IGRvIGl0LiAgU28gZG8gbm90IGRvIGl0IHRoZW4g OykuCj4gPgo+ID4gaXJxX3NvZnRfZW5hYmxlZCAoSSB0aGluayBkcml2ZXJfb2sgb3Igc3RhdHVz IGlzIGEgYmV0dGVyIG5hbWUpCj4gCj4gSSBjYW4gY2hhbmdlIGl0IHRvIGRyaXZlcl9vay4KPiAK PiA+IHNob3VsZCBiZSBpbml0aWFsaXplZCB0byBmYWxzZSAqYmVmb3JlKiBpcnEgaXMgcmVxdWVz dGVkLgo+ID4KPiA+IEFuZCByZXF1ZXN0aW5nIGlycSBjb21taXRzIGFsbCBtZW1vcnkgb3RoZXJ3 aXNlIGFsbCBkcml2ZXJzIHdvdWxkIGJlCj4gPiBicm9rZW4sCj4gCj4gU28gSSB0aGluayB3ZSBt aWdodCB0YWxrIGRpZmZlcmVudCBpc3N1ZXM6Cj4gCj4gMSkgV2hldGhlciByZXF1ZXN0X2lycSgp IGNvbW1pdHMgdGhlIHByZXZpb3VzIHNldHVwcywgSSB0aGluayB0aGUKPiBhbnN3ZXIgaXMgeWVz LCBzaW5jZSB0aGUgc3Bpbl91bmxvY2sgb2YgZGVzYy0+bG9jayAocmVsZWFzZSkgY2FuCj4gZ3Vh cmFudGVlIHRoaXMgdGhvdWdoIHRoZXJlIHNlZW1zIG5vIGRvY3VtZW50YXRpb24gYXJvdW5kCj4g cmVxdWVzdF9pcnEoKSB0byBzYXkgdGhpcy4KPiAKPiBBbmQgSSBjYW4gc2VlIGF0IGxlYXN0IGRy aXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rzcy9kaXNwYy5jIGlzCj4gdXNpbmcgc21w X3dtYigpIGJlZm9yZSB0aGUgcmVxdWVzdF9pcnEoKS4KPiAKPiBBbmQgZXZlbiBpZiB3cml0ZSBp cyBvcmRlcmVkIHdlIHN0aWxsIG5lZWQgcmVhZCB0byBiZSBvcmRlcmVkIHRvIGJlCj4gcGFpcmVk IHdpdGggdGhhdC4KPiAKPiA+IGlmIGl0IGRvZXNuJ3QgaXQganVzdCBuZWVkcyB0byBiZSBmaXhl ZCwgbm90IHdvcmtlZCBhcm91bmQgaW4KPiA+IHZpcnRpby4KPiAKPiAyKSB2aXJ0aW8gZHJpdmVy cyBtaWdodCBkbyBhIGxvdCBvZiBzZXR1cHMgYmV0d2VlbiByZXF1ZXN0X2lycSgpIGFuZAo+IHZp cnRpb19kZXZpY2VfcmVhZHkoKToKPiAKPiByZXF1ZXN0X2lycSgpCj4gZHJpdmVyIHNwZWNpZmlj IHNldHVwcwo+IHZpcnRpb19kZXZpY2VfcmVhZHkoKQo+IAo+IENQVSAwIHByb2JlKSByZXF1ZXN0 X2lycSgpCj4gQ1BVIDEgSVJRIGhhbmRsZXIpIHJlYWQgdGhlIHVuaW5pdGlhbGl6ZWQgdmFyaWFi bGUKPiBDUFUgMCBwcm9iZSkgZHJpdmVyIHNwZWNpZmljIHNldHVwcwo+IENQVSAwIHByb2JlKSBz bXBfc3RvcmVfcmVsZWFzZShpbnRyX3NvZnRfZW5hYmxlZCwgdHJ1ZSksIGNvbW1pdCB0aGUgc2V0 dXBzCj4gQ1BVIDEgSVJRIGhhbmRsZXIpIHJlYWQgaXJxX3NvZnRfZW5hYmxlIGFzIHRydWUKPiBD UFUgMSBJUlEgaGFuZGxlcikgdXNlIHRoZSB1bmluaXRpYWxpemVkIHZhcmlhYmxlCj4gCj4gVGhh bmtzCgoKQXMgSSBzYWlkLCB2aXJ0aW9fZGV2aWNlX3JlYWR5IG5lZWRzIHRvIGRvIHN5bmNocm9u aXplX2lycS4KVGhhdCB3aWxsIGd1YXJhbnRlZSBhbGwgc2V0dXAgaXMgdmlzaWJsZSB0byB0aGUg c3BlY2lmaWMgSVJRLCB0aGlzCmlzIHdoYXQgaXQncyBwb2ludCBpcy4KCgo+ID4KPiA+Cj4gPiA+ ID4KPiA+ID4gPiA+IFdlIHVzZSBzbXBfc3RvcmVfcmVsYXNlKCkKPiA+ID4gPiA+IHRvIG1ha2Ug c3VyZSB0aGUgZHJpdmVyIGNvbW1pdHMgdGhlIHNldHVwIGJlZm9yZSBlbmFibGluZyB0aGUgaXJx LiBJdAo+ID4gPiA+ID4gbWVhbnMgdGhlIHJlYWQgbmVlZHMgdG8gYmUgb3JkZXJlZCBhcyB3ZWxs IGluIHZyaW5nX2ludGVycnVwdCgpLgo+ID4gPiA+ID4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4g QWx0aG91Z2ggSSBjb3VsZG4ndCBmaW5kIGFueXRoaW5nIGFib3V0IHRoaXMgaW4gbWVtb3J5LWJh cnJpZXJzLnR4dAo+ID4gPiA+ID4gPiB3aGljaCBzdXJwcmlzZXMgbWUuCj4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+IENDIFBhdWwgdG8gaGVscCBtYWtlIHN1cmUgSSdtIHJpZ2h0Lgo+ID4gPiA+ID4g Pgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ ID4gPiBUbyBhdm9pZCBicmVha2luZyBsZWdhY3kgZGV2aWNlIHdoaWNoIGNhbiBzZW5kIElSUSBi ZWZvcmUgRFJJVkVSX09LLCBhCj4gPiA+ID4gPiA+ID4gPiA+IG1vZHVsZSBwYXJhbWV0ZXIgaXMg aW50cm9kdWNlZCB0byBlbmFibGUgdGhlIGhhcmRlbmluZyBzbyBmdW5jdGlvbgo+ID4gPiA+ID4g PiA+ID4gPiBoYXJkZW5pbmcgaXMgZGlzYWJsZWQgYnkgZGVmYXVsdC4KPiA+ID4gPiA+ID4gPiA+ IFdoaWNoIGRldmljZXMgYXJlIHRoZXNlPyBIb3cgY29tZSB0aGV5IHNlbmQgYW4gaW50ZXJydXB0 IGJlZm9yZSB0aGVyZQo+ID4gPiA+ID4gPiA+ID4gYXJlIGFueSBidWZmZXJzIGluIGFueSBxdWV1 ZXM/Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IEkgY29waWVkIHRo aXMgZnJvbSB0aGUgY29tbWl0IGxvZyBmb3IgMjJiNzA1MGEwMjRkNwo+ID4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+ID4gIgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gICAgIFRoaXMgY2hhbmdl IHdpbGwgYWxzbyBiZW5lZml0IG9sZCBoeXBlcnZpc29ycyAoYmVmb3JlIDIwMDkpCj4gPiA+ID4g PiA+ID4gICAgIHRoYXQgc2VuZCBpbnRlcnJ1cHRzIHdpdGhvdXQgY2hlY2tpbmcgRFJJVkVSX09L OiBwcmV2aW91c2x5LAo+ID4gPiA+ID4gPiA+ICAgICB0aGUgY2FsbGJhY2sgY291bGQgcmFjZSB3 aXRoIGRyaXZlci1zcGVjaWZpYyBpbml0aWFsaXphdGlvbi4KPiA+ID4gPiA+ID4gPiAiCj4gPiA+ ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBJZiB0aGlzIGlzIG9ubHkgZm9yIGNvbmZpZyBpbnRlcnJ1 cHQsIEkgY2FuIHJlbW92ZSB0aGUgYWJvdmUgbG9nLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPgo+ ID4gPiA+ID4gPiBUaGlzIGlzIG9ubHkgZm9yIGNvbmZpZyBpbnRlcnJ1cHQuCj4gPiA+ID4gPgo+ ID4gPiA+ID4gT2suCj4gPiA+ID4gPgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4g PiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiBOb3RlIHRoYXQgdGhlIGhhcmRlbmluZyBpcyBvbmx5 IGRvbmUgZm9yIHZyaW5nIGludGVycnVwdCBzaW5jZSB0aGUKPiA+ID4gPiA+ID4gPiA+ID4gY29u ZmlnIGludGVycnVwdCBoYXJkZW5pbmcgaXMgYWxyZWFkeSBkb25lIGluIGNvbW1pdCAyMmI3MDUw YTAyNGQ3Cj4gPiA+ID4gPiA+ID4gPiA+ICgidmlydGlvOiBkZWZlciBjb25maWcgY2hhbmdlZCBu b3RpZmljYXRpb25zIikuIEJ1dCB0aGUgbWV0aG9kIHRoYXQgaXMKPiA+ID4gPiA+ID4gPiA+ID4g dXNlZCBieSBjb25maWcgaW50ZXJydXB0IGNhbid0IGJlIHJldXNlZCBieSB0aGUgdnJpbmcgaW50 ZXJydXB0Cj4gPiA+ID4gPiA+ID4gPiA+IGhhbmRsZXIgYmVjYXVzZSBpdCB1c2VzIHNwaW5sb2Nr IHRvIGRvIHRoZSBzeW5jaHJvbml6YXRpb24gd2hpY2ggaXMKPiA+ID4gPiA+ID4gPiA+ID4gZXhw ZW5zaXZlLgo+ID4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4g PiA+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+ID4gPiA+ICAgZHJpdmVycy92aXJ0aW8vdmlydGlv LmMgICAgICAgfCAxOSArKysrKysrKysrKysrKysrKysrCj4gPiA+ID4gPiA+ID4gPiA+ICAgZHJp dmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYyAgfCAgOSArKysrKysrKy0KPiA+ID4gPiA+ID4gPiA+ ID4gICBpbmNsdWRlL2xpbnV4L3ZpcnRpby5oICAgICAgICB8ICA0ICsrKysKPiA+ID4gPiA+ID4g PiA+ID4gICBpbmNsdWRlL2xpbnV4L3ZpcnRpb19jb25maWcuaCB8IDI1ICsrKysrKysrKysrKysr KysrKysrKysrKysKPiA+ID4gPiA+ID4gPiA+ID4gICA0IGZpbGVzIGNoYW5nZWQsIDU2IGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpby5jIGIvZHJpdmVycy92aXJ0aW8v dmlydGlvLmMKPiA+ID4gPiA+ID4gPiA+ID4gaW5kZXggOGRkZTQ0ZWEwNDRhLi44NWUzMzFlZmE5 Y2MgMTAwNjQ0Cj4gPiA+ID4gPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpby5j Cj4gPiA+ID4gPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvdmlydGlvL3ZpcnRpby5jCj4gPiA+ID4g PiA+ID4gPiA+IEBAIC03LDYgKzcsMTIgQEAKPiA+ID4gPiA+ID4gPiA+ID4gICAjaW5jbHVkZSA8 bGludXgvb2YuaD4KPiA+ID4gPiA+ID4gPiA+ID4gICAjaW5jbHVkZSA8dWFwaS9saW51eC92aXJ0 aW9faWRzLmg+Cj4gPiA+ID4gPiA+ID4gPiA+ICtzdGF0aWMgYm9vbCBpcnFfaGFyZGVuaW5nID0g ZmFsc2U7Cj4gPiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4gK21vZHVsZV9wYXJh bShpcnFfaGFyZGVuaW5nLCBib29sLCAwNDQ0KTsKPiA+ID4gPiA+ID4gPiA+ID4gK01PRFVMRV9Q QVJNX0RFU0MoaXJxX2hhcmRlbmluZywKPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgICAiRGlz YWxiZSBJUlEgc29mdHdhcmUgcHJvY2Vzc2luZyB3aGVuIGl0IGlzIG5vdCBleHBlY3RlZCIpOwo+ ID4gPiA+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ID4gPiA+ICAgLyogVW5pcXVlIG51bWJlcmlu ZyBmb3IgdmlydGlvIGRldmljZXMuICovCj4gPiA+ID4gPiA+ID4gPiA+ICAgc3RhdGljIERFRklO RV9JREEodmlydGlvX2luZGV4X2lkYSk7Cj4gPiA+ID4gPiA+ID4gPiA+IEBAIC0yMjAsNiArMjI2 LDE1IEBAIHN0YXRpYyBpbnQgdmlydGlvX2ZlYXR1cmVzX29rKHN0cnVjdCB2aXJ0aW9fZGV2aWNl ICpkZXYpCj4gPiA+ID4gPiA+ID4gPiA+ICAgICogKi8KPiA+ID4gPiA+ID4gPiA+ID4gICB2b2lk IHZpcnRpb19yZXNldF9kZXZpY2Uoc3RydWN0IHZpcnRpb19kZXZpY2UgKmRldikKPiA+ID4gPiA+ ID4gPiA+ID4gICB7Cj4gPiA+ID4gPiA+ID4gPiA+ICsgLyoKPiA+ID4gPiA+ID4gPiA+ID4gKyAg KiBUaGUgYmVsb3cgc3luY2hyb25pemVfcmN1KCkgZ3VhcmFudGVlcyB0aGF0IGFueQo+ID4gPiA+ ID4gPiA+ID4gPiArICAqIGludGVycnVwdCBmb3IgdGhpcyBsaW5lIGFycml2aW5nIGFmdGVyCj4g PiA+ID4gPiA+ID4gPiA+ICsgICogc3luY2hyb25pemVfcmN1KCkgaGFzIGNvbXBsZXRlZCBpcyBn dWFyYW50ZWVkIHRvIHNlZQo+ID4gPiA+ID4gPiA+ID4gPiArICAqIGlycV9zb2Z0X2VuYWJsZWQg PT0gZmFsc2UuCj4gPiA+ID4gPiA+ID4gPiBOZXdzIHRvIG1lIEkgZGlkIG5vdCBrbm93IHN5bmNo cm9uaXplX3JjdSBoYXMgYW55dGhpbmcgdG8gZG8KPiA+ID4gPiA+ID4gPiA+IHdpdGggaW50ZXJy dXB0cy4gRGlkIG5vdCB5b3UgaW50ZW5kIHRvIHVzZSBzeW5jaHJvbml6ZV9pcnE/Cj4gPiA+ID4g PiA+ID4gPiBJIGFtIG5vdCBldmVuIDEwMCUgc3VyZSBzeW5jaHJvbml6ZV9yY3UgaXMgYnkgZGVz aWduIGEgbWVtb3J5IGJhcnJpZXIKPiA+ID4gPiA+ID4gPiA+IHRob3VnaCBpdCdzIG1vc3QgbGlr ZWx5IGlzIC4uLgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBBY2Nv cmRpbmcgdG8gdGhlIGNvbW1lbnQgYWJvdmUgdHJlZSBSQ1UgdmVyc2lvbiBvZiBzeW5jaHJvbml6 ZV9yY3UoKToKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ICIiIgo+ID4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+ID4gICogUkNVIHJlYWQtc2lkZSBjcml0aWNhbCBzZWN0aW9ucyBhcmUgZGVsaW1p dGVkIGJ5IHJjdV9yZWFkX2xvY2soKQo+ID4gPiA+ID4gPiA+ICAqIGFuZCByY3VfcmVhZF91bmxv Y2soKSwgYW5kIG1heSBiZSBuZXN0ZWQuICBJbiBhZGRpdGlvbiwgYnV0IG9ubHkgaW4KPiA+ID4g PiA+ID4gPiAgKiB2NS4wIGFuZCBsYXRlciwgcmVnaW9ucyBvZiBjb2RlIGFjcm9zcyB3aGljaCBp bnRlcnJ1cHRzLCBwcmVlbXB0aW9uLAo+ID4gPiA+ID4gPiA+ICAqIG9yIHNvZnRpcnFzIGhhdmUg YmVlbiBkaXNhYmxlZCBhbHNvIHNlcnZlIGFzIFJDVSByZWFkLXNpZGUgY3JpdGljYWwKPiA+ID4g PiA+ID4gPiAgKiBzZWN0aW9ucy4gIFRoaXMgaW5jbHVkZXMgaGFyZHdhcmUgaW50ZXJydXB0IGhh bmRsZXJzLCBzb2Z0aXJxIGhhbmRsZXJzLAo+ID4gPiA+ID4gPiA+ICAqIGFuZCBOTUkgaGFuZGxl cnMuCj4gPiA+ID4gPiA+ID4gIiIiCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBTbyBpbnRl cnJ1cHQgaGFuZGxlcnMgYXJlIHRyZWF0ZWQgYXMgcmVhZC1zaWRlIGNyaXRpY2FsIHNlY3Rpb25z Lgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gQW5kIGl0IGhhcyB0aGUgY29tbWVudCBmb3Ig ZXhwbGFpbiB0aGUgYmFycmllcjoKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ICIiIgo+ID4g PiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gICogTm90ZSB0aGF0IHRoaXMgZ3VhcmFudGVlIGltcGxp ZXMgZnVydGhlciBtZW1vcnktb3JkZXJpbmcgZ3VhcmFudGVlcy4KPiA+ID4gPiA+ID4gPiAgKiBP biBzeXN0ZW1zIHdpdGggbW9yZSB0aGFuIG9uZSBDUFUsIHdoZW4gc3luY2hyb25pemVfcmN1KCkg cmV0dXJucywKPiA+ID4gPiA+ID4gPiAgKiBlYWNoIENQVSBpcyBndWFyYW50ZWVkIHRvIGhhdmUg ZXhlY3V0ZWQgYSBmdWxsIG1lbW9yeSBiYXJyaWVyIHNpbmNlCj4gPiA+ID4gPiA+ID4gICogdGhl IGVuZCBvZiBpdHMgbGFzdCBSQ1UgcmVhZC1zaWRlIGNyaXRpY2FsIHNlY3Rpb24gd2hvc2UgYmVn aW5uaW5nCj4gPiA+ID4gPiA+ID4gICogcHJlY2VkZWQgdGhlIGNhbGwgdG8gc3luY2hyb25pemVf cmN1KCkuICBJbiBhZGRpdGlvbiwgZWFjaCBDUFUgaGF2aW5nCj4gPiA+ID4gPiA+ID4gIiIiCj4g PiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBTbyBvbiBTTVAgaXQgcHJvdmlkZXMgYSBmdWxsIGJh cnJpZXIuIEFuZCBmb3IgVVAvdGlueSBSQ1Ugd2UgZG9uJ3QgbmVlZCB0aGUKPiA+ID4gPiA+ID4g PiBiYXJyaWVyLCBpZiB0aGUgaW50ZXJydXB0IGNvbWUgYWZ0ZXIgV1JJVEVfT05DRSgpIGl0IHdp bGwgc2VlIHRoZQo+ID4gPiA+ID4gPiA+IGlycV9zb2Z0X2VuYWJsZWQgYXMgZmFsc2UuCj4gPiA+ ID4gPiA+ID4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gWW91IGFyZSByaWdodC4gU28gdGhlbgo+ ID4gPiA+ID4gPiAxLiBJIGRvIG5vdCB0aGluayB3ZSBuZWVkIGxvYWRfYWNxdWlyZSAtIHdoeSBp cyBpdCBuZWVkZWQ/IEp1c3QKPiA+ID4gPiA+ID4gICAgUkVBRF9PTkNFIHNob3VsZCBkby4KPiA+ ID4gPiA+Cj4gPiA+ID4gPiBTZWUgYWJvdmUuCj4gPiA+ID4gPgo+ID4gPiA+ID4gPiAyLiBpc24n dCBzeW5jaHJvbml6ZV9pcnEgYWxzbyBkb2luZyB0aGUgc2FtZSB0aGluZz8KPiA+ID4gPiA+Cj4g PiA+ID4gPgo+ID4gPiA+ID4gWWVzLCBidXQgaXQgcmVxdWlyZXMgYSBjb25maWcgb3BzIHNpbmNl IHRoZSBJUlEga25vd2xlZGdlIGlzIHRyYW5zcG9ydCBzcGVjaWZpYy4KPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiArICAq Lwo+ID4gPiA+ID4gPiA+ID4gPiArIFdSSVRFX09OQ0UoZGV2LT5pcnFfc29mdF9lbmFibGVkLCBm YWxzZSk7Cj4gPiA+ID4gPiA+ID4gPiA+ICsgc3luY2hyb25pemVfcmN1KCk7Cj4gPiA+ID4gPiA+ ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgIGRldi0+Y29uZmlnLT5yZXNldChk ZXYpOwo+ID4gPiA+ID4gPiA+ID4gPiAgIH0KPiA+ID4gPiA+ID4gPiA+ID4gICBFWFBPUlRfU1lN Qk9MX0dQTCh2aXJ0aW9fcmVzZXRfZGV2aWNlKTsKPiA+ID4gPiA+ID4gPiA+IFBsZWFzZSBhZGQg Y29tbWVudCBleHBsYWluaW5nIHdoZXJlIGl0IHdpbGwgYmUgZW5hYmxlZC4KPiA+ID4gPiA+ID4g PiA+IEFsc28sIHdlICpyZWFsbHkqIGRvbid0IG5lZWQgdG8gc3luY2ggaWYgaXQgd2FzIGFscmVh ZHkgZGlzYWJsZWQsCj4gPiA+ID4gPiA+ID4gPiBsZXQncyBub3QgYWRkIHVzZWxlc3Mgb3Zlcmhl YWQgdG8gdGhlIGJvb3Qgc2VxdWVuY2UuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPgo+ID4g PiA+ID4gPiA+IE9rLgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiBAQCAtNDI3LDYgKzQ0MiwxMCBAQCBp bnQgcmVnaXN0ZXJfdmlydGlvX2RldmljZShzdHJ1Y3QgdmlydGlvX2RldmljZSAqZGV2KQo+ID4g PiA+ID4gPiA+ID4gPiAgICAgICAgICAgc3Bpbl9sb2NrX2luaXQoJmRldi0+Y29uZmlnX2xvY2sp Owo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgZGV2LT5jb25maWdfZW5hYmxlZCA9IGZhbHNl Owo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgZGV2LT5jb25maWdfY2hhbmdlX3BlbmRpbmcg PSBmYWxzZTsKPiA+ID4gPiA+ID4gPiA+ID4gKyBkZXYtPmlycV9zb2Z0X2NoZWNrID0gaXJxX2hh cmRlbmluZzsKPiA+ID4gPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ID4gPiArIGlmIChkZXYt PmlycV9zb2Z0X2NoZWNrKQo+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgICAgZGV2X2luZm8oJmRl di0+ZGV2LCAiSVJRIGhhcmRlbmluZyBpcyBlbmFibGVkXG4iKTsKPiA+ID4gPiA+ID4gPiA+ID4g ICAgICAgICAgIC8qIFdlIGFsd2F5cyBzdGFydCBieSByZXNldHRpbmcgdGhlIGRldmljZSwgaW4g Y2FzZSBhIHByZXZpb3VzCj4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICAgKiBkcml2ZXIgbWVz c2VkIGl0IHVwLiAgVGhpcyBhbHNvIHRlc3RzIHRoYXQgY29kZSBwYXRoIGEgbGl0dGxlLiAqLwo+ ID4gPiA+ID4gPiA+ID4gb25lIG9mIHRoZSBwb2ludHMgb2YgaGFyZGVuaW5nIGlzIGl0J3MgYWxz byBoZWxwZnVsIGZvciBidWdneQo+ID4gPiA+ID4gPiA+ID4gZGV2aWNlcy4gdGhpcyBmbGFnIGRl ZmVhdHMgdGhlIHB1cnBvc2UuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiA+IERvIHlvdSBtZWFuOgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gMSkgd2UgbmVlZCBz b21ldGhpbmcgbGlrZSBjb25maWdfZW5hYmxlPyBUaGlzIHNlZW1zIG5vdCBlYXN5IHRvIGJlCj4g PiA+ID4gPiA+ID4gaW1wbGVtZW50ZWQgd2l0aG91dCBvYnZpb3VzIG92ZXJoZWFkLCBtYWlubHkg dGhlIHN5bmNocm9uaXplIHdpdGggdGhlCj4gPiA+ID4gPiA+ID4gaW50ZXJydXB0IGhhbmRsZXJz Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IEJ1dCBzeW5jaHJvbml6ZSBpcyBvbmx5IG9uIHRlYXIt ZG93biBwYXRoLiBUaGF0IGlzIG5vdCBjcml0aWNhbCBmb3IgYW55Cj4gPiA+ID4gPiA+IHVzZXJz IGF0IHRoZSBtb21lbnQsIGV2ZW4gbGVzcyB0aGFuIHByb2JlLgo+ID4gPiA+ID4KPiA+ID4gPiA+ IEkgbWVhbnQgaWYgd2UgaGF2ZSB2cS0+aXJxX3BlbmRpbmcsIHdlIG5lZWQgdG8gY2FsbCB2cmlu Z19pbnRlcnJ1cHQoKQo+ID4gPiA+ID4gaW4gdGhlIHZpcnRpb19kZXZpY2VfcmVhZHkoKSBhbmQg c3luY2hyb25pemUgdGhlIElSUSBoYW5kbGVycyB3aXRoCj4gPiA+ID4gPiBzcGlubG9jayBvciBv dGhlcnMuCj4gPiA+ID4gPgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IDIpIGVuYWJsZSB0aGlz IGJ5IGRlZmF1bHQsIHNvIEkgZG9uJ3Qgb2JqZWN0LCBidXQgdGhpcyBtYXkgaGF2ZSBzb21lIHJp c2sKPiA+ID4gPiA+ID4gPiBmb3Igb2xkIGh5cGVydmlzb3JzCj4gPiA+ID4gPiA+Cj4gPiA+ID4g PiA+Cj4gPiA+ID4gPiA+IFRoZSByaXNrIGlmIHRoZXJlJ3MgYSBkcml2ZXIgYWRkaW5nIGJ1ZmZl cnMgd2l0aG91dCBzZXR0aW5nIERSSVZFUl9PSy4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBQcm9iYWJs eSBub3QsIHdlIGhhdmUgZGV2aWNlcyB0aGF0IGFjY2VwdCByYW5kb20gaW5wdXRzIGZyb20gb3V0 c2lkZSwKPiA+ID4gPiA+IG5ldCwgY29uc29sZSwgaW5wdXQgZXRjLiBJJ3ZlIGRvbmUgYSByb3Vu ZCBvZiBhdWRpdHMgb2YgdGhlIFFlbXUKPiA+ID4gPiA+IGNvZGVzLiBUaGV5IGxvb2sgYWxsIGZp bmUgc2luY2UgZGF5MC4KPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFNvIHdpdGggdGhpcyBhcHByb2Fj aCwgaG93IGFib3V0IHdlIHJlbmFtZSB0aGUgZmxhZyAiZHJpdmVyX29rIj8KPiA+ID4gPiA+ID4g QW5kIHRoZW4gYWRkX2J1ZiBjYW4gYWN0dWFsbHkgdGVzdCBpdCBhbmQgQlVHX09OIGlmIG5vdCB0 aGVyZSAgKGF0IGxlYXN0Cj4gPiA+ID4gPiA+IGluIHRoZSBkZWJ1ZyBidWlsZCkuCj4gPiA+ID4g Pgo+ID4gPiA+ID4gVGhpcyBsb29rcyBsaWtlIGEgaGFyZGVuaW5nIG9mIHRoZSBkcml2ZXIgaW4g dGhlIGNvcmUgaW5zdGVhZCBvZiB0aGUKPiA+ID4gPiA+IGRldmljZS4gSSB0aGluayBpdCBjYW4g YmUgZG9uZSBidXQgaW4gYSBzZXBhcmF0ZSBzZXJpZXMuCj4gPiA+ID4gPgo+ID4gPiA+ID4gPgo+ ID4gPiA+ID4gPiBBbmQgZ29pbmcgZG93biBmcm9tIHRoZXJlLCBob3cgYWJvdXQgd2UgY2FjaGUg c3RhdHVzIGluIHRoZQo+ID4gPiA+ID4gPiBkZXZpY2U/IFRoZW4gd2UgZG9uJ3QgbmVlZCB0byBr ZWVwIHJlLXJlYWRpbmcgaXQgZXZlcnkgdGltZSwKPiA+ID4gPiA+ID4gc3BlZWRpbmcgYm9vdCB1 cCBhIHRpbnkgYml0Lgo+ID4gPiA+ID4KPiA+ID4gPiA+IEkgZG9uJ3QgZnVsbHkgdW5kZXJzdGFu ZCBoZXJlLCBhY3R1YWxseSBzcGVjIHJlcXVpcmVzIHN0YXR1cyB0byBiZQo+ID4gPiA+ID4gcmVh ZCBiYWNrIGZvciB2YWxpZGF0aW9uIGluIG1hbnkgY2FzZXMuCj4gPiA+ID4gPgo+ID4gPiA+ID4g VGhhbmtzCj4gPiA+ID4gPgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4g Pgo+ID4gPiA+ID4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX3Jp bmcuYyBiL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPiA+ID4gPiA+ID4gPiA+ID4gaW5k ZXggOTYyZjE0NzdiMWZhLi4wMTcwZjhjNzg0ZDggMTAwNjQ0Cj4gPiA+ID4gPiA+ID4gPiA+IC0t LSBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPiA+ID4gPiA+ID4gPiA+ID4gKysrIGIv ZHJpdmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYwo+ID4gPiA+ID4gPiA+ID4gPiBAQCAtMjE0NCwx MCArMjE0NCwxNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgbW9yZV91c2VkKGNvbnN0IHN0cnVjdCB2 cmluZ192aXJ0cXVldWUgKnZxKQo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgcmV0dXJuIHZx LT5wYWNrZWRfcmluZyA/IG1vcmVfdXNlZF9wYWNrZWQodnEpIDogbW9yZV91c2VkX3NwbGl0KHZx KTsKPiA+ID4gPiA+ID4gPiA+ID4gICB9Cj4gPiA+ID4gPiA+ID4gPiA+IC1pcnFyZXR1cm5fdCB2 cmluZ19pbnRlcnJ1cHQoaW50IGlycSwgdm9pZCAqX3ZxKQo+ID4gPiA+ID4gPiA+ID4gPiAraXJx cmV0dXJuX3QgdnJpbmdfaW50ZXJydXB0KGludCBpcnEsIHZvaWQgKnYpCj4gPiA+ID4gPiA+ID4g PiA+ICAgewo+ID4gPiA+ID4gPiA+ID4gPiArIHN0cnVjdCB2aXJ0cXVldWUgKl92cSA9IHY7Cj4g PiA+ID4gPiA+ID4gPiA+ICsgc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYgPSBfdnEtPnZkZXY7 Cj4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICBzdHJ1Y3QgdnJpbmdfdmlydHF1ZXVlICp2cSA9 IHRvX3Z2cShfdnEpOwo+ID4gPiA+ID4gPiA+ID4gPiArIGlmICghdmlydGlvX2lycV9zb2Z0X2Vu YWJsZWQodmRldikpIHsKPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgIGRldl93YXJuX29uY2Uo JnZkZXYtPmRldiwgInZpcnRpbyB2cmluZyBJUlEgcmFpc2VkIGJlZm9yZSBEUklWRVJfT0siKTsK PiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgIHJldHVybiBJUlFfTk9ORTsKPiA+ID4gPiA+ID4g PiA+ID4gKyB9Cj4gPiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAg IGlmICghbW9yZV91c2VkKHZxKSkgewo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAg ICBwcl9kZWJ1ZygidmlydHF1ZXVlIGludGVycnVwdCB3aXRoIG5vIHdvcmsgZm9yICVwXG4iLCB2 cSk7Cj4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICAgICAgICAgIHJldHVybiBJUlFfTk9ORTsK PiA+ID4gPiA+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvdmlydGlvLmggYi9p bmNsdWRlL2xpbnV4L3ZpcnRpby5oCj4gPiA+ID4gPiA+ID4gPiA+IGluZGV4IDU0NjRmMzk4OTEy YS4uOTU3ZDZhZDYwNGFjIDEwMDY0NAo+ID4gPiA+ID4gPiA+ID4gPiAtLS0gYS9pbmNsdWRlL2xp bnV4L3ZpcnRpby5oCj4gPiA+ID4gPiA+ID4gPiA+ICsrKyBiL2luY2x1ZGUvbGludXgvdmlydGlv LmgKPiA+ID4gPiA+ID4gPiA+ID4gQEAgLTk1LDYgKzk1LDggQEAgZG1hX2FkZHJfdCB2aXJ0cXVl dWVfZ2V0X3VzZWRfYWRkcihzdHJ1Y3QgdmlydHF1ZXVlICp2cSk7Cj4gPiA+ID4gPiA+ID4gPiA+ ICAgICogQGZhaWxlZDogc2F2ZWQgdmFsdWUgZm9yIFZJUlRJT19DT05GSUdfU19GQUlMRUQgYml0 IChmb3IgcmVzdG9yZSkKPiA+ID4gPiA+ID4gPiA+ID4gICAgKiBAY29uZmlnX2VuYWJsZWQ6IGNv bmZpZ3VyYXRpb24gY2hhbmdlIHJlcG9ydGluZyBlbmFibGVkCj4gPiA+ID4gPiA+ID4gPiA+ICAg ICogQGNvbmZpZ19jaGFuZ2VfcGVuZGluZzogY29uZmlndXJhdGlvbiBjaGFuZ2UgcmVwb3J0ZWQg d2hpbGUgZGlzYWJsZWQKPiA+ID4gPiA+ID4gPiA+ID4gKyAqIEBpcnFfc29mdF9jaGVjazogd2hl dGhlciBvciBub3QgdG8gY2hlY2sgQGlycV9zb2Z0X2VuYWJsZWQKPiA+ID4gPiA+ID4gPiA+ID4g KyAqIEBpcnFfc29mdF9lbmFibGVkOiBjYWxsYmFja3MgZW5hYmxlZAo+ID4gPiA+ID4gPiA+ID4g PiAgICAqIEBjb25maWdfbG9jazogcHJvdGVjdHMgY29uZmlndXJhdGlvbiBjaGFuZ2UgcmVwb3J0 aW5nCj4gPiA+ID4gPiA+ID4gPiA+ICAgICogQGRldjogdW5kZXJseWluZyBkZXZpY2UuCj4gPiA+ ID4gPiA+ID4gPiA+ICAgICogQGlkOiB0aGUgZGV2aWNlIHR5cGUgaWRlbnRpZmljYXRpb24gKHVz ZWQgdG8gbWF0Y2ggaXQgd2l0aCBhIGRyaXZlcikuCj4gPiA+ID4gPiA+ID4gPiA+IEBAIC0xMDks NiArMTExLDggQEAgc3RydWN0IHZpcnRpb19kZXZpY2Ugewo+ID4gPiA+ID4gPiA+ID4gPiAgICAg ICAgICAgYm9vbCBmYWlsZWQ7Cj4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICBib29sIGNvbmZp Z19lbmFibGVkOwo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgYm9vbCBjb25maWdfY2hhbmdl X3BlbmRpbmc7Cj4gPiA+ID4gPiA+ID4gPiA+ICsgYm9vbCBpcnFfc29mdF9jaGVjazsKPiA+ID4g PiA+ID4gPiA+ID4gKyBib29sIGlycV9zb2Z0X2VuYWJsZWQ7Cj4gPiA+ID4gPiA+ID4gPiA+ICAg ICAgICAgICBzcGlubG9ja190IGNvbmZpZ19sb2NrOwo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAg ICAgc3BpbmxvY2tfdCB2cXNfbGlzdF9sb2NrOyAvKiBQcm90ZWN0cyBWUXMgbGlzdCBhY2Nlc3Mg Ki8KPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgIHN0cnVjdCBkZXZpY2UgZGV2Owo+ID4gPiA+ ID4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmggYi9p bmNsdWRlL2xpbnV4L3ZpcnRpb19jb25maWcuaAo+ID4gPiA+ID4gPiA+ID4gPiBpbmRleCBkYWZk YzdmNDhjMDEuLjljMWI2MWYyZTUyNSAxMDA2NDQKPiA+ID4gPiA+ID4gPiA+ID4gLS0tIGEvaW5j bHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmgKPiA+ID4gPiA+ID4gPiA+ID4gKysrIGIvaW5jbHVk ZS9saW51eC92aXJ0aW9fY29uZmlnLmgKPiA+ID4gPiA+ID4gPiA+ID4gQEAgLTE3NCw2ICsxNzQs MjQgQEAgc3RhdGljIGlubGluZSBib29sIHZpcnRpb19oYXNfZmVhdHVyZShjb25zdCBzdHJ1Y3Qg dmlydGlvX2RldmljZSAqdmRldiwKPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgIHJldHVybiBf X3ZpcnRpb190ZXN0X2JpdCh2ZGV2LCBmYml0KTsKPiA+ID4gPiA+ID4gPiA+ID4gICB9Cj4gPiA+ ID4gPiA+ID4gPiA+ICsvKgo+ID4gPiA+ID4gPiA+ID4gPiArICogdmlydGlvX2lycV9zb2Z0X2Vu YWJsZWQ6IHdoZXRoZXIgd2UgY2FuIGV4ZWN1dGUgY2FsbGJhY2tzCj4gPiA+ID4gPiA+ID4gPiA+ ICsgKiBAdmRldjogdGhlIGRldmljZQo+ID4gPiA+ID4gPiA+ID4gPiArICovCj4gPiA+ID4gPiA+ ID4gPiA+ICtzdGF0aWMgaW5saW5lIGJvb2wgdmlydGlvX2lycV9zb2Z0X2VuYWJsZWQoY29uc3Qg c3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYpCj4gPiA+ID4gPiA+ID4gPiA+ICt7Cj4gPiA+ID4g PiA+ID4gPiA+ICsgaWYgKCF2ZGV2LT5pcnFfc29mdF9jaGVjaykKPiA+ID4gPiA+ID4gPiA+ID4g KyAgICAgICAgIHJldHVybiB0cnVlOwo+ID4gPiA+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ID4g PiA+ICsgLyoKPiA+ID4gPiA+ID4gPiA+ID4gKyAgKiBSZWFkIGlycV9zb2Z0X2VuYWJsZWQgYmVm b3JlIHJlYWRpbmcgb3RoZXIgZGV2aWNlIHNwZWNpZmljCj4gPiA+ID4gPiA+ID4gPiA+ICsgICog ZGF0YS4gUGFyaWVkIHdpdGggc21wX3N0b3JlX3JlbGFzZSgpIGluCj4gPiA+ID4gPiA+ID4gPiBw YWlyZWQKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gV2lsbCBmaXgu Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBUaGFua3MKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiArICAqIHZpcnRpb19kZXZp Y2VfcmVhZHkoKSBhbmQgV1JJVEVfT05DRSgpL3N5bmNocm9uaXplX3JjdSgpIGluCj4gPiA+ID4g PiA+ID4gPiA+ICsgICogdmlydGlvX3Jlc2V0X2RldmljZSgpLgo+ID4gPiA+ID4gPiA+ID4gPiAr ICAqLwo+ID4gPiA+ID4gPiA+ID4gPiArIHJldHVybiBzbXBfbG9hZF9hY3F1aXJlKCZ2ZGV2LT5p cnFfc29mdF9lbmFibGVkKTsKPiA+ID4gPiA+ID4gPiA+ID4gK30KPiA+ID4gPiA+ID4gPiA+ID4g Kwo+ID4gPiA+ID4gPiA+ID4gPiAgIC8qKgo+ID4gPiA+ID4gPiA+ID4gPiAgICAqIHZpcnRpb19o YXNfZG1hX3F1aXJrIC0gZGV0ZXJtaW5lIHdoZXRoZXIgdGhpcyBkZXZpY2UgaGFzIHRoZSBETUEg cXVpcmsKPiA+ID4gPiA+ID4gPiA+ID4gICAgKiBAdmRldjogdGhlIGRldmljZQo+ID4gPiA+ID4g PiA+ID4gPiBAQCAtMjM2LDYgKzI1NCwxMyBAQCB2b2lkIHZpcnRpb19kZXZpY2VfcmVhZHkoc3Ry dWN0IHZpcnRpb19kZXZpY2UgKmRldikKPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgIGlmIChk ZXYtPmNvbmZpZy0+ZW5hYmxlX2NicykKPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgICAgICAg ICAgICBkZXYtPmNvbmZpZy0+ZW5hYmxlX2NicyhkZXYpOwo+ID4gPiA+ID4gPiA+ID4gPiArIC8q Cj4gPiA+ID4gPiA+ID4gPiA+ICsgICogQ29tbWl0IHRoZSBkcml2ZXIgc2V0dXAgYmVmb3JlIGVu YWJsaW5nIHRoZSB2aXJ0cXVldWUKPiA+ID4gPiA+ID4gPiA+ID4gKyAgKiBjYWxsYmFja3MuIFBh cmllZCB3aXRoIHNtcF9sb2FkX2FjdXFpcmUoKSBpbgo+ID4gPiA+ID4gPiA+ID4gPiArICAqIHZp cnRpb19pcnFfc29mdF9lbmFibGVkKCkKPiA+ID4gPiA+ID4gPiA+ID4gKyAgKi8KPiA+ID4gPiA+ ID4gPiA+ID4gKyBzbXBfc3RvcmVfcmVsZWFzZSgmZGV2LT5pcnFfc29mdF9lbmFibGVkLCB0cnVl KTsKPiA+ID4gPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgQlVHX09O KHN0YXR1cyAmIFZJUlRJT19DT05GSUdfU19EUklWRVJfT0spOwo+ID4gPiA+ID4gPiA+ID4gPiAg ICAgICAgICAgZGV2LT5jb25maWctPnNldF9zdGF0dXMoZGV2LCBzdGF0dXMgfCBWSVJUSU9fQ09O RklHX1NfRFJJVkVSX09LKTsKPiA+ID4gPiA+ID4gPiA+ID4gICB9Cj4gPiA+ID4gPiA+ID4gPiA+ IC0tCj4gPiA+ID4gPiA+ID4gPiA+IDIuMjUuMQo+ID4gPiA+ID4gPgo+ID4gPiA+Cj4gPgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRp b24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3Jn Cmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1 YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E99EC433F5 for ; Mon, 28 Mar 2022 05:59:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238214AbiC1GBF (ORCPT ); Mon, 28 Mar 2022 02:01:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238209AbiC1GBB (ORCPT ); Mon, 28 Mar 2022 02:01:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B04043B297 for ; Sun, 27 Mar 2022 22:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648447155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FoH2TxNvMBERPcymekYDG3tnAiKwdZ/6n9Yxb48a3UI=; b=gaVU7wEEp0XFn9bbY4qDIkXvOpDkeVXt9ytgtPtGJASKLtAQXqgtkoaqcSMvzC+XHYZa0J 0d5QkcoWx3AL+G/hmNmPc57Y14w+6Szo5Rvjt6adhzP31LivJuGEezUM2gwyF/oP5JLqhg TJzPEhTio75D2byRsRY73z+VpTYdxvM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-326-uOFtpeoQNsqLLFkWc1vWaA-1; Mon, 28 Mar 2022 01:59:13 -0400 X-MC-Unique: uOFtpeoQNsqLLFkWc1vWaA-1 Received: by mail-wm1-f71.google.com with SMTP id i65-20020a1c3b44000000b00385c3f3defaso5035931wma.3 for ; Sun, 27 Mar 2022 22:59:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FoH2TxNvMBERPcymekYDG3tnAiKwdZ/6n9Yxb48a3UI=; b=54q9+e+ZFIzb93iQUqZrDTXigWv+BnwXKAyhdafyDSNJl6q+3XzK1m/VRtmYHzdDs5 s9XmrgXfvQt78HKgrAnFY8IHOzxYjxb+Ol8JsMjCvus2PeDIja4/ogcPxITpn8C6rSHK WedebmH/3bu0GeYmG6QPZ4GhOOx7rEHDXIQbMq0EQLmNFXEiItMJS7SKh22V82238Ufb AkAdrbKogztaZvi4cekWWpNsPc5G4S0bnZIrRXH5NQCeie9ZbFahYBxmqkd8vE3Oc475 SecEt6ZfUJaSVDOBZvfgbAedFiEhQSBeayT2/VW8f19G09BdCYEfBryn/3a9nW9SG48M xJhQ== X-Gm-Message-State: AOAM532KEk5YmfNK1F75gvAWih9xNMu2oLMAh6vvD+nZofautj8Btu2E 93mnZZGqDkd0mOAir+szQo7tQOkd45m7xeEyftM2fPLhVW8MWDDafrHUkNWt30jUvL4vZxABA9i 0zDfTg9LtrlZVt37VVry2GInM X-Received: by 2002:a5d:4804:0:b0:203:d59b:e83 with SMTP id l4-20020a5d4804000000b00203d59b0e83mr21622132wrq.696.1648447152376; Sun, 27 Mar 2022 22:59:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylIOn6hAS0Hrn2rM3DATefEAYnB0ddwSQcNCwnzsZIRwqhNfxJOurYduAh2P+uvsSbnSR7Ww== X-Received: by 2002:a5d:4804:0:b0:203:d59b:e83 with SMTP id l4-20020a5d4804000000b00203d59b0e83mr21622102wrq.696.1648447151985; Sun, 27 Mar 2022 22:59:11 -0700 (PDT) Received: from redhat.com ([2.52.9.207]) by smtp.gmail.com with ESMTPSA id v5-20020adfe4c5000000b001edc1e5053esm10991393wrm.82.2022.03.27.22.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Mar 2022 22:59:11 -0700 (PDT) Date: Mon, 28 Mar 2022 01:59:07 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: virtualization , linux-kernel , Marc Zyngier , Thomas Gleixner , Peter Zijlstra , Stefano Garzarella , Keir Fraser , "Paul E. McKenney" Subject: Re: Message-ID: <20220328015757-mutt-send-email-mst@kernel.org> References: <20220325050947-mutt-send-email-mst@kernel.org> <20220325060659-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 28, 2022 at 12:56:41PM +0800, Jason Wang wrote: > On Fri, Mar 25, 2022 at 6:10 PM Michael S. Tsirkin wrote: > > > > On Fri, Mar 25, 2022 at 05:20:19PM +0800, Jason Wang wrote: > > > On Fri, Mar 25, 2022 at 5:10 PM Michael S. Tsirkin wrote: > > > > > > > > On Fri, Mar 25, 2022 at 03:52:00PM +0800, Jason Wang wrote: > > > > > On Fri, Mar 25, 2022 at 2:31 PM Michael S. Tsirkin wrote: > > > > > > > > > > > > Bcc: > > > > > > Subject: Re: [PATCH 3/3] virtio: harden vring IRQ > > > > > > Message-ID: <20220325021422-mutt-send-email-mst@kernel.org> > > > > > > Reply-To: > > > > > > In-Reply-To: > > > > > > > > > > > > On Fri, Mar 25, 2022 at 11:04:08AM +0800, Jason Wang wrote: > > > > > > > > > > > > > > 在 2022/3/24 下午7:03, Michael S. Tsirkin 写道: > > > > > > > > On Thu, Mar 24, 2022 at 04:40:04PM +0800, Jason Wang wrote: > > > > > > > > > This is a rework on the previous IRQ hardening that is done for > > > > > > > > > virtio-pci where several drawbacks were found and were reverted: > > > > > > > > > > > > > > > > > > 1) try to use IRQF_NO_AUTOEN which is not friendly to affinity managed IRQ > > > > > > > > > that is used by some device such as virtio-blk > > > > > > > > > 2) done only for PCI transport > > > > > > > > > > > > > > > > > > In this patch, we tries to borrow the idea from the INTX IRQ hardening > > > > > > > > > in the reverted commit 080cd7c3ac87 ("virtio-pci: harden INTX interrupts") > > > > > > > > > by introducing a global irq_soft_enabled variable for each > > > > > > > > > virtio_device. Then we can to toggle it during > > > > > > > > > virtio_reset_device()/virtio_device_ready(). A synchornize_rcu() is > > > > > > > > > used in virtio_reset_device() to synchronize with the IRQ handlers. In > > > > > > > > > the future, we may provide config_ops for the transport that doesn't > > > > > > > > > use IRQ. With this, vring_interrupt() can return check and early if > > > > > > > > > irq_soft_enabled is false. This lead to smp_load_acquire() to be used > > > > > > > > > but the cost should be acceptable. > > > > > > > > Maybe it should be but is it? Can't we use synchronize_irq instead? > > > > > > > > > > > > > > > > > > > > > Even if we allow the transport driver to synchornize through > > > > > > > synchronize_irq() we still need a check in the vring_interrupt(). > > > > > > > > > > > > > > We do something like the following previously: > > > > > > > > > > > > > > if (!READ_ONCE(vp_dev->intx_soft_enabled)) > > > > > > > return IRQ_NONE; > > > > > > > > > > > > > > But it looks like a bug since speculative read can be done before the check > > > > > > > where the interrupt handler can't see the uncommitted setup which is done by > > > > > > > the driver. > > > > > > > > > > > > I don't think so - if you sync after setting the value then > > > > > > you are guaranteed that any handler running afterwards > > > > > > will see the new value. > > > > > > > > > > The problem is not disabled but the enable. > > > > > > > > So a misbehaving device can lose interrupts? That's not a problem at all > > > > imo. > > > > > > It's the interrupt raised before setting irq_soft_enabled to true: > > > > > > CPU 0 probe) driver specific setup (not commited) > > > CPU 1 IRQ handler) read the uninitialized variable > > > CPU 0 probe) set irq_soft_enabled to true > > > CPU 1 IRQ handler) read irq_soft_enable as true > > > CPU 1 IRQ handler) use the uninitialized variable > > > > > > Thanks > > > > Yea, it hurts if you do it. So do not do it then ;). > > > > irq_soft_enabled (I think driver_ok or status is a better name) > > I can change it to driver_ok. > > > should be initialized to false *before* irq is requested. > > > > And requesting irq commits all memory otherwise all drivers would be > > broken, > > So I think we might talk different issues: > > 1) Whether request_irq() commits the previous setups, I think the > answer is yes, since the spin_unlock of desc->lock (release) can > guarantee this though there seems no documentation around > request_irq() to say this. > > And I can see at least drivers/video/fbdev/omap2/omapfb/dss/dispc.c is > using smp_wmb() before the request_irq(). > > And even if write is ordered we still need read to be ordered to be > paired with that. > > > if it doesn't it just needs to be fixed, not worked around in > > virtio. > > 2) virtio drivers might do a lot of setups between request_irq() and > virtio_device_ready(): > > request_irq() > driver specific setups > virtio_device_ready() > > CPU 0 probe) request_irq() > CPU 1 IRQ handler) read the uninitialized variable > CPU 0 probe) driver specific setups > CPU 0 probe) smp_store_release(intr_soft_enabled, true), commit the setups > CPU 1 IRQ handler) read irq_soft_enable as true > CPU 1 IRQ handler) use the uninitialized variable > > Thanks As I said, virtio_device_ready needs to do synchronize_irq. That will guarantee all setup is visible to the specific IRQ, this is what it's point is. > > > > > > > > > > > > > We use smp_store_relase() > > > > > to make sure the driver commits the setup before enabling the irq. It > > > > > means the read needs to be ordered as well in vring_interrupt(). > > > > > > > > > > > > > > > > > Although I couldn't find anything about this in memory-barriers.txt > > > > > > which surprises me. > > > > > > > > > > > > CC Paul to help make sure I'm right. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > To avoid breaking legacy device which can send IRQ before DRIVER_OK, a > > > > > > > > > module parameter is introduced to enable the hardening so function > > > > > > > > > hardening is disabled by default. > > > > > > > > Which devices are these? How come they send an interrupt before there > > > > > > > > are any buffers in any queues? > > > > > > > > > > > > > > > > > > > > > I copied this from the commit log for 22b7050a024d7 > > > > > > > > > > > > > > " > > > > > > > > > > > > > > This change will also benefit old hypervisors (before 2009) > > > > > > > that send interrupts without checking DRIVER_OK: previously, > > > > > > > the callback could race with driver-specific initialization. > > > > > > > " > > > > > > > > > > > > > > If this is only for config interrupt, I can remove the above log. > > > > > > > > > > > > > > > > > > This is only for config interrupt. > > > > > > > > > > Ok. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Note that the hardening is only done for vring interrupt since the > > > > > > > > > config interrupt hardening is already done in commit 22b7050a024d7 > > > > > > > > > ("virtio: defer config changed notifications"). But the method that is > > > > > > > > > used by config interrupt can't be reused by the vring interrupt > > > > > > > > > handler because it uses spinlock to do the synchronization which is > > > > > > > > > expensive. > > > > > > > > > > > > > > > > > > Signed-off-by: Jason Wang > > > > > > > > > > > > > > > > > --- > > > > > > > > > drivers/virtio/virtio.c | 19 +++++++++++++++++++ > > > > > > > > > drivers/virtio/virtio_ring.c | 9 ++++++++- > > > > > > > > > include/linux/virtio.h | 4 ++++ > > > > > > > > > include/linux/virtio_config.h | 25 +++++++++++++++++++++++++ > > > > > > > > > 4 files changed, 56 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > > > > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c > > > > > > > > > index 8dde44ea044a..85e331efa9cc 100644 > > > > > > > > > --- a/drivers/virtio/virtio.c > > > > > > > > > +++ b/drivers/virtio/virtio.c > > > > > > > > > @@ -7,6 +7,12 @@ > > > > > > > > > #include > > > > > > > > > #include > > > > > > > > > +static bool irq_hardening = false; > > > > > > > > > + > > > > > > > > > +module_param(irq_hardening, bool, 0444); > > > > > > > > > +MODULE_PARM_DESC(irq_hardening, > > > > > > > > > + "Disalbe IRQ software processing when it is not expected"); > > > > > > > > > + > > > > > > > > > /* Unique numbering for virtio devices. */ > > > > > > > > > static DEFINE_IDA(virtio_index_ida); > > > > > > > > > @@ -220,6 +226,15 @@ static int virtio_features_ok(struct virtio_device *dev) > > > > > > > > > * */ > > > > > > > > > void virtio_reset_device(struct virtio_device *dev) > > > > > > > > > { > > > > > > > > > + /* > > > > > > > > > + * The below synchronize_rcu() guarantees that any > > > > > > > > > + * interrupt for this line arriving after > > > > > > > > > + * synchronize_rcu() has completed is guaranteed to see > > > > > > > > > + * irq_soft_enabled == false. > > > > > > > > News to me I did not know synchronize_rcu has anything to do > > > > > > > > with interrupts. Did not you intend to use synchronize_irq? > > > > > > > > I am not even 100% sure synchronize_rcu is by design a memory barrier > > > > > > > > though it's most likely is ... > > > > > > > > > > > > > > > > > > > > > According to the comment above tree RCU version of synchronize_rcu(): > > > > > > > > > > > > > > """ > > > > > > > > > > > > > > * RCU read-side critical sections are delimited by rcu_read_lock() > > > > > > > * and rcu_read_unlock(), and may be nested. In addition, but only in > > > > > > > * v5.0 and later, regions of code across which interrupts, preemption, > > > > > > > * or softirqs have been disabled also serve as RCU read-side critical > > > > > > > * sections. This includes hardware interrupt handlers, softirq handlers, > > > > > > > * and NMI handlers. > > > > > > > """ > > > > > > > > > > > > > > So interrupt handlers are treated as read-side critical sections. > > > > > > > > > > > > > > And it has the comment for explain the barrier: > > > > > > > > > > > > > > """ > > > > > > > > > > > > > > * Note that this guarantee implies further memory-ordering guarantees. > > > > > > > * On systems with more than one CPU, when synchronize_rcu() returns, > > > > > > > * each CPU is guaranteed to have executed a full memory barrier since > > > > > > > * the end of its last RCU read-side critical section whose beginning > > > > > > > * preceded the call to synchronize_rcu(). In addition, each CPU having > > > > > > > """ > > > > > > > > > > > > > > So on SMP it provides a full barrier. And for UP/tiny RCU we don't need the > > > > > > > barrier, if the interrupt come after WRITE_ONCE() it will see the > > > > > > > irq_soft_enabled as false. > > > > > > > > > > > > > > > > > > > You are right. So then > > > > > > 1. I do not think we need load_acquire - why is it needed? Just > > > > > > READ_ONCE should do. > > > > > > > > > > See above. > > > > > > > > > > > 2. isn't synchronize_irq also doing the same thing? > > > > > > > > > > > > > > > Yes, but it requires a config ops since the IRQ knowledge is transport specific. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + */ > > > > > > > > > + WRITE_ONCE(dev->irq_soft_enabled, false); > > > > > > > > > + synchronize_rcu(); > > > > > > > > > + > > > > > > > > > dev->config->reset(dev); > > > > > > > > > } > > > > > > > > > EXPORT_SYMBOL_GPL(virtio_reset_device); > > > > > > > > Please add comment explaining where it will be enabled. > > > > > > > > Also, we *really* don't need to synch if it was already disabled, > > > > > > > > let's not add useless overhead to the boot sequence. > > > > > > > > > > > > > > > > > > > > > Ok. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > @@ -427,6 +442,10 @@ int register_virtio_device(struct virtio_device *dev) > > > > > > > > > spin_lock_init(&dev->config_lock); > > > > > > > > > dev->config_enabled = false; > > > > > > > > > dev->config_change_pending = false; > > > > > > > > > + dev->irq_soft_check = irq_hardening; > > > > > > > > > + > > > > > > > > > + if (dev->irq_soft_check) > > > > > > > > > + dev_info(&dev->dev, "IRQ hardening is enabled\n"); > > > > > > > > > /* We always start by resetting the device, in case a previous > > > > > > > > > * driver messed it up. This also tests that code path a little. */ > > > > > > > > one of the points of hardening is it's also helpful for buggy > > > > > > > > devices. this flag defeats the purpose. > > > > > > > > > > > > > > > > > > > > > Do you mean: > > > > > > > > > > > > > > 1) we need something like config_enable? This seems not easy to be > > > > > > > implemented without obvious overhead, mainly the synchronize with the > > > > > > > interrupt handlers > > > > > > > > > > > > But synchronize is only on tear-down path. That is not critical for any > > > > > > users at the moment, even less than probe. > > > > > > > > > > I meant if we have vq->irq_pending, we need to call vring_interrupt() > > > > > in the virtio_device_ready() and synchronize the IRQ handlers with > > > > > spinlock or others. > > > > > > > > > > > > > > > > > > 2) enable this by default, so I don't object, but this may have some risk > > > > > > > for old hypervisors > > > > > > > > > > > > > > > > > > The risk if there's a driver adding buffers without setting DRIVER_OK. > > > > > > > > > > Probably not, we have devices that accept random inputs from outside, > > > > > net, console, input etc. I've done a round of audits of the Qemu > > > > > codes. They look all fine since day0. > > > > > > > > > > > So with this approach, how about we rename the flag "driver_ok"? > > > > > > And then add_buf can actually test it and BUG_ON if not there (at least > > > > > > in the debug build). > > > > > > > > > > This looks like a hardening of the driver in the core instead of the > > > > > device. I think it can be done but in a separate series. > > > > > > > > > > > > > > > > > And going down from there, how about we cache status in the > > > > > > device? Then we don't need to keep re-reading it every time, > > > > > > speeding boot up a tiny bit. > > > > > > > > > > I don't fully understand here, actually spec requires status to be > > > > > read back for validation in many cases. > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > > > > > > > > > index 962f1477b1fa..0170f8c784d8 100644 > > > > > > > > > --- a/drivers/virtio/virtio_ring.c > > > > > > > > > +++ b/drivers/virtio/virtio_ring.c > > > > > > > > > @@ -2144,10 +2144,17 @@ static inline bool more_used(const struct vring_virtqueue *vq) > > > > > > > > > return vq->packed_ring ? more_used_packed(vq) : more_used_split(vq); > > > > > > > > > } > > > > > > > > > -irqreturn_t vring_interrupt(int irq, void *_vq) > > > > > > > > > +irqreturn_t vring_interrupt(int irq, void *v) > > > > > > > > > { > > > > > > > > > + struct virtqueue *_vq = v; > > > > > > > > > + struct virtio_device *vdev = _vq->vdev; > > > > > > > > > struct vring_virtqueue *vq = to_vvq(_vq); > > > > > > > > > + if (!virtio_irq_soft_enabled(vdev)) { > > > > > > > > > + dev_warn_once(&vdev->dev, "virtio vring IRQ raised before DRIVER_OK"); > > > > > > > > > + return IRQ_NONE; > > > > > > > > > + } > > > > > > > > > + > > > > > > > > > if (!more_used(vq)) { > > > > > > > > > pr_debug("virtqueue interrupt with no work for %p\n", vq); > > > > > > > > > return IRQ_NONE; > > > > > > > > > diff --git a/include/linux/virtio.h b/include/linux/virtio.h > > > > > > > > > index 5464f398912a..957d6ad604ac 100644 > > > > > > > > > --- a/include/linux/virtio.h > > > > > > > > > +++ b/include/linux/virtio.h > > > > > > > > > @@ -95,6 +95,8 @@ dma_addr_t virtqueue_get_used_addr(struct virtqueue *vq); > > > > > > > > > * @failed: saved value for VIRTIO_CONFIG_S_FAILED bit (for restore) > > > > > > > > > * @config_enabled: configuration change reporting enabled > > > > > > > > > * @config_change_pending: configuration change reported while disabled > > > > > > > > > + * @irq_soft_check: whether or not to check @irq_soft_enabled > > > > > > > > > + * @irq_soft_enabled: callbacks enabled > > > > > > > > > * @config_lock: protects configuration change reporting > > > > > > > > > * @dev: underlying device. > > > > > > > > > * @id: the device type identification (used to match it with a driver). > > > > > > > > > @@ -109,6 +111,8 @@ struct virtio_device { > > > > > > > > > bool failed; > > > > > > > > > bool config_enabled; > > > > > > > > > bool config_change_pending; > > > > > > > > > + bool irq_soft_check; > > > > > > > > > + bool irq_soft_enabled; > > > > > > > > > spinlock_t config_lock; > > > > > > > > > spinlock_t vqs_list_lock; /* Protects VQs list access */ > > > > > > > > > struct device dev; > > > > > > > > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h > > > > > > > > > index dafdc7f48c01..9c1b61f2e525 100644 > > > > > > > > > --- a/include/linux/virtio_config.h > > > > > > > > > +++ b/include/linux/virtio_config.h > > > > > > > > > @@ -174,6 +174,24 @@ static inline bool virtio_has_feature(const struct virtio_device *vdev, > > > > > > > > > return __virtio_test_bit(vdev, fbit); > > > > > > > > > } > > > > > > > > > +/* > > > > > > > > > + * virtio_irq_soft_enabled: whether we can execute callbacks > > > > > > > > > + * @vdev: the device > > > > > > > > > + */ > > > > > > > > > +static inline bool virtio_irq_soft_enabled(const struct virtio_device *vdev) > > > > > > > > > +{ > > > > > > > > > + if (!vdev->irq_soft_check) > > > > > > > > > + return true; > > > > > > > > > + > > > > > > > > > + /* > > > > > > > > > + * Read irq_soft_enabled before reading other device specific > > > > > > > > > + * data. Paried with smp_store_relase() in > > > > > > > > paired > > > > > > > > > > > > > > > > > > > > > Will fix. > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + * virtio_device_ready() and WRITE_ONCE()/synchronize_rcu() in > > > > > > > > > + * virtio_reset_device(). > > > > > > > > > + */ > > > > > > > > > + return smp_load_acquire(&vdev->irq_soft_enabled); > > > > > > > > > +} > > > > > > > > > + > > > > > > > > > /** > > > > > > > > > * virtio_has_dma_quirk - determine whether this device has the DMA quirk > > > > > > > > > * @vdev: the device > > > > > > > > > @@ -236,6 +254,13 @@ void virtio_device_ready(struct virtio_device *dev) > > > > > > > > > if (dev->config->enable_cbs) > > > > > > > > > dev->config->enable_cbs(dev); > > > > > > > > > + /* > > > > > > > > > + * Commit the driver setup before enabling the virtqueue > > > > > > > > > + * callbacks. Paried with smp_load_acuqire() in > > > > > > > > > + * virtio_irq_soft_enabled() > > > > > > > > > + */ > > > > > > > > > + smp_store_release(&dev->irq_soft_enabled, true); > > > > > > > > > + > > > > > > > > > BUG_ON(status & VIRTIO_CONFIG_S_DRIVER_OK); > > > > > > > > > dev->config->set_status(dev, status | VIRTIO_CONFIG_S_DRIVER_OK); > > > > > > > > > } > > > > > > > > > -- > > > > > > > > > 2.25.1 > > > > > > > > > > > >