From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF4ECC433F5 for ; Mon, 28 Mar 2022 20:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344440AbiC1UWH (ORCPT ); Mon, 28 Mar 2022 16:22:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344410AbiC1UWA (ORCPT ); Mon, 28 Mar 2022 16:22:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06B4740E4D; Mon, 28 Mar 2022 13:20:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AAD83B81204; Mon, 28 Mar 2022 20:20:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF991C340F0; Mon, 28 Mar 2022 20:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648498816; bh=DYKSgCLyLSG5eVAyXEXBJzv5wUb4KbwLHueX4TuM2es=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nccR77DmMt5fnc/o6gzPVyT3/n47SLxU5yK+UpwKdHx+DMcaLuX/6OketRHPbmZK4 q8cXPhOeS5U/lTt4ZBRJMWdOApW5jbpoUqhxVh/BedGBZMTMV5wkH3BtP7s6iGDW7Q y0QdQapyEyF3Bt/RYtFN3DcVWfO6ymXfIwUMVbM0YopTHxL2aIt7JhbD6dj4ejWOxW pc+m/7ZMIf0Ie62Bdb6sgKnlk4iE+Z9kmM5yyWzogfPqXEglCECce8tPm4qxiKW+nA n66IatdJU8T97URqDPNt56LnxyLR99fOCTtEa0OoWadqYlrX2oFEX/OYDMGmH5+pqh E51HpRAN1M85Q== Date: Mon, 28 Mar 2022 13:20:14 -0700 From: Jakub Kicinski To: Benjamin =?UTF-8?B?U3TDvHJ6?= Cc: Kalle Valo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 00/22] Replace comments with C99 initializers Message-ID: <20220328132014.6b8c0a21@kernel.org> In-Reply-To: References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> <87fsn2zaix.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, 28 Mar 2022 13:51:42 +0200 Benjamin St=C3=BCrz wrote: > > Just a small tip: If you are new, start with something small and learn > > from that. Don't do a controversial big patchset spanning multiple > > subsystems, that's the hard way to learn things. First submit one patch > > at a time to one subsystem and gain understanding of the process that > > way. >=20 > I actually thought this would be such simple thing. Do you know of any > good thing where to start? I already looked into drivers/staging/*/TODO > and didn't found something for me personally. FWIW on the netdev side there's work coming to convert a set of features from unsigned long to a BITMAP which will require converting a lot of drivers to an explicit helpers from direct access. https://lore.kernel.org/all/20220324154932.17557-14-shenjian15@huawei.com/ If it seems interesting enough you can try reaching out to Jian Shen. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Date: Mon, 28 Mar 2022 20:20:14 +0000 Subject: Re: [PATCH 00/22] Replace comments with C99 initializers Message-Id: <20220328132014.6b8c0a21@kernel.org> List-Id: References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> <87fsn2zaix.fsf@kernel.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Benjamin =?UTF-8?B?U3TDvHJ6?= Cc: Kalle Valo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org On Mon, 28 Mar 2022 13:51:42 +0200 Benjamin St=C3=BCrz wrote: > > Just a small tip: If you are new, start with something small and learn > > from that. Don't do a controversial big patchset spanning multiple > > subsystems, that's the hard way to learn things. First submit one patch > > at a time to one subsystem and gain understanding of the process that > > way. >=20 > I actually thought this would be such simple thing. Do you know of any > good thing where to start? I already looked into drivers/staging/*/TODO > and didn't found something for me personally. FWIW on the netdev side there's work coming to convert a set of features from unsigned long to a BITMAP which will require converting a lot of drivers to an explicit helpers from direct access. https://lore.kernel.org/all/20220324154932.17557-14-shenjian15@huawei.com/ If it seems interesting enough you can try reaching out to Jian Shen. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBC71C433EF for ; Mon, 28 Mar 2022 20:20:56 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KS3x33q0Pz3c2K for ; Tue, 29 Mar 2022 07:20:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=nccR77Dm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=kuba@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=nccR77Dm; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KS3wP1pRzz3c00 for ; Tue, 29 Mar 2022 07:20:21 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D57EFB81205; Mon, 28 Mar 2022 20:20:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF991C340F0; Mon, 28 Mar 2022 20:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648498816; bh=DYKSgCLyLSG5eVAyXEXBJzv5wUb4KbwLHueX4TuM2es=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nccR77DmMt5fnc/o6gzPVyT3/n47SLxU5yK+UpwKdHx+DMcaLuX/6OketRHPbmZK4 q8cXPhOeS5U/lTt4ZBRJMWdOApW5jbpoUqhxVh/BedGBZMTMV5wkH3BtP7s6iGDW7Q y0QdQapyEyF3Bt/RYtFN3DcVWfO6ymXfIwUMVbM0YopTHxL2aIt7JhbD6dj4ejWOxW pc+m/7ZMIf0Ie62Bdb6sgKnlk4iE+Z9kmM5yyWzogfPqXEglCECce8tPm4qxiKW+nA n66IatdJU8T97URqDPNt56LnxyLR99fOCTtEa0OoWadqYlrX2oFEX/OYDMGmH5+pqh E51HpRAN1M85Q== Date: Mon, 28 Mar 2022 13:20:14 -0700 From: Jakub Kicinski To: Benjamin =?UTF-8?B?U3TDvHJ6?= Subject: Re: [PATCH 00/22] Replace comments with C99 initializers Message-ID: <20220328132014.6b8c0a21@kernel.org> In-Reply-To: References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> <87fsn2zaix.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-media@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo , linux-atm-general@lists.sourceforge.net, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, wcn36xx@lists.infradead.org, linux-edac@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devel@acpica.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 28 Mar 2022 13:51:42 +0200 Benjamin St=C3=BCrz wrote: > > Just a small tip: If you are new, start with something small and learn > > from that. Don't do a controversial big patchset spanning multiple > > subsystems, that's the hard way to learn things. First submit one patch > > at a time to one subsystem and gain understanding of the process that > > way. >=20 > I actually thought this would be such simple thing. Do you know of any > good thing where to start? I already looked into drivers/staging/*/TODO > and didn't found something for me personally. FWIW on the netdev side there's work coming to convert a set of features from unsigned long to a BITMAP which will require converting a lot of drivers to an explicit helpers from direct access. https://lore.kernel.org/all/20220324154932.17557-14-shenjian15@huawei.com/ If it seems interesting enough you can try reaching out to Jian Shen. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFD0EC433EF for ; Mon, 28 Mar 2022 20:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dvAOFBM8LRxijEWf9TZM8+ySgQ8k0FFDUyCcahCuvkU=; b=foDPQn5JUOGVHr ZipdzcffyN4tTBFRrFRzoKd8edw3VNd+cCS6VrI0hr3J/uejlMFYc1w5ekeWCkjRZ8meR+OHUwrsr ZIjIfdQBwX4W36CCg/dCUm4Uj6lt/4G97xkNYSpNmYSThWYAk5FbeSJGaqOHawPt+D8MnteXJ0N7H YqAsGjmS1fda++zo+Ig97Zn5sQduzkjRevC98Fl/452NXJi0gl2num8WHhtx0n8oWAgmpU5lzadoc vQICvura22zERXZzHt5L8t25bKami4bkWbLEYoaI7Csn0medgm4UILYU2uBMND0NDHDC/vd7uOukS KvVC5IUR4jrVbY0WWoow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYvqf-00A2Mu-Vq; Mon, 28 Mar 2022 20:20:22 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYvqd-00A2MI-6G; Mon, 28 Mar 2022 20:20:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D57EFB81205; Mon, 28 Mar 2022 20:20:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF991C340F0; Mon, 28 Mar 2022 20:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648498816; bh=DYKSgCLyLSG5eVAyXEXBJzv5wUb4KbwLHueX4TuM2es=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nccR77DmMt5fnc/o6gzPVyT3/n47SLxU5yK+UpwKdHx+DMcaLuX/6OketRHPbmZK4 q8cXPhOeS5U/lTt4ZBRJMWdOApW5jbpoUqhxVh/BedGBZMTMV5wkH3BtP7s6iGDW7Q y0QdQapyEyF3Bt/RYtFN3DcVWfO6ymXfIwUMVbM0YopTHxL2aIt7JhbD6dj4ejWOxW pc+m/7ZMIf0Ie62Bdb6sgKnlk4iE+Z9kmM5yyWzogfPqXEglCECce8tPm4qxiKW+nA n66IatdJU8T97URqDPNt56LnxyLR99fOCTtEa0OoWadqYlrX2oFEX/OYDMGmH5+pqh E51HpRAN1M85Q== Date: Mon, 28 Mar 2022 13:20:14 -0700 From: Jakub Kicinski To: Benjamin =?UTF-8?B?U3TDvHJ6?= Cc: Kalle Valo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rdma@vger.kernel.org, linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-media@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 00/22] Replace comments with C99 initializers Message-ID: <20220328132014.6b8c0a21@kernel.org> In-Reply-To: References: <20220326165909.506926-1-benni@stuerz.xyz> <8f9271b6-0381-70a9-f0c2-595b2235866a@stuerz.xyz> <87fsn2zaix.fsf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_132019_398402_F87597DD X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyOCBNYXIgMjAyMiAxMzo1MTo0MiArMDIwMCBCZW5qYW1pbiBTdMO8cnogd3JvdGU6 Cj4gPiBKdXN0IGEgc21hbGwgdGlwOiBJZiB5b3UgYXJlIG5ldywgc3RhcnQgd2l0aCBzb21ldGhp bmcgc21hbGwgYW5kIGxlYXJuCj4gPiBmcm9tIHRoYXQuIERvbid0IGRvIGEgY29udHJvdmVyc2lh bCBiaWcgcGF0Y2hzZXQgc3Bhbm5pbmcgbXVsdGlwbGUKPiA+IHN1YnN5c3RlbXMsIHRoYXQncyB0 aGUgaGFyZCB3YXkgdG8gbGVhcm4gdGhpbmdzLiBGaXJzdCBzdWJtaXQgb25lIHBhdGNoCj4gPiBh dCBhIHRpbWUgdG8gb25lIHN1YnN5c3RlbSBhbmQgZ2FpbiB1bmRlcnN0YW5kaW5nIG9mIHRoZSBw cm9jZXNzIHRoYXQKPiA+IHdheS4KPiAKPiBJIGFjdHVhbGx5IHRob3VnaHQgdGhpcyB3b3VsZCBi ZSBzdWNoIHNpbXBsZSB0aGluZy4gRG8geW91IGtub3cgb2YgYW55Cj4gZ29vZCB0aGluZyB3aGVy ZSB0byBzdGFydD8gSSBhbHJlYWR5IGxvb2tlZCBpbnRvIGRyaXZlcnMvc3RhZ2luZy8qL1RPRE8K PiBhbmQgZGlkbid0IGZvdW5kIHNvbWV0aGluZyBmb3IgbWUgcGVyc29uYWxseS4KCkZXSVcgb24g dGhlIG5ldGRldiBzaWRlIHRoZXJlJ3Mgd29yayBjb21pbmcgdG8gY29udmVydCBhIHNldCBvZiBm ZWF0dXJlcwpmcm9tIHVuc2lnbmVkIGxvbmcgdG8gYSBCSVRNQVAgd2hpY2ggd2lsbCByZXF1aXJl IGNvbnZlcnRpbmcgYSBsb3Qgb2YKZHJpdmVycyB0byBhbiBleHBsaWNpdCBoZWxwZXJzIGZyb20g ZGlyZWN0IGFjY2Vzcy4KCmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDIyMDMyNDE1NDkz Mi4xNzU1Ny0xNC1zaGVuamlhbjE1QGh1YXdlaS5jb20vCgpJZiBpdCBzZWVtcyBpbnRlcmVzdGlu ZyBlbm91Z2ggeW91IGNhbiB0cnkgcmVhY2hpbmcgb3V0IHRvIEppYW4gU2hlbi4KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK