From: Dan Carpenter <dan.carpenter@oracle.com>
To: Harm Smits <harmsmitsdev@gmail.com>
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [question] Whats up with loading the GDT in startup_setup_env in x86_64?
Date: Mon, 28 Mar 2022 17:25:28 +0300 [thread overview]
Message-ID: <20220328142528.GQ12805@kadam> (raw)
In-Reply-To: <CAO64rh61eMd2ekWK-XmXpjNvRKVscdua=txEMF-fYp4qt+pp=w@mail.gmail.com>
On Mon, Mar 28, 2022 at 03:25:14PM +0200, Harm Smits wrote:
> After a bit more digging, I have figured out what's going on. The
> compiler optimization passes seem to turn the absolute addressing into
> relative addressing by means of %rip. Should I submit a patch to also
> wrap it in `fixup_pointer` to make it in line with all the other .data
> manipulation in `startup_64_load_idt` and `__startup_64`? This would
> also avoid it from completely relying on an optimization pass which
> might get changed in the future.
>
Your explanation sounds totally reasonable but I'm not a domain expert
for that. If you're sure and you've tested it, then send away. The
worst that can happen is that your patch is rejected but even that means
you learned something so there are only up sides. :)
regards,
dan carpenter
prev parent reply other threads:[~2022-03-28 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 15:35 [question] Whats up with loading the GDT in startup_setup_env in x86_64? Harm Smits
2022-03-28 13:17 ` Dan Carpenter
2022-03-28 13:25 ` Harm Smits
2022-03-28 14:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328142528.GQ12805@kadam \
--to=dan.carpenter@oracle.com \
--cc=harmsmitsdev@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.