From: Jason Gunthorpe <jgg@nvidia.com>
To: Shlomo Pongratz <shlomopongratz@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew.maier@eideticom.com, logang@deltatee.com,
bhelgaas@google.com
Subject: Re: [PATCH V2 1/1] Intel Sky Lake-E host root ports check.
Date: Mon, 28 Mar 2022 11:38:13 -0300 [thread overview]
Message-ID: <20220328143813.GT1342626@nvidia.com> (raw)
In-Reply-To: <20220328143536.20761-1-shlomop@pliops.com>
On Mon, Mar 28, 2022 at 05:35:36PM +0300, Shlomo Pongratz wrote:
> Hi Jason,
>
> Thank you for your comments I'll fix the spelling mistakes.
>
> You suggested to remove the port field and to ignore the slot number for root ports,
> and I understand the reasoning, but, from safety reasons, if we know that device 2030
> will always be found on slot 0 and 2032 for example will always be found on slot 2
> wouldn't it be prudent to compare the device number vs the port number,
> unless you believe that the BIOS/ACPI issue will be fixed.
I'm not sure that is guaranteed, it seems like a BIOS choice..
IMHO what we know is that if we see those devices then we are on a
Skylake-E already and we don't really need more checks.
Jason
prev parent reply other threads:[~2022-03-28 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 11:20 [PATCH V2 0/1] Intel Sky Lake-E host root ports check Shlomo Pongratz
2022-03-27 11:20 ` [PATCH V2 1/1] " Shlomo Pongratz
2022-03-28 11:37 ` Jason Gunthorpe
2022-03-28 14:35 ` Shlomo Pongratz
2022-03-28 14:38 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328143813.GT1342626@nvidia.com \
--to=jgg@nvidia.com \
--cc=andrew.maier@eideticom.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.