From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nYtc9-00032g-GD for mharc-grub-devel@gnu.org; Mon, 28 Mar 2022 13:57:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYtc7-00032X-Vc for grub-devel@gnu.org; Mon, 28 Mar 2022 13:57:12 -0400 Received: from [2607:f8b0:4864:20::72c] (port=36473 helo=mail-qk1-x72c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nYtc4-00082Q-Lp for grub-devel@gnu.org; Mon, 28 Mar 2022 13:57:11 -0400 Received: by mail-qk1-x72c.google.com with SMTP id v13so12069052qkv.3 for ; Mon, 28 Mar 2022 10:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6lW2zUU5sxFYVYxV2F9zsY0lMuc93OwkxA4TVhPv3Ns=; b=mD9exwmRzWbLJOXnH9WAQdjd6G3ebsn5krI1pttlHGZPwVle3+Ax3vcc1DbWhyicoJ 0OIIA0kzjsHjt/eoSwtXyxjBoAj/fbqaUWuCygtH/dbhbKc3CfAzkL1wp5rAA2ZRfsG0 uFuo2rS3sfB9jh9KqzYP8kLll1WDttHUIxMDoAJZbRYTRdweK6/bPggdeL0xUCek5OYK e1BdN4Nt5XiAgoQUhsJZvUZHLqYyekNvC6CQZsjqvHd7JD5oCJfgnh2nqpjiwm10b1tV K52375/ShBh63yIJLtH55PQl9WTs7UtyOrtpMAiBRBNI1yltB7j0MLMckJP3ow3xDGhH qbcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6lW2zUU5sxFYVYxV2F9zsY0lMuc93OwkxA4TVhPv3Ns=; b=LoGs2KzTwWbMFwcO5/gkK2BkqXS26c6Rrim+zQufVsqTFf4QGamC1dGg/OXPxXUOaj NyZXWQLmoXPDAYrHO/OSYrZvH8f+4EoSuCJWDr4JZKygsiH8oc2BgG8kOQstcS2thV0J umrsx8UYeqHvqE+KV4+qZd2dlPG16rWlOolq9/NtT2OVHLvz5YAPAngrWKqyHmm0s9Rf 4n8YqpHTWA30m1c0s/GWm7IMlbBonhoDtk3KLKTW6+8iEASOZtna2CTJoVIwfPFWoWxH nKtLc9p40/z7dMwVpBZ/O/3wNSMTMjD56u4aMBx4gLhQkbdGDio4zhPqNMo/vGJXdzlu Kung== X-Gm-Message-State: AOAM532Zd1gtnX1N2kdJW/9/3gOvVvEd0EA5Ba+pZkdkc9MBgt52G/tk oXahfyG6yaDq+stZ3hwku6CAq0rn/U7RBQ== X-Google-Smtp-Source: ABdhPJwMpb9Ltx2oUwt+pwtu0/bYAXOqVX1NmU6T4GK4X6EmCI7cDUfY/pVH6G4T7MbtrshsIVUmMw== X-Received: by 2002:a37:62d0:0:b0:67b:1209:afbd with SMTP id w199-20020a3762d0000000b0067b1209afbdmr16185766qkb.754.1648490227377; Mon, 28 Mar 2022 10:57:07 -0700 (PDT) Received: from localhost.localdomain ([199.58.83.10]) by smtp.gmail.com with ESMTPSA id f18-20020a05622a105200b002e1eb06ece3sm12799005qte.31.2022.03.28.10.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 10:57:06 -0700 (PDT) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Glenn Washburn , Robbie Harwood , Paul Menzel Subject: [PATCH v2] configure: Fix default -O2 being added when CFLAGS not set Date: Mon, 28 Mar 2022 12:56:22 -0500 Message-Id: <20220328175622.590617-1-development@efficientek.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::72c (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::72c; envelope-from=development@efficientek.com; helo=mail-qk1-x72c.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2022 17:57:12 -0000 Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS was defaulted to "" early in configure to prevent this. A recent commit ad9ccf660013c208077b1e983d6c824df25ed1cf ("configure: Fix various new autotools warnings") added AC_USE_SYSTEM_EXTENSIONS, which pulls in the autoconf CFLAGS check, before we default CFLAGS and thus setting the autoconf default for CFLAGS. Move the default setting of CFLAGS to before AC_USE_SYSTEM_EXTENSIONS so that autoconf will see CFLAGS as set and not give it a default. Signed-off-by: Glenn Washburn Reviewed-by: Robbie Harwood Tested-by: Paul Menzel --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 3ffbc7c57b..c1e50c9d75 100644 --- a/configure.ac +++ b/configure.ac @@ -36,12 +36,12 @@ dnl description of the relationships between them. AC_INIT([GRUB],[2.11],[bug-grub@gnu.org]) -AC_USE_SYSTEM_EXTENSIONS -AC_CONFIG_AUX_DIR([build-aux]) - # We don't want -g -O2 by default in CFLAGS : ${CFLAGS=""} +AC_USE_SYSTEM_EXTENSIONS +AC_CONFIG_AUX_DIR([build-aux]) + # Checks for build, host and target systems. AC_CANONICAL_BUILD AC_CANONICAL_HOST -- 2.27.0