From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B02C433F5 for ; Mon, 28 Mar 2022 22:39:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230058AbiC1WlC (ORCPT ); Mon, 28 Mar 2022 18:41:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbiC1WlC (ORCPT ); Mon, 28 Mar 2022 18:41:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2234A4A3FA for ; Mon, 28 Mar 2022 15:39:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8622A60A1C for ; Mon, 28 Mar 2022 22:39:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D66B3C340F0; Mon, 28 Mar 2022 22:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1648507158; bh=W/SLkzsshgkjW284boXwDS15iVq6c2batu9DF2Egd1M=; h=Date:To:From:Subject:From; b=NzSiqaH6yJgAVh+oCIDH5sAWgo7GJDdfI57RKIXlZvm5EUc0/TY8+qC9bhGtxodc3 wpts8WLYQob7JQzJklS/D9E5RyEqK4te5nuoVanuf6l+xXnlGri+ecgUUA/GdDJxS1 ytag2QS7bGGwa+jeSewqsK0aAUC/+i77326QzSZE= Date: Mon, 28 Mar 2022 15:39:18 -0700 To: mm-commits@vger.kernel.org, zwisler@kernel.org, xiyuyang19@fudan.edu.cn, willy@infradead.org, viro@zeniv.linux.org.uk, shy828301@gmail.com, rcampbell@nvidia.com, kirill.shutemov@linux.intel.com, jack@suse.cz, hughd@google.com, hch@lst.de, duanxiongchun@bytedance.com, dan.j.williams@intel.com, apopple@nvidia.com, akpm@linux-foundation.org, songmuchun@bytedance.com, akpm@linux-foundation.org From: Andrew Morton Subject: + mm-rmap-fix-cache-flush-on-thp-pages.patch added to -mm tree Message-Id: <20220328223918.D66B3C340F0@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: mm: rmap: fix cache flush on THP pages has been added to the -mm tree. Its filename is mm-rmap-fix-cache-flush-on-thp-pages.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/mm-rmap-fix-cache-flush-on-thp-pages.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/mm-rmap-fix-cache-flush-on-thp-pages.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Muchun Song Subject: mm: rmap: fix cache flush on THP pages Patch series "Fix some bugs related to ramp and dax", v5. Patch 1-2 fixes a cache flush bug, because subsequent patches depend on those on those changes, there are placed in this series. Patch 3-4 are preparation for fixing a dax bug in patch 5. Patch 6 is code cleanup since the previous patch remove the usage of follow_invalidate_pte(). This patch (of 6): flush_cache_page() only removes a PAGE_SIZE sized range from the cache. However, it does not cover the full pages in a THP except a head page. Replace it with flush_cache_range() to fix this issue. At least, no problems were found due to this. Maybe because the architectures that have virtual indexed caches is less. Link: https://lkml.kernel.org/r/20220318074529.5261-1-songmuchun@bytedance.com Link: https://lkml.kernel.org/r/20220318074529.5261-2-songmuchun@bytedance.com Fixes: f27176cfc363 ("mm: convert page_mkclean_one() to use page_vma_mapped_walk()") Signed-off-by: Muchun Song Reviewed-by: Yang Shi Reviewed-by: Dan Williams Reviewed-by: Christoph Hellwig Cc: Matthew Wilcox Cc: Jan Kara Cc: Al Viro Cc: Andrew Morton Cc: Alistair Popple Cc: Ralph Campbell Cc: Hugh Dickins Cc: Xiyu Yang Cc: "Kirill A. Shutemov" Cc: Ross Zwisler Cc: Xiongchun Duan Signed-off-by: Andrew Morton --- mm/rmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/mm/rmap.c~mm-rmap-fix-cache-flush-on-thp-pages +++ a/mm/rmap.c @@ -970,7 +970,8 @@ static bool page_mkclean_one(struct foli if (!pmd_dirty(*pmd) && !pmd_write(*pmd)) continue; - flush_cache_page(vma, address, folio_pfn(folio)); + flush_cache_range(vma, address, + address + HPAGE_PMD_SIZE); entry = pmdp_invalidate(vma, address, pmd); entry = pmd_wrprotect(entry); entry = pmd_mkclean(entry); _ Patches currently in -mm which might be from songmuchun@bytedance.com are mm-kfence-fix-objcgs-vector-allocation.patch mm-rmap-fix-cache-flush-on-thp-pages.patch dax-fix-cache-flush-on-pmd-mapped-pages.patch mm-rmap-introduce-pfn_mkclean_range-to-cleans-ptes.patch mm-pvmw-add-support-for-walking-devmap-pages.patch dax-fix-missing-writeprotect-the-pte-entry.patch mm-simplify-follow_invalidate_pte.patch