All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beau Belgrave <beaub@linux.microsoft.com>
To: mathieu.desnoyers@efficios.com
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-trace-devel@vger.kernel.org, rostedt@goodmis.org,
	beaub@linux.microsoft.com
Subject: Re: Comments on new user events ABI
Date: Mon, 28 Mar 2022 16:30:10 -0700	[thread overview]
Message-ID: <20220328233010.2636-1-beaub@linux.microsoft.com> (raw)
In-Reply-To: <1283359416.196715.1648499713041.JavaMail.zimbra@efficios.com>

> ----- On Mar 28, 2022, at 4:24 PM, Mathieu Desnoyers mathieu.desnoyers@efficios.com wrote:
> 
> > Hi Beau, Hi Steven,
> > 
> > I've done a review of the trace events ABI, and I have a few comments.
> > Sorry for being late to the party, but I only noticed this new ABI recently.
> > Hopefully we can improve this ABI before the 5.18 release.
> > 
> 
> Also a bit of testing shows that dyn_event_add() is called without holding the event_mutex.
> Has this been tested with lockdep ?

Sorry, looks like I've been running with LOCKDEP_SUPPORT without it on :(
I now have both CONFIG_LOCKDEP and CONFIG_LOCK_DEBUGGING_SUPPORT.

You are right about this, thanks! I've sent a patch.

Link: https://lore.kernel.org/all/20220328223225.1992-1-beaub@linux.microsoft.com/

Thanks,
-Beau

  reply	other threads:[~2022-03-28 23:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 20:24 Comments on new user events ABI Mathieu Desnoyers
2022-03-28 20:35 ` Mathieu Desnoyers
2022-03-28 23:30   ` Beau Belgrave [this message]
2022-03-29  0:29 ` Beau Belgrave
2022-03-29 16:17   ` Mathieu Desnoyers
2022-03-29 16:25     ` Alexei Starovoitov
2022-03-29 16:57       ` Beau Belgrave
2022-03-29 19:45       ` Steven Rostedt
2022-03-29 21:54     ` Beau Belgrave
2022-03-30  6:31       ` Masami Hiramatsu
2022-03-31 19:05       ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220328233010.2636-1-beaub@linux.microsoft.com \
    --to=beaub@linux.microsoft.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.