From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A99C433EF for ; Tue, 29 Mar 2022 01:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229447AbiC2BMx (ORCPT ); Mon, 28 Mar 2022 21:12:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbiC2BMw (ORCPT ); Mon, 28 Mar 2022 21:12:52 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5D8A31201 for ; Mon, 28 Mar 2022 18:11:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6921BB815A2 for ; Tue, 29 Mar 2022 01:11:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2AC5C340EC; Tue, 29 Mar 2022 01:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1648516266; bh=NXxgKM3IEZ2e0WrMkuOE3WhcUGBK1Rairv40rVzNgXM=; h=Date:To:From:Subject:From; b=fxFSNQr0vOAak8di6Zdl1TN2zdC9Tm3gr00pFVgUzTFMKwx0zMbf1K0AGVFs1wIPw OhdrAa/n2NN5ZQhF9ve8TeX8KelQcEZNEJHnsLeXL2CCEB/2nLqlnl7Nx7q6J7QJwF 0vGdyDzSWgDtabVJkeQS7dYlgjdEHVmTN1d5tCWw= Date: Mon, 28 Mar 2022 18:11:05 -0700 To: mm-commits@vger.kernel.org, vitaly.wool@konsulko.com, linmiaohe@huawei.com, akpm@linux-foundation.org From: Andrew Morton Subject: + mm-z3fold-remove-redundant-list_del_init-of-zhdr-buddy-in-z3fold_free.patch added to -mm tree Message-Id: <20220329011105.F2AC5C340EC@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: mm/z3fold: remove redundant list_del_init of zhdr->buddy in z3fold_free has been added to the -mm tree. Its filename is mm-z3fold-remove-redundant-list_del_init-of-zhdr-buddy-in-z3fold_free.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/mm-z3fold-remove-redundant-list_del_init-of-zhdr-buddy-in-z3fold_free.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/mm-z3fold-remove-redundant-list_del_init-of-zhdr-buddy-in-z3fold_free.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Miaohe Lin Subject: mm/z3fold: remove redundant list_del_init of zhdr->buddy in z3fold_free do_compact_page() will do list_del_init(&zhdr->buddy) for us. Remove this extra one to save some possible cpu cycles. Link: https://lkml.kernel.org/r/20220308134311.59086-8-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Reviewed-by: Vitaly Wool Signed-off-by: Andrew Morton --- mm/z3fold.c | 3 --- 1 file changed, 3 deletions(-) --- a/mm/z3fold.c~mm-z3fold-remove-redundant-list_del_init-of-zhdr-buddy-in-z3fold_free +++ a/mm/z3fold.c @@ -1244,9 +1244,6 @@ static void z3fold_free(struct z3fold_po return; } if (zhdr->cpu < 0 || !cpu_online(zhdr->cpu)) { - spin_lock(&pool->lock); - list_del_init(&zhdr->buddy); - spin_unlock(&pool->lock); zhdr->cpu = -1; kref_get(&zhdr->refcount); clear_bit(PAGE_CLAIMED, &page->private); _ Patches currently in -mm which might be from linmiaohe@huawei.com are mm-shmem-make-shmem_init-return-void.patch mm-memcg-remove-unneeded-nr_scanned.patch mm-mremap-use-helper-mlock_future_check.patch mm-mlock-fix-two-bugs-in-user_shm_lock.patch mm-z3fold-declare-z3fold_mount-with-__init.patch mm-z3fold-remove-obsolete-comment-in-z3fold_alloc.patch mm-z3fold-minor-clean-up-for-z3fold_free.patch mm-z3fold-remove-unneeded-page_mapcount_reset-and-clearpageprivate.patch mm-z3fold-remove-confusing-local-variable-l-reassignment.patch mm-z3fold-move-decrement-of-pool-pages_nr-into-__release_z3fold_page.patch mm-z3fold-remove-redundant-list_del_init-of-zhdr-buddy-in-z3fold_free.patch mm-z3fold-remove-unneeded-page_headless-check-in-free_handle.patch mm-compaction-use-helper-isolation_suitable.patch mm-migration-remove-unneeded-local-variable-mapping_locked.patch mm-migration-remove-unneeded-out-label.patch mm-migration-remove-unneeded-local-variable-page_lru.patch mm-migration-fix-the-confusing-pagetranshuge-check.patch mm-migration-use-helper-function-vma_lookup-in-add_page_for_migration.patch mm-migration-use-helper-macro-min-in-do_pages_stat.patch mm-migration-avoid-unneeded-nodemask_t-initialization.patch mm-migration-remove-some-duplicated-codes-in-migrate_pages.patch mm-migration-fix-potential-page-refcounts-leak-in-migrate_pages.patch mm-migration-fix-potential-invalid-node-access-for-reclaim-based-migration.patch mm-migration-fix-possible-do_pages_stat_array-racing-with-memory-offline.patch