From: "Darrick J. Wong" <djwong@kernel.org>
To: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"liuyd.fnst@fujitsu.com" <liuyd.fnst@fujitsu.com>
Subject: Re: [Question] About allocsp_calls not implemented
Date: Tue, 29 Mar 2022 13:14:21 -0700 [thread overview]
Message-ID: <20220329201421.GF27713@magnolia> (raw)
In-Reply-To: <20220329113521.56ks64wanu5kreur@zlang-mailbox>
On Tue, Mar 29, 2022 at 07:35:21PM +0800, Zorro Lang wrote:
> On Tue, Mar 29, 2022 at 09:59:02AM +0000, liuyd.fnst@fujitsu.com wrote:
> > Hi, all.
> >
> > We noticed below tests failed due to fsx issue introduced by a32fb1bb
> > fsx: add support for XFS_IOC_ALLOCSP.
> >
> > generic/075 generic/091 generic/112 generic/127 generic/263
> >
> > The log shows "do_allocsp: allocsp: Function not implemented".
>
> Hmm... Darrick, I think we'd better to disable IOC_ALLOCSP operation
> in fsx.c by default, and use another option to allow user to enable it
> if they need. Or use another option to disable it, leave -F for fallocate
> only.
>
> What do you think?
I'd remove ALLOCSP support from fsx entirely.
--D
> Thanks,
> Zorro
>
> >
> >
> > The error has been around for a while so I want to know whether upstream
> > has got this info. As of now, we revert cd99a499 and a32fb1bb to test.
> >
> > --
> > Best Regards.
> > Yiding Liu
>
next prev parent reply other threads:[~2022-03-29 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 9:59 [Question] About allocsp_calls not implemented liuyd.fnst
2022-03-29 11:35 ` Zorro Lang
2022-03-29 20:14 ` Darrick J. Wong [this message]
2022-03-30 4:57 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329201421.GF27713@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=liuyd.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.