All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <marek.behun@nic.cz>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>,
	Ramon Fried <rfried.dev@gmail.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	u-boot@lists.denx.de, Stefano Babic <sbabic@denx.de>,
	Fabio Estevam <festevam@gmail.com>,
	"NXP i . MX U-Boot Team" <uboot-imx@nxp.com>
Subject: Re: [PATCH 5/6] net: add MV88E61xx DSA driver
Date: Wed, 30 Mar 2022 01:22:23 +0200	[thread overview]
Message-ID: <20220330012223.71ea3812@thinkpad> (raw)
In-Reply-To: <20220329225240.1416-6-tharvey@gateworks.com>

On Tue, 29 Mar 2022 15:52:39 -0700
Tim Harvey <tharvey@gateworks.com> wrote:

> Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>

Is this final version that should be accepted?

The drivers seems to support not only 61xx, but 6xxx (6096, 6250, 6352,
...).

Also there are some commented lines, for example

> +//	u16 port_stat_link_mask;/* Bitmask for port link status bits */
> +//	u16 port_stat_dup_mask; /* Bitmask for port duplex status bits */
> +//	u8 port_stat_speed_width;/* Width of speed status bitfield */

What is their purpose?

Why is mv88e61xx_dsa_xmit() no-op?

Marek

  reply	other threads:[~2022-03-29 23:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 22:52 [PATCH 0/6] Add MV88E61xx DSA driver and use on gwventana Tim Harvey
2022-03-29 22:52 ` [PATCH 1/6] net: mdio-uclass: scan for dm mdio children on post-bind Tim Harvey
2022-04-01 19:40   ` Ramon Fried
2022-03-29 22:52 ` [PATCH 2/6] net: dsa: move cpu port probe to dsa_post_probe Tim Harvey
2022-04-01 19:40   ` Ramon Fried
2022-03-29 22:52 ` [PATCH 3/6] net: mdio-uclass: add wrappers for read/write/reset operations Tim Harvey
2022-03-29 22:52 ` [PATCH 4/6] net: fec: add support for DM_MDIO Tim Harvey
2022-03-31 17:01   ` Vladimir Oltean
2022-03-31 17:48     ` Tim Harvey
2022-03-31 19:36       ` Vladimir Oltean
2022-04-01 17:53         ` Tim Harvey
2022-04-01 19:14           ` Vladimir Oltean
2022-03-29 22:52 ` [PATCH 5/6] net: add MV88E61xx DSA driver Tim Harvey
2022-03-29 23:22   ` Marek Behún [this message]
2022-03-30 15:46     ` Tim Harvey
2022-03-31 10:30       ` Marek Behún
2022-04-01 20:24         ` Tim Harvey
2022-04-02 23:17           ` Vladimir Oltean
2022-04-07 20:33             ` Tim Harvey
2022-04-07 21:31               ` Vladimir Oltean
2022-04-07 23:03                 ` Tim Harvey
2022-04-08  0:26                   ` Marek Behún
2022-04-12 14:13   ` Vladimir Oltean
2022-04-14 21:30     ` Tim Harvey
2022-03-29 22:52 ` [PATCH 6/6] board: gw_ventana: enable MV88E61XX DSA support Tim Harvey
2022-03-30 16:01 ` [PATCH 0/6] Add MV88E61xx DSA driver and use on gwventana Tim Harvey
2022-03-31 20:47   ` Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220330012223.71ea3812@thinkpad \
    --to=marek.behun@nic.cz \
    --cc=festevam@gmail.com \
    --cc=joe.hershberger@ni.com \
    --cc=rfried.dev@gmail.com \
    --cc=sbabic@denx.de \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.