All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Charlie Sands <sandsch@northvilleschools.net>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
	phil@philpotter.co.uk, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix sparse endianness warnings.
Date: Wed, 30 Mar 2022 10:11:00 +0300	[thread overview]
Message-ID: <20220330071100.GG3293@kadam> (raw)
In-Reply-To: <YkPK/QmLAp3BkygY@sckzor-linux.localdomain>

On Tue, Mar 29, 2022 at 11:14:05PM -0400, Charlie Sands wrote:
> This patch fixes sparse warnings about the endianness of different
> integers in the driver.
> 
> Signed-off-by: Charlie Sands <sandsch@northvilleschools.net>

Thanks!  This is a bugfix though so it needs a fixes tag.

Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")

Otherwise:

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

It's surprising that this code works at all.  I maybe have said before
that I suspect the pppoe stuff has not been well tested.

regards,
dan carpenter


      reply	other threads:[~2022-03-30  7:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30  3:14 [PATCH] staging: r8188eu: Fix sparse endianness warnings Charlie Sands
2022-03-30  7:11 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220330071100.GG3293@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    --cc=sandsch@northvilleschools.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.