From: Dan Carpenter <dan.carpenter@oracle.com>
To: Haowen Bai <baihaowen@meizu.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable
Date: Wed, 30 Mar 2022 10:20:34 +0300 [thread overview]
Message-ID: <20220330072034.GH3293@kadam> (raw)
In-Reply-To: <1648603740-14760-1-git-send-email-baihaowen@meizu.com>
On Wed, Mar 30, 2022 at 09:28:59AM +0800, Haowen Bai wrote:
> As init_mlme_ext_priv function always returns SUCCESS , We can change
> return type from int to void.
>
> fixes coccinelle warning:
> ./drivers/staging/r8188eu/core/rtw_mlme_ext.c:357:5-8: Unneeded variable: "res".
> Return "_SUCCESS" on line 380
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: split into two patches.
> V2->V3: change return type from int to void.
> V3->V4: just delete the unused label but don't delete the free function.
Looks okay now. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2022-03-30 7:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 8:43 [PATCH V2] staging: r8188eu: Directly return _SUCCESS instead of using local ret variable Haowen Bai
2022-03-28 8:47 ` Greg KH
2022-03-28 9:07 ` 答复: " 白浩文
2022-03-28 9:12 ` Greg KH
2022-03-29 9:59 ` baihaowen
2022-03-29 11:06 ` [PATCH] " Haowen Bai
2022-03-29 11:09 ` [PATCH V3] " Haowen Bai
2022-03-29 11:28 ` Dan Carpenter
2022-03-30 1:14 ` baihaowen
2022-03-30 1:28 ` [PATCH V4] " Haowen Bai
2022-03-30 7:20 ` Dan Carpenter [this message]
2022-03-29 11:26 ` [PATCH] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330072034.GH3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=baihaowen@meizu.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.