From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552E1C433F5 for ; Wed, 30 Mar 2022 11:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245685AbiC3LCo (ORCPT ); Wed, 30 Mar 2022 07:02:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241893AbiC3LCn (ORCPT ); Wed, 30 Mar 2022 07:02:43 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 817A0DF70 for ; Wed, 30 Mar 2022 04:00:58 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1nZW4P-0007z0-00; Wed, 30 Mar 2022 13:00:57 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id F1201C2EE0; Wed, 30 Mar 2022 12:02:13 +0200 (CEST) Date: Wed, 30 Mar 2022 12:02:13 +0200 From: Thomas Bogendoerfer To: Jackie Liu Cc: Andy Shevchenko , Linus Walleij , Ralf Baechle , "open list:BROADCOM NVRAM DRIVER" , Jonathan Cameron Subject: Re: [PATCH] MIPS: rb532: move GPIOD definition into C-files Message-ID: <20220330100213.GA8617@alpha.franken.de> References: <20220329014537.4180966-1-liu.yun@linux.dev> <71d1da40-4772-b126-7cbe-0d99024fd284@linux.dev> <20220330064216.GA5811@alpha.franken.de> <20220330093227.GA8224@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Mar 30, 2022 at 05:56:03PM +0800, Jackie Liu wrote: > > 在 2022/3/30 下午5:41, Andy Shevchenko 写道: > > On Wed, Mar 30, 2022 at 12:32 PM Thomas Bogendoerfer > > wrote: > > > On Wed, Mar 30, 2022 at 12:23:59PM +0300, Andy Shevchenko wrote: > > > > On Wed, Mar 30, 2022 at 9:45 AM Thomas Bogendoerfer > > > > wrote: > > > > > On Wed, Mar 30, 2022 at 09:46:07AM +0800, Jackie Liu wrote: > > > > ... > > > > > > > I have a patchset, where the both files will go away. No need to > > > > > clean up now. > > > > > > > > Do you plan them to be backported? If not, I would recommend applying > > > > > > no plan for backporting > > > > > > > this patch in order to have it backported and then do whatever you > > > > want we those files. > > > > > > why ? This doesn't fix anything, doesn't it ? > > Like the patch I submitted in the first version, there are some gcc > errors. > > [...] > drivers/iio/adc/da9150-gpadc.c:254:13: error: ‘DA9150_GPADC_CHAN_0x08’ > undeclared here (not in a function); did you mean ‘DA9150_GPADC_CHAN_TBAT’? > 254 | .channel = DA9150_GPADC_CHAN_##_id, \ > | ^~~~~~~~~~~~~~~~~~ > drivers/iio/adc/da9150-gpadc.c:273:2: note: in expansion of macro > ‘DA9150_GPADC_CHANNEL’ > 273 | DA9150_GPADC_CHANNEL(_id, _hw_id, _type, \ > | ^~~~~~~~~~~~~~~~~~~~ > drivers/iio/adc/da9150-gpadc.c:281:2: note: in expansion of macro > ‘DA9150_GPADC_CHANNEL_PROCESSED’ > 281 | DA9150_GPADC_CHANNEL_PROCESSED(GPIOD, GPIOD_6V, IIO_VOLTAGE, > NULL), > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > make[4]: *** [../scripts/Makefile.build:288: drivers/iio/adc/da9150-gpadc.o] > Error 1 > make[3]: *** [../scripts/Makefile.build:550: drivers/iio/adc] Error 2 > make[3]: *** Waiting for unfinished jobs.... > > > > > It fixes compilation breakage in some cases. I think the author of > > this patch can (should) elaborate. > > Also, it might need a Fixes tag. > > > Um, it's really hard to say which commit is fixed, just because this > header file defines a GPIOD, and someone else uses this later. ok, now I got it. > > > But if it makes people happy, I'll apply it. > > > > Yes, please. will do, Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]