From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: borntraeger@de.ibm.com, frankja@linux.ibm.com, thuth@redhat.com,
pasic@linux.ibm.com, david@redhat.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
scgl@linux.ibm.com, mimu@linux.ibm.com, nrb@linux.ibm.com
Subject: [PATCH v9 08/18] KVM: s390: pv: clear the state without memset
Date: Wed, 30 Mar 2022 14:25:55 +0200 [thread overview]
Message-ID: <20220330122605.247613-9-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <20220330122605.247613-1-imbrenda@linux.ibm.com>
Do not use memset to clean the whole struct kvm_s390_pv; instead,
explicitly clear the fields that need to be cleared.
Upcoming patches will introduce new fields in the struct kvm_s390_pv
that will not need to be cleared.
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
---
arch/s390/kvm/pv.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/s390/kvm/pv.c b/arch/s390/kvm/pv.c
index 9e900ce7387d..76ef33a277d3 100644
--- a/arch/s390/kvm/pv.c
+++ b/arch/s390/kvm/pv.c
@@ -16,6 +16,14 @@
#include <linux/sched/mm.h>
#include "kvm-s390.h"
+static void kvm_s390_clear_pv_state(struct kvm *kvm)
+{
+ kvm->arch.pv.handle = 0;
+ kvm->arch.pv.guest_len = 0;
+ kvm->arch.pv.stor_base = 0;
+ kvm->arch.pv.stor_var = NULL;
+}
+
int kvm_s390_pv_destroy_cpu(struct kvm_vcpu *vcpu, u16 *rc, u16 *rrc)
{
int cc;
@@ -110,7 +118,7 @@ static void kvm_s390_pv_dealloc_vm(struct kvm *kvm)
vfree(kvm->arch.pv.stor_var);
free_pages(kvm->arch.pv.stor_base,
get_order(uv_info.guest_base_stor_len));
- memset(&kvm->arch.pv, 0, sizeof(kvm->arch.pv));
+ kvm_s390_clear_pv_state(kvm);
}
static int kvm_s390_pv_alloc_vm(struct kvm *kvm)
--
2.34.1
next prev parent reply other threads:[~2022-03-30 13:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 12:25 [PATCH v9 00/18] KVM: s390: pv: implement lazy destroy for reboot Claudio Imbrenda
2022-03-30 12:25 ` [PATCH v9 01/18] KVM: s390: pv: leak the topmost page table when destroy fails Claudio Imbrenda
2022-03-31 13:13 ` Janosch Frank
2022-04-01 14:20 ` Claudio Imbrenda
2022-03-30 12:25 ` [PATCH v9 02/18] KVM: s390: pv: handle secure storage violations for protected guests Claudio Imbrenda
2022-03-30 12:25 ` [PATCH v9 03/18] KVM: s390: pv: handle secure storage exceptions for normal guests Claudio Imbrenda
2022-03-30 12:25 ` [PATCH v9 04/18] KVM: s390: pv: refactor s390_reset_acc Claudio Imbrenda
2022-03-31 13:25 ` Janosch Frank
2022-04-01 14:25 ` Claudio Imbrenda
2022-03-30 12:25 ` [PATCH v9 05/18] KVM: s390: pv: usage counter instead of flag Claudio Imbrenda
2022-03-30 12:25 ` [PATCH v9 06/18] KVM: s390: pv: add export before import Claudio Imbrenda
2022-03-30 12:25 ` [PATCH v9 07/18] KVM: s390: pv: module parameter to fence lazy destroy Claudio Imbrenda
2022-03-30 12:25 ` Claudio Imbrenda [this message]
2022-03-30 12:25 ` [PATCH v9 09/18] KVM: s390: pv: Add kvm_s390_cpus_from_pv to kvm-s390.h and add documentation Claudio Imbrenda
2022-03-30 12:25 ` [PATCH v9 10/18] KVM: s390: pv: add mmu_notifier Claudio Imbrenda
2022-03-31 13:29 ` Janosch Frank
2022-03-30 12:25 ` [PATCH v9 11/18] s390/mm: KVM: pv: when tearing down, try to destroy protected pages Claudio Imbrenda
2022-03-31 13:34 ` Janosch Frank
2022-04-01 15:03 ` Claudio Imbrenda
2022-03-30 12:25 ` [PATCH v9 12/18] KVM: s390: pv: refactoring of kvm_s390_pv_deinit_vm Claudio Imbrenda
2022-03-30 12:26 ` [PATCH v9 13/18] KVM: s390: pv: cleanup leftover protected VMs if needed Claudio Imbrenda
2022-03-31 14:02 ` Janosch Frank
2022-04-01 15:13 ` Claudio Imbrenda
2022-03-30 12:26 ` [PATCH v9 14/18] KVM: s390: pv: asynchronous destroy for reboot Claudio Imbrenda
2022-03-30 12:26 ` [PATCH v9 15/18] KVM: s390: pv: api documentation for asynchronous destroy Claudio Imbrenda
2022-03-30 12:26 ` [PATCH v9 16/18] KVM: s390: pv: add KVM_CAP_S390_PROTECTED_ASYNC_DISABLE Claudio Imbrenda
2022-03-30 12:26 ` [PATCH v9 17/18] KVM: s390: pv: avoid export before import if possible Claudio Imbrenda
2022-03-30 12:26 ` [PATCH v9 18/18] KVM: s390: pv: support for Destroy fast UVC Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330122605.247613-9-imbrenda@linux.ibm.com \
--to=imbrenda@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mimu@linux.ibm.com \
--cc=nrb@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=scgl@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.