All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Benjamin Philip" <benjamin.philip495@gmail.com>,
	"Bart Van Assche" <bvanassche@acm.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Colin Ian King" <colin.king@intel.com>,
	"Samuel Sjöberg" <info@samuelsjoberg.se>,
	"Charlie Sands" <sandsch@northvilleschools.net>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	ira.weiny@intel.com, outreachy@lists.linux.dev
Subject: Re: [PATCH v4] staging: rts5208: Convert kmap() to kmap_local_page()
Date: Wed, 30 Mar 2022 18:32:47 +0300	[thread overview]
Message-ID: <20220330153247.GW12805@kadam> (raw)
In-Reply-To: <20220330143331.8306-1-fmdefrancesco@gmail.com>

On Wed, Mar 30, 2022 at 04:33:31PM +0200, Fabio M. De Francesco wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page()
> where it is feasible.
> 
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible. Therefore rtsx_stor_access_xfer_buf() is a function
> where the use of kmap_local_page() in place of kmap() is correctly
> suited.
> 
> Convert to kmap_local_page() but, instead of open coding it, use the
> helpers memcpy_to_page() and memcpy_from_page().
> 
> Make a minor change to a comment related to scatter-gather.
> 
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---

LGTM.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter


  reply	other threads:[~2022-03-30 15:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30 14:33 [PATCH v4] staging: rts5208: Convert kmap() to kmap_local_page() Fabio M. De Francesco
2022-03-30 15:32 ` Dan Carpenter [this message]
2022-03-30 21:11 ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220330153247.GW12805@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=benjamin.philip495@gmail.com \
    --cc=bvanassche@acm.org \
    --cc=colin.king@intel.com \
    --cc=ebiederm@xmission.com \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=info@samuelsjoberg.se \
    --cc=ira.weiny@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin.petersen@oracle.com \
    --cc=outreachy@lists.linux.dev \
    --cc=sandsch@northvilleschools.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.