Re: [PATCH 2/2] dmaengine: apple-admac: Add Apple ADMAC driver

[kernel test robot <lkp@intel.com>]

Hi "Martin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20220330]
[cannot apply to vkoul-dmaengine/next linus/master v5.17 v5.17-rc8 v5.17-rc7 v5.17]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Martin-Povi-er/Apple-ADMAC-driver/20220331-004821
base:    a67ba3cf9551f8c92d5ec9d7eae1aadbb9127b57
config: arm64-randconfig-r036-20220330 (https://download.01.org/0day-ci/archive/20220331/202203310457.QwVTRPVs-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0f6d9501cf49ce02937099350d08f20c4af86f3d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/59c4f21d2dd9da4011ffb3644127b35d12f6786a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Martin-Povi-er/Apple-ADMAC-driver/20220331-004821
        git checkout 59c4f21d2dd9da4011ffb3644127b35d12f6786a
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/dma/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/dma/apple-admac.c:213:11: warning: format specifies type 'void *' but the argument has type 'dma_addr_t' (aka 'unsigned long long') [-Wformat]
                   channo, addr, tx->period_len, FLAG_DESC_NOTIFY);
                           ^~~~
   include/linux/dev_printk.h:158:46: note: expanded from macro 'dev_dbg'
           dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__)
                                               ~~~     ^~~~~~~~~~~
   include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk'
                   _dev_printk(level, dev, fmt, ##__VA_ARGS__);            \
                                           ~~~    ^~~~~~~~~~~
>> drivers/dma/apple-admac.c:213:33: warning: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat]
                   channo, addr, tx->period_len, FLAG_DESC_NOTIFY);
                                                 ^~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:158:46: note: expanded from macro 'dev_dbg'
           dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__)
                                               ~~~     ^~~~~~~~~~~
   include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk'
                   _dev_printk(level, dev, fmt, ##__VA_ARGS__);            \
                                           ~~~    ^~~~~~~~~~~
   drivers/dma/apple-admac.c:32:26: note: expanded from macro 'FLAG_DESC_NOTIFY'
   #define FLAG_DESC_NOTIFY        BIT(16)
                                   ^~~~~~~
   include/vdso/bits.h:7:19: note: expanded from macro 'BIT'
   #define BIT(nr)                 (UL(1) << (nr))
                                   ^~~~~~~~~~~~~~~
   2 warnings generated.


vim +213 drivers/dma/apple-admac.c

   197	
   198	/*
   199	 * Write one hardware descriptor for a dmaengine cyclic transaction.
   200	 */
   201	static void admac_cyclic_write_one_desc(struct admac_data *ad, int channo,
   202						struct admac_tx *tx)
   203	{
   204		dma_addr_t addr;
   205	
   206		if (WARN_ON(!tx->cyclic))
   207			return;
   208	
   209		addr = tx->buf_addr + (tx->submitted_pos % tx->buf_len);
   210		WARN_ON(addr + tx->period_len > tx->buf_end);
   211	
   212		dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
 > 213			channo, addr, tx->period_len, FLAG_DESC_NOTIFY);
   214	
   215		admac_poke(ad, REG_DESC_WRITE(channo), addr);
   216		admac_poke(ad, REG_DESC_WRITE(channo), addr >> 32);
   217		admac_poke(ad, REG_DESC_WRITE(channo), tx->period_len);
   218		admac_poke(ad, REG_DESC_WRITE(channo), FLAG_DESC_NOTIFY);
   219	
   220		tx->submitted_pos += tx->period_len;
   221		tx->submitted_pos %= 2 * tx->buf_len;
   222	}
   223	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp