From: Jakub Kicinski <kuba@kernel.org>
To: Jie Wang <wangjie125@huawei.com>
Cc: <mkubecek@suse.cz>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <huangguangbin2@huawei.com>,
<lipeng321@huawei.com>, <shenjian15@huawei.com>,
<moyufeng@huawei.com>, <linyunsheng@huawei.com>,
<salil.mehta@huawei.com>, <chenhao288@hisilicon.com>
Subject: Re: [RFCv4 PATCH net-next 1/3] net-next: ethtool: extend ringparam set/get APIs for tx_push
Date: Thu, 31 Mar 2022 20:22:50 -0700 [thread overview]
Message-ID: <20220331202250.01f53929@kernel.org> (raw)
In-Reply-To: <20220331084342.27043-2-wangjie125@huawei.com>
On Thu, 31 Mar 2022 16:43:40 +0800 Jie Wang wrote:
> +``ETHTOOL_A_RINGS_TX_PUSH`` controls flag to choose the fast path or the
> +normal path to send packets. Setting tx push attribute "on" will enable tx
> +push mode and send packets in fast path. For those not supported hardwares,
> +this attributes is "off" by default settings.
You need to be more specific what a "fast path" is, that term is
too general.
I presume you want to say something about the descriptor being written
directly into device address space... and that it lowers the latency
but increases the cost...
next prev parent reply other threads:[~2022-04-01 3:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 8:43 [RFCv4 PATCH net-next 0/3] net-next: ethool: add support to get/set tx push by ethtool -G/g Jie Wang
2022-03-31 8:43 ` [RFCv4 PATCH net-next 1/3] net-next: ethtool: extend ringparam set/get APIs for tx_push Jie Wang
2022-04-01 3:22 ` Jakub Kicinski [this message]
2022-04-02 8:09 ` wangjie (L)
2022-03-31 8:43 ` [RFCv4 PATCH net-next 2/3] net-next: ethtool: move checks before rtnl_lock() in ethnl_set_rings Jie Wang
2022-03-31 8:43 ` [RFCv4 PATCH net-next 3/3] net-next: hn3: add tx push support in hns3 ring param process Jie Wang
2022-04-01 3:23 ` Jakub Kicinski
2022-04-02 8:10 ` wangjie (L)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331202250.01f53929@kernel.org \
--to=kuba@kernel.org \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=huangguangbin2@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mkubecek@suse.cz \
--cc=moyufeng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.