From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
"Maciej W . Rozycki" <macro@orcam.me.uk>,
linux-crypto@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
stable@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] MIPS: crypto: Fix CRC32 code
Date: Fri, 1 Apr 2022 12:03:09 +0200 [thread overview]
Message-ID: <20220401100309.GA6670@alpha.franken.de> (raw)
In-Reply-To: <20220331164200.177015-1-paul@crapouillou.net>
On Thu, Mar 31, 2022 at 05:42:00PM +0100, Paul Cercueil wrote:
> Commit 67512a8cf5a7 ("MIPS: Avoid macro redefinitions") changed how the
> MIPS register macros were defined, in order to allow the code to compile
> under LLVM/Clang.
>
> The MIPS CRC32 code however wasn't updated accordingly, causing a build
> bug when using a MIPS32r6 toolchain without CRC support.
>
> Update the CRC32 code to use the macros correctly, to fix the build
> failures.
>
> Fixes: 67512a8cf5a7 ("MIPS: Avoid macro redefinitions")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
> arch/mips/crypto/crc32-mips.c | 46 ++++++++++++++++++++---------------
> 1 file changed, 26 insertions(+), 20 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2022-04-01 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 16:42 [PATCH] MIPS: crypto: Fix CRC32 code Paul Cercueil
2022-04-01 10:03 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401100309.GA6670@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=macro@orcam.me.uk \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paul@crapouillou.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.