All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Mattias Forsblad <mattias.forsblad@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [PATCH v1 net-next 1/2] net: tc: dsa: Add the matchall filter with drop action for bridged DSA ports.
Date: Fri, 1 Apr 2022 11:10:35 -0700	[thread overview]
Message-ID: <20220401111035.3b570a28@kernel.org> (raw)
In-Reply-To: <20220401100418.3762272-2-mattias.forsblad@gmail.com>

On Fri,  1 Apr 2022 12:04:17 +0200 Mattias Forsblad wrote:
>  	case NETDEV_CHANGEUPPER:
> +		struct netdev_notifier_changeupper_info *info = ptr;

I don't think C99 has been enabled, yet? You can't declare variables
like this. Please fix and repost on Monday when net-next is actually
opened.

  reply	other threads:[~2022-04-01 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01 10:04 [PATCH v1 net-next 0/2] net: tc: dsa: Implement offload of matchall for bridged DSA ports Mattias Forsblad
2022-04-01 10:04 ` [PATCH v1 net-next 1/2] net: tc: dsa: Add the matchall filter with drop action " Mattias Forsblad
2022-04-01 18:10   ` Jakub Kicinski [this message]
2022-04-01 10:04 ` [PATCH v1 net-next 2/2] net: dsa: Implement tc offloading for drop target Mattias Forsblad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401111035.3b570a28@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=mattias.forsblad@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=tobias@waldekranz.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.