From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6604EC433EF for ; Fri, 1 Apr 2022 15:27:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241807AbiDAP3K (ORCPT ); Fri, 1 Apr 2022 11:29:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349710AbiDAO5n (ORCPT ); Fri, 1 Apr 2022 10:57:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6135A1575A0; Fri, 1 Apr 2022 07:44:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EFB0760AD8; Fri, 1 Apr 2022 14:44:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2121BC340EE; Fri, 1 Apr 2022 14:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648824285; bh=rjEVSN/hVun1ukLWQf2EH7zuCMv02Gupkrvy03nJofY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SclHwTlqLGWqYpI8h22AuVf5djEvkMIN/rJmTp6JtFOIuuu1aRCD1/m3Q2IoigmSz 2g160D633f/FmXCka/0m3Fsj9c5gleG9TI2K6+B5R83LGKxWmowU611JzeZyBfQxkK gNLqRuDJYoPlOG6VMoLqwKP/SUAYMHbnc3ay5etnyC/2Ewpk9WQZxvZDSajUdtRMyU s7tODV0E3dpMvQTmxSIpYuYgV9xzkcNGAuQQv57En6CiSdYLBcE7SpeY2seWytQ+zB eK5YEQliB9WrUvgaHwIKVx84diSkeVrLjUOy8TRQXFB3Xf+g4r+KaFYzVCI2EeXphF 972052QO2ip3Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Qinghua Jin , Colin Ian King , Jan Kara , Christian Brauner , Andrew Morton , Linus Torvalds , Sasha Levin , damien.lemoal@opensource.wdc.com, willy@infradead.org, songmuchun@bytedance.com Subject: [PATCH AUTOSEL 5.10 65/65] minix: fix bug when opening a file with O_DIRECT Date: Fri, 1 Apr 2022 10:42:06 -0400 Message-Id: <20220401144206.1953700-65-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220401144206.1953700-1-sashal@kernel.org> References: <20220401144206.1953700-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qinghua Jin [ Upstream commit 9ce3c0d26c42d279b6c378a03cd6a61d828f19ca ] Testcase: 1. create a minix file system and mount it 2. open a file on the file system with O_RDWR|O_CREAT|O_TRUNC|O_DIRECT 3. open fails with -EINVAL but leaves an empty file behind. All other open() failures don't leave the failed open files behind. It is hard to check the direct_IO op before creating the inode. Just as ext4 and btrfs do, this patch will resolve the issue by allowing to create the file with O_DIRECT but returning error when writing the file. Link: https://lkml.kernel.org/r/20220107133626.413379-1-qhjin.dev@gmail.com Signed-off-by: Qinghua Jin Reported-by: Colin Ian King Reviewed-by: Jan Kara Acked-by: Christian Brauner Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/minix/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/minix/inode.c b/fs/minix/inode.c index 34f546404aa1..e938f5b1e4b9 100644 --- a/fs/minix/inode.c +++ b/fs/minix/inode.c @@ -446,7 +446,8 @@ static const struct address_space_operations minix_aops = { .writepage = minix_writepage, .write_begin = minix_write_begin, .write_end = generic_write_end, - .bmap = minix_bmap + .bmap = minix_bmap, + .direct_IO = noop_direct_IO }; static const struct inode_operations minix_symlink_inode_operations = { -- 2.34.1