From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8AF1C4321E for ; Fri, 1 Apr 2022 15:40:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357916AbiDAPjV (ORCPT ); Fri, 1 Apr 2022 11:39:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350656AbiDAPAX (ORCPT ); Fri, 1 Apr 2022 11:00:23 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D36EADF0C; Fri, 1 Apr 2022 07:48:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 45975CE258F; Fri, 1 Apr 2022 14:48:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBC41C2BBE4; Fri, 1 Apr 2022 14:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648824506; bh=MICxgwXy2CQrPa83r0uiCj8GpEQUlbiVbweW7fCQ4ss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eeD/1xEdp7xif4ue9xsvh5NUYpoXU6MDRgRBAHADCD81NqhRveEGlIos0CTKlAuso 7LGGMYbz63492ZALDn5x3VM68Ff7CAPtUDwy0Galp3Ol/pBr1d2RDJcsbLOcsdUv0v iASIJ36/liG1+sBG0yWTifWvdpC1Vqd+5mTpO0EA1tmeE2Ez4WBXC4yD8XHVb0w1KI yAg5O52OIs+SEhFHdrddqzsLn9EgvT/HDQMcaKKhMiwqysDjbDIdKEFhslTa1vyUtU k50EeuoLRntAg3HZ+2ziy5iC/LLUS20z0mvvP/eKF3sAhE57XcS2TzMNjk2V0yIKlO PL661DVrD7dtA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Randy Dunlap , Igor Zhbanov , Ingo Molnar , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Sasha Levin , mhiramat@kernel.org, rostedt@goodmis.org, ahalaney@redhat.com, vbabka@suse.cz, wangkefeng.wang@huawei.com, linux@rasmusvillemoes.dk, keescook@chromium.org, mark-pk.tsai@mediatek.com, peterz@infradead.org, valentin.schneider@arm.com Subject: [PATCH AUTOSEL 4.14 22/22] init/main.c: return 1 from handled __setup() functions Date: Fri, 1 Apr 2022 10:47:29 -0400 Message-Id: <20220401144729.1955554-22-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220401144729.1955554-1-sashal@kernel.org> References: <20220401144729.1955554-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap [ Upstream commit f9a40b0890658330c83c95511f9d6b396610defc ] initcall_blacklist() should return 1 to indicate that it handled its cmdline arguments. set_debug_rodata() should return 1 to indicate that it handled its cmdline arguments. Print a warning if the option string is invalid. This prevents these strings from being added to the 'init' program's environment as they are not init arguments/parameters. Link: https://lkml.kernel.org/r/20220221050901.23985-1-rdunlap@infradead.org Signed-off-by: Randy Dunlap Reported-by: Igor Zhbanov Cc: Ingo Molnar Cc: Greg Kroah-Hartman Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- init/main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/init/main.c b/init/main.c index f0b2411a5fbf..621cedd9173a 100644 --- a/init/main.c +++ b/init/main.c @@ -749,7 +749,7 @@ static int __init initcall_blacklist(char *str) } } while (str_entry); - return 0; + return 1; } static bool __init_or_module initcall_blacklisted(initcall_t fn) @@ -965,7 +965,9 @@ static noinline void __init kernel_init_freeable(void); bool rodata_enabled __ro_after_init = true; static int __init set_debug_rodata(char *str) { - return strtobool(str, &rodata_enabled); + if (strtobool(str, &rodata_enabled)) + pr_warn("Invalid option string for rodata: '%s'\n", str); + return 1; } __setup("rodata=", set_debug_rodata); #endif -- 2.34.1