From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/vdpa/ifcvf/ifcvf_main.c:306 ifcvf_request_config_irq() error: uninitialized symbol 'config_vector'.
Date: Sat, 02 Apr 2022 22:30:31 +0800 [thread overview]
Message-ID: <202204022231.tKB4fuN9-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4161 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Zhu Lingshan <lingshan.zhu@intel.com>
CC: "Michael S. Tsirkin" <mst@redhat.com>
CC: Tom Rix <trix@redhat.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 88e6c0207623874922712e162e25d9dafd39661e
commit: 9b3e814834009a7d197ab6f93d6e061c0c4ee7e6 vDPA/ifcvf: implement shared IRQ feature
date: 5 days ago
:::::: branch date: 11 hours ago
:::::: commit date: 5 days ago
config: ia64-randconfig-m031-20220401 (https://download.01.org/0day-ci/archive/20220402/202204022231.tKB4fuN9-lkp(a)intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/vdpa/ifcvf/ifcvf_main.c:306 ifcvf_request_config_irq() error: uninitialized symbol 'config_vector'.
vim +/config_vector +306 drivers/vdpa/ifcvf/ifcvf_main.c
7dd793f37e2ab4 Zhu Lingshan 2020-05-12 286
9b3e814834009a Zhu Lingshan 2022-02-22 287 static int ifcvf_request_config_irq(struct ifcvf_adapter *adapter)
9b3e814834009a Zhu Lingshan 2022-02-22 288 {
9b3e814834009a Zhu Lingshan 2022-02-22 289 struct pci_dev *pdev = adapter->pdev;
9b3e814834009a Zhu Lingshan 2022-02-22 290 struct ifcvf_hw *vf = &adapter->vf;
9b3e814834009a Zhu Lingshan 2022-02-22 291 int config_vector, ret;
9b3e814834009a Zhu Lingshan 2022-02-22 292
9b3e814834009a Zhu Lingshan 2022-02-22 293 if (vf->msix_vector_status == MSIX_VECTOR_DEV_SHARED)
9b3e814834009a Zhu Lingshan 2022-02-22 294 return 0;
9b3e814834009a Zhu Lingshan 2022-02-22 295
9b3e814834009a Zhu Lingshan 2022-02-22 296 if (vf->msix_vector_status == MSIX_VECTOR_PER_VQ_AND_CONFIG)
9b3e814834009a Zhu Lingshan 2022-02-22 297 /* vector 0 ~ vf->nr_vring for vqs, num vf->nr_vring vector for config interrupt */
9b3e814834009a Zhu Lingshan 2022-02-22 298 config_vector = vf->nr_vring;
9b3e814834009a Zhu Lingshan 2022-02-22 299
9b3e814834009a Zhu Lingshan 2022-02-22 300 if (vf->msix_vector_status == MSIX_VECTOR_SHARED_VQ_AND_CONFIG)
9b3e814834009a Zhu Lingshan 2022-02-22 301 /* vector 0 for vqs and 1 for config interrupt */
9b3e814834009a Zhu Lingshan 2022-02-22 302 config_vector = 1;
9b3e814834009a Zhu Lingshan 2022-02-22 303
9b3e814834009a Zhu Lingshan 2022-02-22 304 snprintf(vf->config_msix_name, 256, "ifcvf[%s]-config\n",
9b3e814834009a Zhu Lingshan 2022-02-22 305 pci_name(pdev));
9b3e814834009a Zhu Lingshan 2022-02-22 @306 vf->config_irq = pci_irq_vector(pdev, config_vector);
9b3e814834009a Zhu Lingshan 2022-02-22 307 ret = devm_request_irq(&pdev->dev, vf->config_irq,
9b3e814834009a Zhu Lingshan 2022-02-22 308 ifcvf_config_changed, 0,
9b3e814834009a Zhu Lingshan 2022-02-22 309 vf->config_msix_name, vf);
9b3e814834009a Zhu Lingshan 2022-02-22 310 if (ret) {
9b3e814834009a Zhu Lingshan 2022-02-22 311 IFCVF_ERR(pdev, "Failed to request config irq\n");
9b3e814834009a Zhu Lingshan 2022-02-22 312 goto err;
9b3e814834009a Zhu Lingshan 2022-02-22 313 }
9b3e814834009a Zhu Lingshan 2022-02-22 314
9b3e814834009a Zhu Lingshan 2022-02-22 315 ret = ifcvf_set_config_vector(vf, config_vector);
9b3e814834009a Zhu Lingshan 2022-02-22 316 if (ret == VIRTIO_MSI_NO_VECTOR) {
9b3e814834009a Zhu Lingshan 2022-02-22 317 IFCVF_ERR(pdev, "No msix vector for device config\n");
9b3e814834009a Zhu Lingshan 2022-02-22 318 goto err;
9b3e814834009a Zhu Lingshan 2022-02-22 319 }
9b3e814834009a Zhu Lingshan 2022-02-22 320
9b3e814834009a Zhu Lingshan 2022-02-22 321 return 0;
9b3e814834009a Zhu Lingshan 2022-02-22 322 err:
9b3e814834009a Zhu Lingshan 2022-02-22 323 ifcvf_free_irq(adapter);
9b3e814834009a Zhu Lingshan 2022-02-22 324
9b3e814834009a Zhu Lingshan 2022-02-22 325 return -EFAULT;
9b3e814834009a Zhu Lingshan 2022-02-22 326 }
9b3e814834009a Zhu Lingshan 2022-02-22 327
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-04-02 14:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204022231.tKB4fuN9-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.