From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 4/4] support/scripts/pkg-stats: reimplement CPE parsing in pkg-stats
Date: Sun, 3 Apr 2022 10:05:38 +0200 [thread overview]
Message-ID: <20220403100538.538f8a3c@windsurf> (raw)
In-Reply-To: <20220402172012.GB1811301@scaer>
Hello Yann,
On Sat, 2 Apr 2022 19:20:12 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats
> > index ae1a9aa5e4..cc163ebb1a 100755
> > --- a/support/scripts/pkg-stats
> > +++ b/support/scripts/pkg-stats
> > @@ -27,12 +27,14 @@ import re
> > import subprocess
> > import json
> > import sys
> > +import time
> > +import gzip
> > +import xml.etree.ElementTree
>
> You for to import requests, which is used later on.
I suppose s/for/forgot/ ? But then how it could have worked for me? Huh.
> I also fixed a bunch of flake8 issues:
Ah, gah, forgot once again to run flake8, sorry about that.
> > +CPEDB_URL = "https://static.nvd.nist.gov/feeds/xml/cpe/dictionary/official-cpe-dictionary_v2.3.xml.gz"
>
> Instead of duplicating it here, I changed that to import it from cpedb.
ACK.
> Applied to master with all the aboved fixed, thanks.
Many thanks. Peter, could you backport those patches, or at least PATCH
3/4 and 4/4 to all stable branches still in activity?
Indeed, thanks to this fix, the pkg-stats run of this morning on the
master branch worked fine, but it failed miserably on the 2021.02.x
branch.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-04-03 8:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 14:15 [Buildroot] [PATCH 1/4] support/script/pkg-stats: allow disabling CPE matching Thomas Petazzoni via buildroot
2022-04-02 14:15 ` [Buildroot] [PATCH 2/4] support/scripts/pkg-stats: allow disabling package warnings retrieval Thomas Petazzoni via buildroot
2022-04-04 12:40 ` Peter Korsgaard
2022-04-02 14:15 ` [Buildroot] [PATCH 3/4] support/scripts/pkg-stats: add a timeout on HTTP requests for upstream URLs Thomas Petazzoni via buildroot
2022-04-04 12:40 ` Peter Korsgaard
2022-04-02 14:15 ` [Buildroot] [PATCH 4/4] support/scripts/pkg-stats: reimplement CPE parsing in pkg-stats Thomas Petazzoni via buildroot
2022-04-02 14:17 ` Thomas Petazzoni via buildroot
2022-04-02 17:20 ` Yann E. MORIN
2022-04-03 8:05 ` Thomas Petazzoni via buildroot [this message]
2022-04-04 12:40 ` Peter Korsgaard
2022-04-02 14:42 ` [Buildroot] [PATCH 1/4] support/script/pkg-stats: allow disabling CPE matching Yann E. MORIN
2022-04-04 12:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220403100538.538f8a3c@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.