From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/zlib-ng: fix build on powerpc
Date: Sun, 3 Apr 2022 23:48:00 +0200 [thread overview]
Message-ID: <20220403214800.GF2354230@scaer> (raw)
In-Reply-To: <20220403202202.1583075-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2022-04-03 22:22 +0200, Fabrice Fontaine spake thusly:
> Handle WITH_POWER8 to fix the following build failure with powerpc and
> libglib2 raised since bump to version 1.9.9-b1 in commit
> 1f7b12a0b4572d7e763c431a63c22cfb912b8b14 and
> https://github.com/zlib-ng/zlib-ng/commit/b81f4ee96dcbdf1db34b00727b6f1829a2ba1edb:
>
> /home/autobuild/autobuild/instance-9/output-1/host/lib/gcc/powerpc-buildroot-linux-musl/11.2.0/../../../../powerpc-buildroot-linux-musl/bin/ld: /home/autobuild/autobuild/instance-9/output-1/host/powerpc-buildroot-linux-musl/sysroot/usr/lib/libz.a(adler32_power8.c.o): in function `adler32_power8':
> /home/autobuild/autobuild/instance-9/output-1/build/zlib-ng-2.0.6/arch/power/adler32_power8.c:106: undefined reference to `vec_sumsu'
>
> Fixes:
> - http://autobuild.buildroot.org/results/f864a0e2307e25342b45c90a5b4fb57a0f5c1c93
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2 (after review of Yann E. Morin):
> - Don't unconditionally disable power8
>
> package/zlib-ng/zlib-ng.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/zlib-ng/zlib-ng.mk b/package/zlib-ng/zlib-ng.mk
> index fb497b8c11..938acd4181 100644
> --- a/package/zlib-ng/zlib-ng.mk
> +++ b/package/zlib-ng/zlib-ng.mk
> @@ -23,4 +23,10 @@ ifeq ($(BR2_arm),y)
> ZLIB_NG_CONF_OPTS += -DWITH_ACLE=1 -DWITH_NEON=1
> endif
>
> +ifeq ($(BR2_powerpc_power8),y)
> +ZLIB_NG_CONF_OPTS += -DWITH_POWER8=ON
> +else
> +ZLIB_NG_CONF_OPTS += -DWITH_POWER8=OFF
> +endif
> +
> $(eval $(cmake-package))
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-04-03 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 20:22 [Buildroot] [PATCH v2,1/1] package/zlib-ng: fix build on powerpc Fabrice Fontaine
2022-04-03 21:48 ` Yann E. MORIN [this message]
2022-04-04 19:42 ` [Buildroot] [PATCH v2, 1/1] " Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220403214800.GF2354230@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.