From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12862C433F5 for ; Mon, 4 Apr 2022 23:16:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241927AbiDDXSD (ORCPT ); Mon, 4 Apr 2022 19:18:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242234AbiDDXRt (ORCPT ); Mon, 4 Apr 2022 19:17:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EFA1A1B0 for ; Mon, 4 Apr 2022 16:08:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 47C09B81AD0 for ; Mon, 4 Apr 2022 23:08:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E579BC340F2; Mon, 4 Apr 2022 23:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649113714; bh=QsjQxxlDZCnzrji4TXJlqbfmTle0nMq6ayPLu/eqhrg=; h=Date:To:From:Subject:From; b=w+MFsgNW7ZYxe6kd5fZSLEFTa+EFaZnklt2Gym1T/efHwlgS9zGjSYg1kTmmntv7y fbWjvuotk3u7Nfv7SJBu7xL09phQpLNbmJOuqQFP0dNggs1unsDUZLkrvloxYS+TIj TRx2M9WGAubJYiGNXK1arE/xSnr31+fTIcp7zDZk= Date: Mon, 04 Apr 2022 16:08:33 -0700 To: mm-commits@vger.kernel.org, rafael@kernel.org, minchan.kim@gmail.com, mel@csn.ul.ie, kosaki.motohiro@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, gregkh@linuxfoundation.org, linmiaohe@huawei.com, akpm@linux-foundation.org From: Andrew Morton Subject: + drivers-base-nodec-fix-compaction-sysfs-file-leak.patch added to -mm tree Message-Id: <20220404230833.E579BC340F2@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: drivers/base/node.c: fix compaction sysfs file leak has been added to the -mm tree. Its filename is drivers-base-nodec-fix-compaction-sysfs-file-leak.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/drivers-base-nodec-fix-compaction-sysfs-file-leak.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/drivers-base-nodec-fix-compaction-sysfs-file-leak.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Miaohe Lin Subject: drivers/base/node.c: fix compaction sysfs file leak Compaction sysfs file is created via compaction_register_node in register_node. But we forgot to remove it in unregister_node. Thus compaction sysfs file is leaked. Using compaction_unregister_node to fix this issue. Link: https://lkml.kernel.org/r/20220401070905.43679-1-linmiaohe@huawei.com Fixes: ed4a6d7f0676 ("mm: compaction: add /sys trigger for per-node memory compaction") Signed-off-by: Miaohe Lin Cc: Greg Kroah-Hartman Cc: Rafael J. Wysocki Cc: Mel Gorman Cc: Minchan Kim Cc: KAMEZAWA Hiroyuki Cc: KOSAKI Motohiro Signed-off-by: Andrew Morton --- drivers/base/node.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/base/node.c~drivers-base-nodec-fix-compaction-sysfs-file-leak +++ a/drivers/base/node.c @@ -682,6 +682,7 @@ static int register_node(struct node *no */ void unregister_node(struct node *node) { + compaction_unregister_node(node); hugetlb_unregister_node(node); /* no-op, if memoryless node */ node_remove_accesses(node); node_remove_caches(node); _ Patches currently in -mm which might be from linmiaohe@huawei.com are mm-mempolicy-fix-mpol_new-leak-in-shared_policy_replace.patch mm-shmem-make-shmem_init-return-void.patch mm-memcg-remove-unneeded-nr_scanned.patch mm-mmapc-use-helper-mlock_future_check.patch mm-mremap-use-helper-mlock_future_check.patch mm-mremap-avoid-unneeded-do_munmap-call.patch mm-z3fold-declare-z3fold_mount-with-__init.patch mm-z3fold-remove-obsolete-comment-in-z3fold_alloc.patch mm-z3fold-minor-clean-up-for-z3fold_free.patch mm-z3fold-remove-unneeded-page_mapcount_reset-and-clearpageprivate.patch mm-z3fold-remove-confusing-local-variable-l-reassignment.patch mm-z3fold-move-decrement-of-pool-pages_nr-into-__release_z3fold_page.patch mm-z3fold-remove-redundant-list_del_init-of-zhdr-buddy-in-z3fold_free.patch mm-z3fold-remove-unneeded-page_headless-check-in-free_handle.patch mm-compaction-use-helper-isolation_suitable.patch drivers-base-nodec-fix-compaction-sysfs-file-leak.patch mm-migration-remove-unneeded-local-variable-mapping_locked.patch mm-migration-remove-unneeded-out-label.patch mm-migration-remove-unneeded-local-variable-page_lru.patch mm-migration-fix-the-confusing-pagetranshuge-check.patch mm-migration-use-helper-function-vma_lookup-in-add_page_for_migration.patch mm-migration-use-helper-macro-min-in-do_pages_stat.patch mm-migration-avoid-unneeded-nodemask_t-initialization.patch mm-migration-remove-some-duplicated-codes-in-migrate_pages.patch mm-migration-fix-potential-page-refcounts-leak-in-migrate_pages.patch mm-migration-fix-potential-invalid-node-access-for-reclaim-based-migration.patch mm-migration-fix-possible-do_pages_stat_array-racing-with-memory-offline.patch