From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: Tom Rix <trix@redhat.com>,
idosch@nvidia.com, petrm@nvidia.com, davem@davemloft.net,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum_router: simplify list unwinding
Date: Tue, 5 Apr 2022 13:23:53 -0700 [thread overview]
Message-ID: <20220405132353.00e7cb5e@kernel.org> (raw)
In-Reply-To: <Ykmcu5y4Tx8pqhtQ@shredder>
On Sun, 3 Apr 2022 16:10:19 +0300 Ido Schimmel wrote:
> On Sat, Apr 02, 2022 at 08:15:16AM -0400, Tom Rix wrote:
> > The setting of i here
> > err_nexthop6_group_get:
> > i = nrt6;
> > Is redundant, i is already nrt6. So remove
> > this statement.
> >
> > The for loop for the unwinding
> > err_rt6_create:
> > for (i--; i >= 0; i--) {
> > Is equivelent to
> > for (; i > 0; i--) {
> >
> > Two consecutive labels can be reduced to one.
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
>
> For net-next:
>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Now 6f2f36e5f932 ("mlxsw: spectrum_router: simplify list unwinding")
Thanks!
prev parent reply other threads:[~2022-04-06 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 12:15 [PATCH] mlxsw: spectrum_router: simplify list unwinding Tom Rix
2022-04-03 13:10 ` Ido Schimmel
2022-04-05 20:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405132353.00e7cb5e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.