From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0675C433EF for ; Tue, 5 Apr 2022 13:49:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D190917CC; Tue, 5 Apr 2022 15:48:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D190917CC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1649166558; bh=L940+BjtIFTE/F2hK7zJ5314fCg6+o2jSl+cZo4AB4U=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Er+i+DRLGA2dooqspYj7k/jRyABJ72QiJAOyPmTHZQScl2tqtXOQBmVZIVNeBwy18 5Ckn66XTjOB1a9rLXaNRIJhcoOCx4Xbv2yxNo0chDY8yDt461qbxvA8suL5Xw3IrCY 2RQNk1f3NuEaQ6uuHxd9Fy9zZQflsHLP99qNXdXE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 78DA2F8014B; Tue, 5 Apr 2022 15:48:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 92BC0F8016A; Tue, 5 Apr 2022 15:48:27 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2E04CF8012C for ; Tue, 5 Apr 2022 15:48:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2E04CF8012C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FNuQeoqh" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8785614FB; Tue, 5 Apr 2022 13:48:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9AD0C385AA; Tue, 5 Apr 2022 13:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649166502; bh=L940+BjtIFTE/F2hK7zJ5314fCg6+o2jSl+cZo4AB4U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FNuQeoqhWp7RKDV5m0kQMwRKrARsSVoOgz0olHveaHVLxFYUjdbVZffcnzjXejyQr mf8FSBreaRxwnvRMY/OY7wmmp6BJ015NqBl5ORDOnL+N96VODQ6srMUkpNeTGmAFA9 2krQIhtoV8wwCwd7kPPkIjaPLFa/2ev4jyw+X9Pu5zPIJuggg1Ftz5LxOECCuLRiP4 Pe3qUEbcDVpZokm30yH44Y41SZ4mzmfDq4KKvY7qbx0G6hdaA9GY8nV4BcwwXJbZIZ GHPSDkA4aq3ZYrg1yfyffUmvOjylqxRct/CybycerRgkggSilFau1F0xcPrQrWheav KQZ5zaK5yoWeg== Date: Tue, 5 Apr 2022 15:48:16 +0200 From: Mauro Carvalho Chehab To: Hans de Goede Subject: Re: [PATCH v2 0/2] Make headphone work on Huawei Matebook D15 Message-ID: <20220405154816.5cfdc49c@coco.lan> In-Reply-To: <168fe6c3-6a7d-4019-16e3-066caf394b8a@redhat.com> References: <168fe6c3-6a7d-4019-16e3-066caf394b8a@redhat.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Cezary Rojewski , alsa-devel@alsa-project.org, =?UTF-8?B?UMOpdGVy?= Ujfalusi , Takashi Iwai , Jie Yang , Pierre-Louis Bossart , Liam Girdwood , Mark Brown , Bard Liao , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Em Tue, 5 Apr 2022 11:00:44 +0200 Hans de Goede escreveu: > Hi, > > On 4/5/22 10:44, Mauro Carvalho Chehab wrote: > > At Huawei Matebook D15 two different GPIOs are used to control the output: > > - gpio0 controls the speaker output; > > - gpio1 controls the headphone output. > > > > Changing both at the same time cause spurious events that are mis-interpreted > > as input events, causing troubles on apps. So, a delay is needed before turning > > on such gpios. > > > > With this patch, plugging a headphone causes a jack event to trigger the speaker > > supply, powering down the speaker and powering up the headphone output. > > Removing the headphone also triggers the power supply, powering up the speaker > > and powering down the headphone. > > > > Mauro Carvalho Chehab (2): > > ASoC: Intel: sof_es8336: support a separate gpio to control headphone > > ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio > > There is something weird with the patches here, at least for me in Thunderbird > both patches show up as nameless attachments to emails with empty bodies. Weird... I tested here on Thunderbird (Fedora 35), reading it from the ML and they opened ok here. There *is* an issue on such patches though: they ended using my past e-mail :-) I'll re-send those with your ack using the right SoB/From mchehab@kernel.org. > > After saving the attachments the patches look good to me, so: > > Acked-by: Hans de Goede Thanks! Regards, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FAB2C4321E for ; Tue, 5 Apr 2022 21:53:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386002AbiDEVuZ (ORCPT ); Tue, 5 Apr 2022 17:50:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1392232AbiDEPfx (ORCPT ); Tue, 5 Apr 2022 11:35:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 301D92DE for ; Tue, 5 Apr 2022 06:48:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23933618B3 for ; Tue, 5 Apr 2022 13:48:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9AD0C385AA; Tue, 5 Apr 2022 13:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649166502; bh=L940+BjtIFTE/F2hK7zJ5314fCg6+o2jSl+cZo4AB4U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FNuQeoqhWp7RKDV5m0kQMwRKrARsSVoOgz0olHveaHVLxFYUjdbVZffcnzjXejyQr mf8FSBreaRxwnvRMY/OY7wmmp6BJ015NqBl5ORDOnL+N96VODQ6srMUkpNeTGmAFA9 2krQIhtoV8wwCwd7kPPkIjaPLFa/2ev4jyw+X9Pu5zPIJuggg1Ftz5LxOECCuLRiP4 Pe3qUEbcDVpZokm30yH44Y41SZ4mzmfDq4KKvY7qbx0G6hdaA9GY8nV4BcwwXJbZIZ GHPSDkA4aq3ZYrg1yfyffUmvOjylqxRct/CybycerRgkggSilFau1F0xcPrQrWheav KQZ5zaK5yoWeg== Date: Tue, 5 Apr 2022 15:48:16 +0200 From: Mauro Carvalho Chehab To: Hans de Goede Cc: Pierre-Louis Bossart , =?UTF-8?B?UMOpdGVy?= Ujfalusi , Bard Liao , Cezary Rojewski , Jaroslav Kysela , Jie Yang , Liam Girdwood , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] Make headphone work on Huawei Matebook D15 Message-ID: <20220405154816.5cfdc49c@coco.lan> In-Reply-To: <168fe6c3-6a7d-4019-16e3-066caf394b8a@redhat.com> References: <168fe6c3-6a7d-4019-16e3-066caf394b8a@redhat.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, 5 Apr 2022 11:00:44 +0200 Hans de Goede escreveu: > Hi, > > On 4/5/22 10:44, Mauro Carvalho Chehab wrote: > > At Huawei Matebook D15 two different GPIOs are used to control the output: > > - gpio0 controls the speaker output; > > - gpio1 controls the headphone output. > > > > Changing both at the same time cause spurious events that are mis-interpreted > > as input events, causing troubles on apps. So, a delay is needed before turning > > on such gpios. > > > > With this patch, plugging a headphone causes a jack event to trigger the speaker > > supply, powering down the speaker and powering up the headphone output. > > Removing the headphone also triggers the power supply, powering up the speaker > > and powering down the headphone. > > > > Mauro Carvalho Chehab (2): > > ASoC: Intel: sof_es8336: support a separate gpio to control headphone > > ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio > > There is something weird with the patches here, at least for me in Thunderbird > both patches show up as nameless attachments to emails with empty bodies. Weird... I tested here on Thunderbird (Fedora 35), reading it from the ML and they opened ok here. There *is* an issue on such patches though: they ended using my past e-mail :-) I'll re-send those with your ack using the right SoB/From mchehab@kernel.org. > > After saving the attachments the patches look good to me, so: > > Acked-by: Hans de Goede Thanks! Regards, Mauro