All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Rob Herring <robh@kernel.org>
Cc: kbuild-all@lists.01.org,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
	linux-kernel@vger.kernel.org
Subject: [ammarfaizi2-block:robh/linux/dt/pop-pci-nodes 2/2] drivers/pci/of.c:29:6: warning: no previous prototype for 'add_bus_props'
Date: Wed, 6 Apr 2022 13:56:31 +0800	[thread overview]
Message-ID: <202204061333.cVi47HBi-lkp@intel.com> (raw)

tree:   https://github.com/ammarfaizi2/linux-block robh/linux/dt/pop-pci-nodes
head:   b9198a9525a97d05b0bb2a7282fede92d7d2d93d
commit: b9198a9525a97d05b0bb2a7282fede92d7d2d93d [2/2] PCI: Create DT nodes if they don't exist
config: ia64-buildonly-randconfig-r006-20220405 (https://download.01.org/0day-ci/archive/20220406/202204061333.cVi47HBi-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/b9198a9525a97d05b0bb2a7282fede92d7d2d93d
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block robh/linux/dt/pop-pci-nodes
        git checkout b9198a9525a97d05b0bb2a7282fede92d7d2d93d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/pci/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from arch/ia64/include/asm/pgtable.h:153,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from arch/ia64/include/asm/sections.h:11,
                    from include/linux/interrupt.h:21,
                    from include/linux/pci.h:38,
                    from drivers/pci/of.c:11:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:127:48: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
     127 |         unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
         |                                                ^~~~~~~
   drivers/pci/of.c: At top level:
   drivers/pci/of.c:18:21: warning: no previous prototype for 'make_node' [-Wmissing-prototypes]
      18 | struct device_node *make_node(void)
         |                     ^~~~~~~~~
>> drivers/pci/of.c:29:6: warning: no previous prototype for 'add_bus_props' [-Wmissing-prototypes]
      29 | void add_bus_props(struct device_node *node)
         |      ^~~~~~~~~~~~~
   drivers/pci/of.c:60:6: warning: no previous prototype for 'make_dev_node' [-Wmissing-prototypes]
      60 | void make_dev_node(struct pci_dev *dev)
         |      ^~~~~~~~~~~~~
   drivers/pci/of.c:88:21: warning: no previous prototype for 'make_bus_node' [-Wmissing-prototypes]
      88 | struct device_node *make_bus_node(struct pci_bus *bus)
         |                     ^~~~~~~~~~~~~


vim +/add_bus_props +29 drivers/pci/of.c

    28	
  > 29	void add_bus_props(struct device_node *node)
    30	{
    31		struct property *prop;
    32		__be32 *val;
    33	
    34		prop = kzalloc(sizeof(*prop), GFP_KERNEL);
    35		prop->name = "ranges";
    36		prop->value = prop + 1;
    37		prop->next = node->properties;
    38		node->properties = prop;
    39	
    40		prop = kzalloc(sizeof(*prop) + sizeof(__be32), GFP_KERNEL);
    41		prop->name = "#address-cells";
    42		prop->value = prop + 1;
    43		prop->length = sizeof(__be32);
    44		val = prop->value;
    45		val[0] = __cpu_to_be32(3);
    46		prop->next = node->properties;
    47		node->properties = prop;
    48	
    49		prop = kzalloc(sizeof(*prop) + sizeof(__be32), GFP_KERNEL);
    50		prop->name = "#size-cells";
    51		prop->value = prop + 1;
    52		prop->length = sizeof(__be32);
    53		val = prop->value;
    54		val[0] = __cpu_to_be32(2);
    55		prop->next = node->properties;
    56		node->properties = prop;
    57	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-04-06  8:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202204061333.cVi47HBi-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=gwml@vger.gnuweeb.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.