From: Jakub Kicinski <kuba@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v2] net: phy: micrel: ksz9031/ksz9131: add cabletest support
Date: Wed, 6 Apr 2022 21:57:40 -0700 [thread overview]
Message-ID: <20220406215740.24bfd957@kernel.org> (raw)
In-Reply-To: <20220407020812.1095295-1-marex@denx.de>
On Thu, 7 Apr 2022 04:08:12 +0200 Marek Vasut wrote:
> Add cable test support for Micrel KSZ9x31 PHYs.
>
> Tested on i.MX8M Mini with KSZ9131RNX in 100/Full mode with pairs shuffled
> before magnetics:
> (note: Cable test started/completed messages are omitted)
>
> mx8mm-ksz9131-a-d-connected$ ethtool --cable-test eth0
> Pair A code OK
> Pair B code Short within Pair
> Pair B, fault length: 0.80m
> Pair C code Short within Pair
> Pair C, fault length: 0.80m
> Pair D code OK
>
> mx8mm-ksz9131-a-b-connected$ ethtool --cable-test eth0
> Pair A code OK
> Pair B code OK
> Pair C code Short within Pair
> Pair C, fault length: 0.00m
> Pair D code Short within Pair
> Pair D, fault length: 0.00m
>
> Tested on R8A77951 Salvator-XS with KSZ9031RNX and all four pairs connected:
> (note: Cable test started/completed messages are omitted)
>
> r8a7795-ksz9031-all-connected$ ethtool --cable-test eth0
> Pair A code OK
> Pair B code OK
> Pair C code OK
> Pair D code OK
>
> The CTRL1000 CTL1000_ENABLE_MASTER and CTL1000_AS_MASTER bits are not
> restored by calling phy_init_hw(), they must be manually cached in
> ksz9x31_cable_test_start() and restored at the end of
> ksz9x31_cable_test_get_status().
>
> Signed-off-by: Marek Vasut <marex@denx.de>
It does not apply completely cleanly to net-next, could you rebase?
next prev parent reply other threads:[~2022-04-07 4:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 2:08 [PATCH v2] net: phy: micrel: ksz9031/ksz9131: add cabletest support Marek Vasut
2022-04-07 4:57 ` Jakub Kicinski [this message]
2022-04-07 10:56 ` Marek Vasut
2022-04-07 5:06 ` Oleksij Rempel
2022-04-07 10:47 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406215740.24bfd957@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux@rempel-privat.de \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.