From: "Marek Behún" <kabel@kernel.org>
To: Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>
Cc: u-boot@lists.denx.de, "Marek Behún" <marek.behun@nic.cz>
Subject: [PATCH u-boot-net v4 12/14] net: phy: use ->is_c45 instead of is_10g_interface()
Date: Thu, 7 Apr 2022 00:33:06 +0200 [thread overview]
Message-ID: <20220406223308.9833-13-kabel@kernel.org> (raw)
In-Reply-To: <20220406223308.9833-1-kabel@kernel.org>
From: Marek Behún <marek.behun@nic.cz>
Use phydev->is_c45 instead of is_10g_interface(phydev->interface) to
determine whether clause 45 protocol should be used.
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
---
drivers/net/phy/phy.c | 8 ++++----
include/phy.h | 12 ------------
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index ba7b361c3d..7f21c5535b 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -632,10 +632,10 @@ static int phy_probe(struct phy_device *phydev)
return err;
}
-static struct phy_driver *generic_for_interface(phy_interface_t interface)
+static struct phy_driver *generic_for_phy(struct phy_device *phydev)
{
#ifdef CONFIG_PHYLIB_10G
- if (is_10g_interface(interface))
+ if (phydev->is_c45)
return &gen10g_driver;
#endif
@@ -656,7 +656,7 @@ static struct phy_driver *get_phy_driver(struct phy_device *phydev,
}
/* If we made it here, there's no driver for this PHY */
- return generic_for_interface(interface);
+ return generic_for_phy(phydev);
}
struct phy_device *phy_device_create(struct mii_dev *bus, int addr,
@@ -859,7 +859,7 @@ int phy_reset(struct phy_device *phydev)
#ifdef CONFIG_PHYLIB_10G
/* If it's 10G, we need to issue reset through one of the MMDs */
- if (is_10g_interface(phydev->interface)) {
+ if (phydev->is_c45) {
if (!phydev->mmds)
gen10g_discover_mmds(phydev);
diff --git a/include/phy.h b/include/phy.h
index 399e050aba..c7fa0ffba4 100644
--- a/include/phy.h
+++ b/include/phy.h
@@ -359,18 +359,6 @@ static inline int phy_clear_bits_mmd(struct phy_device *phydev, int devad,
#ifdef CONFIG_PHYLIB_10G
extern struct phy_driver gen10g_driver;
-
-/*
- * List all 10G interfaces here, the assumption being that PHYs on these
- * interfaces are C45
- */
-static inline int is_10g_interface(phy_interface_t interface)
-{
- return interface == PHY_INTERFACE_MODE_XGMII ||
- interface == PHY_INTERFACE_MODE_USXGMII ||
- interface == PHY_INTERFACE_MODE_10GBASER;
-}
-
#endif
/**
--
2.35.1
next prev parent reply other threads:[~2022-04-06 22:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 22:32 [PATCH u-boot-net v4 00/14] u-boot-net refactors, fixes, cleanups Marek Behún
2022-04-06 22:32 ` [PATCH u-boot-net v4 01/14] net: mdio-uclass: fix type for phy_mode_str and phy_handle_str Marek Behún
2022-04-06 22:32 ` [PATCH u-boot-net v4 02/14] net: mdio-uclass: use ARRAY_SIZE() Marek Behún
2022-04-06 22:32 ` [PATCH u-boot-net v4 03/14] net: introduce helpers to get PHY ofnode from MAC Marek Behún
2022-04-13 21:46 ` Tom Rini
2022-04-14 15:39 ` Tom Rini
2022-04-06 22:32 ` [PATCH u-boot-net v4 04/14] net: mdio-uclass: add wrappers for read/write/reset operations Marek Behún
2022-04-06 22:32 ` [PATCH u-boot-net v4 05/14] treewide: use dm_mdio_read/write/reset() wrappers Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 06/14] net: phy: fix parsing wrong property Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 07/14] net: introduce helpers to get PHY interface mode from a device/ofnode Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 08/14] treewide: Rename PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAX Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 09/14] treewide: Rename PHY_INTERFACE_MODE_NONE to PHY_INTERFACE_MODE_NA Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 10/14] phy: Move PHY_INTERFACE_MODE_NA to the beginning of the enum definition Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 11/14] net: phy: xilinx: Check interface type in ->config(), not ->probe() Marek Behún
2022-04-06 22:33 ` Marek Behún [this message]
2022-04-06 22:33 ` [PATCH u-boot-net v4 13/14] bcmgenet, sun8i_emac: Don't connect PHY two times Marek Behún
2022-04-06 22:33 ` [PATCH u-boot-net v4 14/14] net: phy: don't require PHY interface mode during PHY creation Marek Behún
2022-04-10 5:02 ` [PATCH u-boot-net v4 00/14] u-boot-net refactors, fixes, cleanups Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406223308.9833-13-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=joe.hershberger@ni.com \
--cc=marek.behun@nic.cz \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.