From: "hch@lst.de" <hch@lst.de>
To: Alan Adamson <alan.adamson@oracle.com>
Cc: Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH] nvme-core: mark passthru requests RQF_QUIET flag
Date: Thu, 7 Apr 2022 10:51:13 +0200 [thread overview]
Message-ID: <20220407085113.GB19062@lst.de> (raw)
In-Reply-To: <92C8BCED-6845-46D4-BCD0-78E790A5F86E@oracle.com>
On Wed, Apr 06, 2022 at 10:06:06PM +0000, Alan Adamson wrote:
> Using RQF_QUIET or blk_rq_is_passrhrough() will mean no nvme admin-passthru command will log an error.
> I ran into this using the blktests I’m coding up for verbose errors. Is this the behavior we want?
Well, you submitted the logging so we're curious about your use case.
SCSI skips logging errors for internally submitted commands, but not for
userspace passthrough. So we could move the RQF_QUIET into
__nvme_submit_sync_cmd / nvme_keep_alive_work / nvme_timeout / etc.
next prev parent reply other threads:[~2022-04-07 9:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 16:41 [PATCH] nvme-core: mark passthru requests RQF_QUIET flag Chaitanya Kulkarni
2022-04-06 16:52 ` Keith Busch
2022-04-06 17:01 ` Chaitanya Kulkarni
2022-04-06 17:21 ` Keith Busch
2022-04-06 22:06 ` Alan Adamson
2022-04-06 22:16 ` Chaitanya Kulkarni
2022-04-06 23:29 ` Alan Adamson
2022-04-07 19:40 ` Chaitanya Kulkarni
2022-04-07 8:48 ` Christoph Hellwig
2022-04-07 8:51 ` hch [this message]
2022-04-07 11:52 ` Sagi Grimberg
2022-04-07 20:10 ` Chaitanya Kulkarni
2022-04-07 20:35 ` Alan Adamson
2022-04-07 21:00 ` Chaitanya Kulkarni
2022-04-07 21:13 ` Alan Adamson
2022-04-08 2:13 ` Chaitanya Kulkarni
2022-04-08 16:24 ` Alan Adamson
2022-04-09 0:10 ` Chaitanya Kulkarni
2022-04-11 18:31 ` Alan Adamson
2022-04-11 19:53 ` Chaitanya Kulkarni
2022-04-11 21:39 ` Alan Adamson
2022-04-07 16:15 ` Alan Adamson
2022-04-06 17:03 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407085113.GB19062@lst.de \
--to=hch@lst.de \
--cc=alan.adamson@oracle.com \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.