All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v2 5/5] machine: remove temporary inline functions
Date: Thu, 7 Apr 2022 15:08:33 +0200	[thread overview]
Message-ID: <20220407130833.GF3143488@toto> (raw)
In-Reply-To: <20220331115312.30018-6-damien.hedde@greensocs.com>

On Thu, Mar 31, 2022 at 01:53:12PM +0200, Damien Hedde wrote:
> Now we have renamed all calls to these old functions, we
> can delete the temporary inline we've defined.
> 
> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>


> ---
>  include/hw/boards.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 1814793175..7efba048e9 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -52,11 +52,6 @@ void machine_parse_smp_config(MachineState *ms,
>   * it will get an error message.
>   */
>  void machine_class_allow_dynamic_device(MachineClass *mc, const char *type);
> -static inline void machine_class_allow_dynamic_sysbus_dev(MachineClass *mc,
> -                                                          const char *type)
> -{
> -    machine_class_allow_dynamic_device(mc, type);
> -}
>  
>  /**
>   * device_type_is_dynamic_allowed: Check if type is an allowed device
> @@ -72,11 +67,6 @@ static inline void machine_class_allow_dynamic_sysbus_dev(MachineClass *mc,
>   * Note that if @type has a parent type in the list, it is allowed too.
>   */
>  bool device_type_is_dynamic_allowed(MachineClass *mc, const char *type);
> -static inline bool device_type_is_dynamic_sysbus(MachineClass *mc,
> -                                                 const char *type)
> -{
> -    return device_type_is_dynamic_allowed(mc, type);
> -}
>  
>  /**
>   * device_is_dynamic_sysbus: test whether device is a dynamic sysbus device
> -- 
> 2.35.1
> 
> 


      reply	other threads:[~2022-04-07 13:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 11:53 [PATCH v2 0/5] Generalize the sysbus device machine allowance Damien Hedde
2022-03-31 11:53 ` [PATCH v2 1/5] qdev: add user_creatable_requires_machine_allowance class flag Damien Hedde
2022-04-07 13:05   ` Edgar E. Iglesias
2022-04-21 15:59   ` Peter Maydell
2022-04-21 16:46     ` Damien Hedde
2022-03-31 11:53 ` [PATCH v2 2/5] machine: update machine allowed list related functions/fields Damien Hedde
2022-04-07 13:05   ` Edgar E. Iglesias
2022-03-31 11:53 ` [PATCH v2 3/5] qdev-monitor: use the new user_creatable_requires_machine_allowance Damien Hedde
2022-04-07 13:07   ` Edgar E. Iglesias
2022-03-31 11:53 ` [PATCH v2 4/5] rename machine_class_allow_dynamic_sysbus_dev Damien Hedde
2022-04-07 13:07   ` Edgar E. Iglesias
2022-03-31 11:53 ` [PATCH v2 5/5] machine: remove temporary inline functions Damien Hedde
2022-04-07 13:08   ` Edgar E. Iglesias [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407130833.GF3143488@toto \
    --to=edgar.iglesias@gmail.com \
    --cc=berrange@redhat.com \
    --cc=damien.hedde@greensocs.com \
    --cc=eduardo@habkost.net \
    --cc=f4bug@amsat.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.