From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F145C433F5 for ; Thu, 7 Apr 2022 18:48:41 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EF26D17DE; Thu, 7 Apr 2022 20:47:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EF26D17DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1649357319; bh=SVrHOFOrp4LkSdxf9IrDTGBKQw2pW5xOGs2OcPhHsLI=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=trBCxzhqiqds8gAHw9SjrhU/0IYqelpkyPCeIoqh+qRC47qFKd3UA5Sn2GTTMqmsU mo98ftzkEOCZULs3gXcyHY/BgI62a8hLvU6/Zm/QqD6LoMky73YHeYfEEFbDXMKUM1 sMibTOLk0x50vl37jCYBJvZJddZ77RaLpZ1Y02aU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6DFDDF80141; Thu, 7 Apr 2022 20:47:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B5AEFF8024C; Thu, 7 Apr 2022 20:47:46 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 729DDF80054 for ; Thu, 7 Apr 2022 20:47:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 729DDF80054 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WeeIz+LT" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5BEC761DB6; Thu, 7 Apr 2022 18:47:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A729C385A4; Thu, 7 Apr 2022 18:47:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649357254; bh=SVrHOFOrp4LkSdxf9IrDTGBKQw2pW5xOGs2OcPhHsLI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WeeIz+LTk9Khndp+7GXzQ84jQ5ZQVEDaV71Nd4ySkPevv8V5xyAqR60zMiDUrVK0V Wia4OdAcUABKcolcbzNqWkDDSQiN2dzZxjUWHmGHw85ZJDYssq5llnQ+pNAxpDAwKo yrxmRBXninI7xL1hM2BFCgEJplx8LTib1Qc1pmXPGGoO9DFSlJCHHsBe76CMZSF4/g kuQRHY08smB1uQJ+6JNrc93gagqQSMMi4EUcTmgBophBZuvIyR7TA2X/oECBLNKdkT amQjgDCqW+tODzyuUOAY3NZ3EJDirmJuTGw+B/fcqJ4VitYdCfrFPmgZ9WexHFC/Lm SDAJSe8NJCDeQ== Date: Thu, 7 Apr 2022 20:47:28 +0200 From: Mauro Carvalho Chehab To: Pierre-Louis Bossart Subject: Re: [PATCH v4 3/4] ASoC: Intel: sof_es8336: add a quirk for headset at mic1 port Message-ID: <20220407204728.7710ebfa@coco.lan> In-Reply-To: <0dac70ef-1355-3379-ef41-eec6467886b1@linux.intel.com> References: <0dac70ef-1355-3379-ef41-eec6467886b1@linux.intel.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Bard Liao , Takashi Iwai , Jie Yang , Cezary Rojewski , Liam Girdwood , Hans de Goede , Mark Brown , =?UTF-8?B?UMOpdGVy?= Ujfalusi , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Em Wed, 6 Apr 2022 22:08:53 -0500 Pierre-Louis Bossart escreveu: > > static int sof_es8316_speaker_power_event(struct snd_soc_dapm_widget *w, > > @@ -145,13 +148,23 @@ static const struct snd_soc_dapm_route sof_es8316_audio_map[] = { > > {"Speaker", NULL, "HPOL"}, > > {"Speaker", NULL, "HPOR"}, > > {"Speaker", NULL, "Speaker Power"}, > > + > > + {"Differential Mux", "lin1-rin1", "MIC1"}, > > + {"Differential Mux", "lin2-rin2", "MIC2"}, > > + {"Differential Mux", "lin1-rin1 with 20db Boost", "MIC1"}, > > + {"Differential Mux", "lin2-rin2 with 20db Boost", "MIC2"}, > > this is surprising, shouldn't this be part of the codec driver? > > The part that should be machine-specific is really how MIC1 or MIC2 are > connected (as done below), but the routes above seem machine-independent? Yeah, this should be there... and it is there already ;-) Tested without it and it still works. So, I'll just drop the above. Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C5E4C433EF for ; Thu, 7 Apr 2022 18:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237686AbiDGStk (ORCPT ); Thu, 7 Apr 2022 14:49:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbiDGSth (ORCPT ); Thu, 7 Apr 2022 14:49:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58D3325D for ; Thu, 7 Apr 2022 11:47:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 19662B8260F for ; Thu, 7 Apr 2022 18:47:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A729C385A4; Thu, 7 Apr 2022 18:47:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649357254; bh=SVrHOFOrp4LkSdxf9IrDTGBKQw2pW5xOGs2OcPhHsLI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WeeIz+LTk9Khndp+7GXzQ84jQ5ZQVEDaV71Nd4ySkPevv8V5xyAqR60zMiDUrVK0V Wia4OdAcUABKcolcbzNqWkDDSQiN2dzZxjUWHmGHw85ZJDYssq5llnQ+pNAxpDAwKo yrxmRBXninI7xL1hM2BFCgEJplx8LTib1Qc1pmXPGGoO9DFSlJCHHsBe76CMZSF4/g kuQRHY08smB1uQJ+6JNrc93gagqQSMMi4EUcTmgBophBZuvIyR7TA2X/oECBLNKdkT amQjgDCqW+tODzyuUOAY3NZ3EJDirmJuTGw+B/fcqJ4VitYdCfrFPmgZ9WexHFC/Lm SDAJSe8NJCDeQ== Date: Thu, 7 Apr 2022 20:47:28 +0200 From: Mauro Carvalho Chehab To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, Hans de Goede , =?UTF-8?B?UMOpdGVy?= Ujfalusi , Bard Liao , Cezary Rojewski , Jaroslav Kysela , Jie Yang , Liam Girdwood , Mark Brown , Takashi Iwai , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] ASoC: Intel: sof_es8336: add a quirk for headset at mic1 port Message-ID: <20220407204728.7710ebfa@coco.lan> In-Reply-To: <0dac70ef-1355-3379-ef41-eec6467886b1@linux.intel.com> References: <0dac70ef-1355-3379-ef41-eec6467886b1@linux.intel.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, 6 Apr 2022 22:08:53 -0500 Pierre-Louis Bossart escreveu: > > static int sof_es8316_speaker_power_event(struct snd_soc_dapm_widget *w, > > @@ -145,13 +148,23 @@ static const struct snd_soc_dapm_route sof_es8316_audio_map[] = { > > {"Speaker", NULL, "HPOL"}, > > {"Speaker", NULL, "HPOR"}, > > {"Speaker", NULL, "Speaker Power"}, > > + > > + {"Differential Mux", "lin1-rin1", "MIC1"}, > > + {"Differential Mux", "lin2-rin2", "MIC2"}, > > + {"Differential Mux", "lin1-rin1 with 20db Boost", "MIC1"}, > > + {"Differential Mux", "lin2-rin2 with 20db Boost", "MIC2"}, > > this is surprising, shouldn't this be part of the codec driver? > > The part that should be machine-specific is really how MIC1 or MIC2 are > connected (as done below), but the routes above seem machine-independent? Yeah, this should be there... and it is there already ;-) Tested without it and it still works. So, I'll just drop the above. Thanks, Mauro