All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Jakob Koschel <jakobkoschel@gmail.com>
Cc: "Leon Romanovsky" <leon@kernel.org>,
	"Håkon Bugge" <haakon.bugge@oracle.com>,
	"Mark Zhang" <markzhang@nvidia.com>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Mike Rapoport" <rppt@kernel.org>,
	"Brian Johannesmeyer" <bjohannesmeyer@gmail.com>,
	"Cristiano Giuffrida" <c.giuffrida@vu.nl>,
	"Bos, H.J." <h.j.bos@vu.nl>,
	"Leon Romanovsky" <leonro@nvidia.com>
Subject: Re: [PATCH v3] IB/SA: replace usage of found with dedicated list iterator variable
Date: Fri, 8 Apr 2022 14:22:03 -0300	[thread overview]
Message-ID: <20220408172203.GA3637956@nvidia.com> (raw)
In-Reply-To: <20220331091634.644840-1-jakobkoschel@gmail.com>

On Thu, Mar 31, 2022 at 11:16:34AM +0200, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean.
> 
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
> 
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> 
> v1->v2:
> - set query correctly (Mark Zhang)
> 
> v2->v3:
> - remove changelog and link from git commit message (Leon Romanovsky)
> 
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
> 
>  drivers/infiniband/core/sa_query.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Applied to for-next, thanks

Jason

      reply	other threads:[~2022-04-08 17:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  9:16 [PATCH v3] IB/SA: replace usage of found with dedicated list iterator variable Jakob Koschel
2022-04-08 17:22 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220408172203.GA3637956@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=bjohannesmeyer@gmail.com \
    --cc=c.giuffrida@vu.nl \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=h.j.bos@vu.nl \
    --cc=haakon.bugge@oracle.com \
    --cc=jakobkoschel@gmail.com \
    --cc=leon@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=markzhang@nvidia.com \
    --cc=rppt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.