From: Florian Westphal <fw@strlen.de>
To: Topi Miettinen <toiwoton@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] doc: Document that kernel may accept unimplemented expressions
Date: Sat, 9 Apr 2022 11:51:52 +0200 [thread overview]
Message-ID: <20220409095152.GA19371@breakpoint.cc> (raw)
In-Reply-To: <20220409094402.22567-1-toiwoton@gmail.com>
Topi Miettinen <toiwoton@gmail.com> wrote:
> Kernel silently accepts input chain filters using meta skuid, meta
> skgid, meta cgroup or socket cgroupv2 expressions but they don't work
> yet. Warn the users of this possibility.
>
> Signed-off-by: Topi Miettinen <toiwoton@gmail.com>
> ---
> doc/nft.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/nft.txt b/doc/nft.txt
> index f7a53ac9..4820b4ae 100644
> --- a/doc/nft.txt
> +++ b/doc/nft.txt
> @@ -932,6 +932,11 @@ filter output oif wlan0
> ^^^^^^^^^^^^^^^^^^^^^^^
> ---------------------------------
>
> +Note that the kernel may accept expressions without errors even if it
> +doesn't implement the feature. For example, input chain filters using
> +*meta skuid*, *meta skgid*, *meta cgroup* or *socket cgroupv2*
> +expressions are silently accepted but they don't work yet.
Thats not correct.
Those expressions load values from skb->sk, i.e. the socket associated
with the packet.
In input, such socket may exist, either because of tproxy rules, early
demux, or bpf programs.
next prev parent reply other threads:[~2022-04-09 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 9:44 [PATCH] doc: Document that kernel may accept unimplemented expressions Topi Miettinen
2022-04-09 9:51 ` Florian Westphal [this message]
2022-04-09 10:10 ` Topi Miettinen
2022-04-09 10:22 ` Florian Westphal
2022-04-09 10:43 ` Topi Miettinen
2022-04-09 11:42 ` Florian Westphal
2022-04-09 13:01 ` Topi Miettinen
2022-04-10 15:16 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220409095152.GA19371@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=toiwoton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.