From: Jason Gunthorpe <jgg@nvidia.com>
To: Wenpeng Liang <liangwenpeng@huawei.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH for-next] RDMA/hns: Fix the missing device capability flag on the virtual function
Date: Sat, 9 Apr 2022 19:34:05 -0300 [thread overview]
Message-ID: <20220409223405.GC2120790@nvidia.com> (raw)
In-Reply-To: <20220409083523.12097-1-liangwenpeng@huawei.com>
On Sat, Apr 09, 2022 at 04:35:23PM +0800, Wenpeng Liang wrote:
> If the device is a virtual function, the corresponding device capability
> flag should be set when querying the device.
>
> Fixes: 0b567cde9d7a ("RDMA/hns: Enable RoCE on virtual functions")
> Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_main.c | 3 +++
> 1 file changed, 3 insertions(+)
No, this is only set if the device implements the _vf_ ops and uses
ipoib
roce devices never run ipoib
Jason
next prev parent reply other threads:[~2022-04-09 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 8:35 [PATCH for-next] RDMA/hns: Fix the missing device capability flag on the virtual function Wenpeng Liang
2022-04-09 22:34 ` Jason Gunthorpe [this message]
2022-04-11 9:35 ` Wenpeng Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220409223405.GC2120790@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=liangwenpeng@huawei.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.