From: Douglas Gilbert <dgilbert@interlog.com>
To: linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
hare@suse.de, bvanassche@acm.org
Subject: [PATCH v24 43/46] sg: no_dxfer: move to/from kernel buffers
Date: Sun, 10 Apr 2022 22:28:33 -0400 [thread overview]
Message-ID: <20220411022836.11871-44-dgilbert@interlog.com> (raw)
In-Reply-To: <20220411022836.11871-1-dgilbert@interlog.com>
When the NO_DXFER flag is use on a command/request, the data-in
and data-out buffers (if present) should not be ignored. Add
sg_rq_map_kern() function to handle this. Uses a single bio with
multiple bvec_s usually each holding multiple pages, if necessary.
The driver default element size is 32 KiB so if PAGE_SIZE is 4096
then get_order()==3 .
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
---
drivers/scsi/sg.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 55 insertions(+)
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index c180cd21ab65..eaf0bb9bd004 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -2796,6 +2796,59 @@ exit_sg(void)
idr_destroy(&sg_index_idr);
}
+static struct bio *
+sg_mk_kern_bio(int bvec_cnt)
+{
+ struct bio *biop;
+
+ if (bvec_cnt > BIO_MAX_VECS)
+ return NULL;
+ biop = bio_kmalloc(GFP_ATOMIC, bvec_cnt);
+ if (!biop)
+ return NULL;
+ biop->bi_end_io = bio_put;
+ return biop;
+}
+
+/*
+ * Setup to move data between kernel buffers managed by this driver and a SCSI device. Note that
+ * there is no corresponding 'unmap' call as is required by blk_rq_map_user() . Uses a single
+ * bio with an expanded appended bvec if necessary.
+ */
+static int
+sg_rq_map_kern(struct sg_request *srp, struct request_queue *q, struct request *rqq, int rw_ind)
+{
+ struct sg_scatter_hold *schp = &srp->sgat_h;
+ struct bio *bio;
+ int k, ln;
+ int op_flags = 0;
+ int num_sgat = schp->num_sgat;
+ int dlen = schp->dlen;
+ int pg_sz = 1 << (PAGE_SHIFT + schp->page_order);
+
+ SG_LOG(4, srp->parentfp, "%s: dlen=%d, pg_sz=%d\n", __func__, dlen, pg_sz);
+ if (num_sgat <= 0)
+ return 0;
+ if (rw_ind == WRITE)
+ op_flags = REQ_SYNC | REQ_IDLE;
+ bio = sg_mk_kern_bio(num_sgat);
+ if (!bio)
+ return -ENOMEM;
+ bio->bi_opf = req_op(rqq) | op_flags;
+
+ for (k = 0; k < num_sgat && dlen > 0; ++k, dlen -= ln) {
+ ln = min_t(int, dlen, pg_sz);
+ if (bio_add_pc_page(q, bio, schp->pages[k], ln, 0) < ln) {
+ bio_put(bio);
+ return -EINVAL;
+ }
+ }
+ /* used blk_rq_append_bio() before but this is simpler */
+ blk_rq_bio_prep(rqq, bio, num_sgat);
+ rqq->nr_phys_segments = (1 << schp->page_order) * num_sgat;
+ return 0;
+}
+
static inline void
sg_set_map_data(const struct sg_scatter_hold *schp, bool up_valid,
struct rq_map_data *mdp)
@@ -2945,6 +2998,8 @@ sg_start_req(struct sg_request *srp, struct sg_comm_wr_t *cwrp, int dxfer_dir)
if (IS_ENABLED(CONFIG_SCSI_PROC_FS) && res)
SG_LOG(1, sfp, "%s: blk_rq_map_user() res=%d\n",
__func__, res);
+ } else { /* transfer data to/from kernel buffers */
+ res = sg_rq_map_kern(srp, q, rqq, r0w);
}
fini:
if (unlikely(res)) { /* failure, free up resources */
--
2.25.1
next prev parent reply other threads:[~2022-04-11 2:32 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 2:27 [PATCH v24 00/46] sg: add v4 interface Douglas Gilbert
2022-04-11 2:27 ` [PATCH v24 01/46] sg: move functions around Douglas Gilbert
2022-04-11 2:27 ` [PATCH v24 02/46] sg: remove typedefs, type+formatting cleanup Douglas Gilbert
2022-04-11 2:27 ` [PATCH v24 03/46] sg: sg_log and is_enabled Douglas Gilbert
2022-04-11 2:27 ` [PATCH v24 04/46] sg: rework sg_poll(), minor changes Douglas Gilbert
2022-04-11 2:27 ` [PATCH v24 05/46] sg: bitops in sg_device Douglas Gilbert
2022-04-11 2:27 ` [PATCH v24 06/46] sg: make open count an atomic Douglas Gilbert
2022-04-11 2:27 ` [PATCH v24 07/46] sg: move header to uapi section Douglas Gilbert
2022-04-11 2:27 ` [PATCH v24 08/46] sg: speed sg_poll and sg_get_num_waiting Douglas Gilbert
2022-04-11 2:27 ` [PATCH v24 09/46] sg: sg_allow_if_err_recovery and renames Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 10/46] sg: improve naming Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 11/46] sg: change rwlock to spinlock Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 12/46] sg: ioctl handling Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 13/46] sg: split sg_read Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 14/46] sg: sg_common_write add structure for arguments Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 15/46] sg: rework sg_vma_fault Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 16/46] sg: rework sg_mmap Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 17/46] sg: replace sg_allow_access Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 18/46] sg: rework scatter gather handling Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 19/46] sg: introduce request state machine Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 20/46] sg: sg_find_srp_by_id Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 21/46] sg: sg_fill_request_element Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 22/46] sg: printk change %p to %pK Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 23/46] sg: xarray for fds in device Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 24/46] sg: xarray for reqs in fd Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 25/46] sg: replace rq array with xarray Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 26/46] sg: sense buffer rework Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 27/46] sg: add sg v4 interface support Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 28/46] sg: rework debug info Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 29/46] sg: add 8 byte SCSI LUN to sg_scsi_id Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 30/46] sg: expand sg_comm_wr_t Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 31/46] sg: add sg_iosubmit_v3 and sg_ioreceive_v3 ioctls Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 32/46] sg: add some __must_hold macros Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 33/46] sg: move procfs objects to avoid forward decls Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 34/46] sg: protect multiple receivers Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 35/46] sg: first debugfs support Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 36/46] sg: rework mmap support Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 37/46] sg: defang allow_dio Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 38/46] sg: warn v3 write system call users Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 39/46] sg: add mmap_sz tracking Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 40/46] sg: remove rcv_done request state Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 41/46] sg: track lowest inactive and await indexes Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 42/46] sg: remove unit attention check for device changed Douglas Gilbert
2022-04-11 2:28 ` Douglas Gilbert [this message]
2022-04-11 2:28 ` [PATCH v24 44/46] sg: add bio_poll support Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 45/46] sg: add statistics similar to st Douglas Gilbert
2022-04-11 2:28 ` [PATCH v24 46/46] sg: bump version to 4.0.13 Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411022836.11871-44-dgilbert@interlog.com \
--to=dgilbert@interlog.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.