All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: christian.koenig@amd.com
Cc: nouveau@lists.freedesktop.org
Subject: [Nouveau] [bug report] drm/nouveau: stop using dma_resv_excl_fence
Date: Mon, 11 Apr 2022 09:39:00 +0300	[thread overview]
Message-ID: <20220411063900.GA9660@kili> (raw)

Hello Christian König,

The patch 756cc94d15fa: "drm/nouveau: stop using dma_resv_excl_fence"
from Nov 3, 2021, leads to the following Smatch static checker
warning:

	drivers/gpu/drm/nouveau/nouveau_bo.c:971 nouveau_bo_vm_cleanup()
	error: uninitialized symbol 'fence'.

drivers/gpu/drm/nouveau/nouveau_bo.c
    955 static void
    956 nouveau_bo_vm_cleanup(struct ttm_buffer_object *bo,
    957                       struct nouveau_drm_tile *new_tile,
    958                       struct nouveau_drm_tile **old_tile)
    959 {
    960         struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
    961         struct drm_device *dev = drm->dev;
    962         struct dma_fence *fence;
    963         int ret;
    964 
    965         /* TODO: This is actually a memory management dependency */
    966         ret = dma_resv_get_singleton(bo->base.resv, false, &fence);
    967         if (ret)
    968                 dma_resv_wait_timeout(bo->base.resv, false, false,
    969                                       MAX_SCHEDULE_TIMEOUT);

"fence" is uninitialized of dma_resv_get_singleton() fails.

    970 
--> 971         nv10_bo_put_tile_region(dev, *old_tile, fence);
    972         *old_tile = new_tile;
    973 }

regards,
dan carpenter

                 reply	other threads:[~2022-04-11  6:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220411063900.GA9660@kili \
    --to=dan.carpenter@oracle.com \
    --cc=christian.koenig@amd.com \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.